From: Gabriel Fernandez <gabriel.fernandez@st.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] phy: miphy28lp: unlock on error in miphy28lp_init()
Date: Wed, 17 Dec 2014 10:23:09 +0000 [thread overview]
Message-ID: <5491598D.2050808@st.com> (raw)
In-Reply-To: <20141216235523.GF31467@mwanda>
Acked-by: Gabriel Fernandez <gabriel.fernandez@linaro.org>
Thanks Dan !
Best Regards
Gabriel
On 12/17/2014 12:55 AM, Dan Carpenter wrote:
> We need to unlock before returning the -EINVAL here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/phy/phy-miphy28lp.c b/drivers/phy/phy-miphy28lp.c
> index e34da13..27fa62c 100644
> --- a/drivers/phy/phy-miphy28lp.c
> +++ b/drivers/phy/phy-miphy28lp.c
> @@ -1050,7 +1050,8 @@ static int miphy28lp_init(struct phy *phy)
> ret = miphy28lp_init_usb3(miphy_phy);
> break;
> default:
> - return -EINVAL;
> + ret = -EINVAL;
> + break;
> }
>
> mutex_unlock(&miphy_dev->miphy_mutex);
prev parent reply other threads:[~2014-12-17 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 23:55 [patch] phy: miphy28lp: unlock on error in miphy28lp_init() Dan Carpenter
2014-12-17 10:23 ` Gabriel Fernandez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5491598D.2050808@st.com \
--to=gabriel.fernandez@st.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.