From: Juri Lelli <juri.lelli@arm.com>
To: Luca Abeni <luca.abeni@unitn.it>, Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@gmail.com>,
Dario Faggioli <raistlin@linux.it>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] SCHED_DEADLINE fixes
Date: Wed, 17 Dec 2014 12:49:16 +0000 [thread overview]
Message-ID: <54917BCC.9070001@arm.com> (raw)
In-Reply-To: <1418813432-20797-1-git-send-email-luca.abeni@unitn.it>
Hi Luca,
On 17/12/14 10:50, Luca Abeni wrote:
> Hi all,
>
> I noticed some discrepancies between the schedule produced
> by SCHED_DEADLINE and the expectations from real-time
> scheduling theory. After some investigations, it turned out
> that such discrepancies are due to two bugs in deadline.c,
> which are particularly visible when using global scheduling
> on multiple CPUs (see the two patches for more details).
>
> I think the first bug (fixed in patch 0001) is particularly
> critical, because it causes a violation of the SCHED_DEADLINE
> guarantee (if the total load is smaller than the number of
> CPUs, there is an upper bound for the response times. This is
> a well known property for global EDF, but is not respected by
> SCHED_DEADLINE - see patch 0001 for more details).
> The second patch is IMHO also important, but less critical.
>
I already reviewed and tested them. They looks ok and are important
fixes. ACK for both. :)
Thanks a lot!
- Juri
> Luca Abeni (2):
> Fix migration of SCHED_DEADLINE tasks
> Avoid double-accounting in case of missed deadlines
>
> kernel/sched/deadline.c | 25 ++++---------------------
> 1 file changed, 4 insertions(+), 21 deletions(-)
>
prev parent reply other threads:[~2014-12-17 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 10:50 [PATCH 0/2] SCHED_DEADLINE fixes Luca Abeni
2014-12-17 10:50 ` [PATCH 1/2] Fix migration of SCHED_DEADLINE tasks Luca Abeni
2015-01-09 12:33 ` [tip:sched/urgent] sched/deadline: " tip-bot for Luca Abeni
2014-12-17 10:50 ` [PATCH 2/2] Avoid double-accounting in case of missed deadlines Luca Abeni
2015-01-09 12:34 ` [tip:sched/urgent] sched/deadline: " tip-bot for Luca Abeni
2014-12-17 12:49 ` Juri Lelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54917BCC.9070001@arm.com \
--to=juri.lelli@arm.com \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@unitn.it \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=raistlin@linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.