From: alex chen <alex.chen@huawei.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Joseph Qi <joseph.qi@huawei.com>
Subject: Re: dm: check error instead of r in clone_endio
Date: Thu, 18 Dec 2014 09:41:03 +0800 [thread overview]
Message-ID: <549230AF.4030804@huawei.com> (raw)
In-Reply-To: <20141217173443.GC27737@redhat.com>
On 2014/12/18 1:34, Mike Snitzer wrote:
> On Wed, Dec 17 2014 at 1:37am -0500,
> alex chen <alex.chen@huawei.com> wrote:
>
>> In the clone_endio, when target_type is linear and WRITE SAME bio
>> fails, r will be always be initialized 0 because of null end_io, and
>> in this case WRITE SAME will not be disabled.
>> So we should check error instead of r.
>>
>> Signed-off-by: Alex Chen <alex.chen@huawei.com>
>
> I've fixed it a bit differently (clone_endio now matches dm_done) and
> have staged it for 3.19, see:
> https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=5164bece1673cdf04782f8ed3fba70743700f5da
>
> Thanks.
OK, thank you!
>
>
prev parent reply other threads:[~2014-12-18 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 6:37 [PATCH] dm: check error instead of r in clone_endio alex chen
2014-12-17 17:34 ` Mike Snitzer
2014-12-18 1:41 ` alex chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549230AF.4030804@huawei.com \
--to=alex.chen@huawei.com \
--cc=dm-devel@redhat.com \
--cc=joseph.qi@huawei.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.