From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH for 4.6 07/13] xen: Introduce a generic way to describe device Date: Thu, 18 Dec 2014 08:52:28 +0000 Message-ID: <549295CC.2060309@linaro.org> References: <1418760534-18163-1-git-send-email-julien.grall@linaro.org> <1418760534-18163-8-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Y1Wp9-0008VQ-0l for xen-devel@lists.xenproject.org; Thu, 18 Dec 2014 08:52:43 +0000 Received: by mail-wi0-f175.google.com with SMTP id l15so988170wiw.2 for ; Thu, 18 Dec 2014 00:52:31 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Zhang, Yang Z" , "xen-devel@lists.xenproject.org" Cc: Keir Fraser , "ian.campbell@citrix.com" , "manish.jaggi@caviumnetworks.com" , "tim@xen.org" , "stefano.stabellini@citrix.com" , Jan Beulich List-Id: xen-devel@lists.xenproject.org Hello Zhang, Please respect the netiquette and avoid lines over 80 characters. On 18/12/2014 01:12, Zhang, Yang Z wrote: > I'd suggest splitting the changes to common code to a separate patch and also CC the VT-d/AMD maintainers. This patch is already common code. Though, there was some changes in arch/arm because of interdependency. Splitting more won't make more sense. > Because I didn't find those definitions when reviewing the 8th patch and I need to search the whole patch set to find them. it's not a new problem. A patch may have a dependency on another patch who has dependency on another one... This would end up to be CCed on every patch and spam your inbox. I usually provide a git repo with my patch series in the cover letter. So if you miss anything you can look to the code and found the relevant patch. Anyway... I will CC next time Sincerely yours, -- Julien Grall