From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCHv2 0/3] hdmi: add unpack and logging functions Date: Thu, 18 Dec 2014 10:19:58 +0100 Message-ID: <54929C3E.7020001@xs4all.nl> References: <1417522126-31771-1-git-send-email-hverkuil@xs4all.nl> <54895C92.9000007@xs4all.nl> <20141218082457.GB29856@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lb3-smtp-cloud6.xs4all.net (lb3-smtp-cloud6.xs4all.net [194.109.24.31]) by gabe.freedesktop.org (Postfix) with ESMTP id 582C56E3A4 for ; Thu, 18 Dec 2014 01:21:33 -0800 (PST) In-Reply-To: <20141218082457.GB29856@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: marbugge@cisco.com, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMTIvMTgvMTQgMDk6MjQsIFRoaWVycnkgUmVkaW5nIHdyb3RlOgo+IE9uIFRodSwgRGVjIDEx LCAyMDE0IGF0IDA5OjU3OjU0QU0gKzAxMDAsIEhhbnMgVmVya3VpbCB3cm90ZToKPj4gSGkgVGhp ZXJyeSwKPj4KPj4gT24gMTIvMDIvMTQgMTM6MDgsIEhhbnMgVmVya3VpbCB3cm90ZToKPj4+IFRo aXMgcGF0Y2ggc2VyaWVzIGFkZHMgbmV3IEhETUkgMi4wL0NFQS04NjEtRiBkZWZpbmVzIHRvIGhk bWkuaCBhbmQKPj4+IGFkZHMgdW5wYWNraW5nIGFuZCBsb2dnaW5nIGZ1bmN0aW9ucyB0byBoZG1p LmMuIEl0IGFsc28gdXNlcyB0aG9zZQo+Pj4gaW4gdGhlIFY0TDIgYWR2Nzg0MiBkcml2ZXIgKGFu ZCB0aGV5IHdpbGwgYmUgdXNlZCBpbiBvdGhlciBIRE1JIGRyaXZlcnMKPj4+IG9uY2UgdGhpcyBm dW5jdGlvbmFsaXR5IGlzIG1lcmdlZCkuCj4+Pgo+Pj4gUGF0Y2hlcyAyIGFuZCAzIGhhdmUgYmVl biBwb3N0ZWQgYmVmb3JlIGJ5IE1hcnRpbiBCdWdnZS4gSXQgc3RhbGxlZCwgYnV0Cj4+PiBJIGFt IHRha2luZyBvdmVyIGZyb20gTWFydGluIHRvIHRyeSBhbmQgZ2V0IHRoaXMgaXMuIEkgd2FudCB0 byB1c2UgdGhpcwo+Pj4gaW4gYSBidW5jaCBvZiB2NGwyIGRyaXZlcnMsIHNvIEkgd291bGQgcmVh bGx5IGxpa2UgdG8gc2VlIHRoaXMgbWVyZ2VkLgo+Pj4KPj4+IENoYW5nZXMgc2luY2UgdjE6Cj4+ Pgo+Pj4gLSByZW5hbWUgSERNSV9DT05URU5UX1RZUEVfTk9ORSB0byBIRE1JX0NPTlRFTlRfVFlQ RV9HUkFQSElDUyB0byBjb25mb3JtCj4+PiAgIHRvIENFQS04NjEtRi4KPj4+IC0gYWRkZWQgbWlz c2luZyBIRE1JX0FVRElPX0NPRElOR19UWVBFX0NYVC4KPj4+IC0gQmUgZXhwbGljaXQ6IG91dCBv ZiByYW5nZSB2YWx1ZXMgYXJlIGNhbGxlZCAiSW52YWxpZCIsIHJlc2VydmVkCj4+PiAgIHZhbHVl cyBhcmUgY2FsbGVkICJSZXNlcnZlZCIuCj4+PiAtIEluY29ycG9yYXRlZCBtb3N0IG9mIFRoaWVy cnkncyBzdWdnZXN0aW9ucy4gRXhjZXB0aW9uOiBJIGRpZG4ndAo+Pj4gICBjcmVhdGUgLi4uX2dl dF9uYW1lKGJ1ZmZlciwgbGVuZ3RoLCAuLi4pIGZ1bmN0aW9ucy4gSSB0aGluayBpdCBtYWtlcwo+ Pj4gICB0aGUgQVBJIGF3a3dhcmQgYW5kIEkgYW0gbm90IGNvbnZpbmNlZCB0aGF0IGl0IGlzIHRo YXQgdXNlZnVsLgo+Pj4gICBJIGFsc28ga2VwdCAiTm8gRGF0YSIgc2luY2UgdGhhdCdzIHdoYXQg Q0VBLTg2MS1GIGNhbGxzIGl0LiBJIGFsc28KPj4+ICAgdGhpbmsgdGhhdCAiTm8gRGF0YSIgaXMg YSBiZXR0ZXIgZGVzY3JpcHRpb24gdGhhbiAiTm9uZSIgc2luY2UgaXQKPj4+ICAgcmVhbGx5IG1l YW5zIHRoYXQgbm9ib2R5IGJvdGhlcmVkIHRvIGZpbGwgdGhpcyBpbi4KPj4+Cj4+PiBQbGVhc2Ug bGV0IG1lIGtub3cgaWYgdGhlcmUgYXJlIG1vcmUgdGhpbmdzIHRoYXQgbmVlZCB0byBiZSBhZGRy ZXNzZWQgaW4KPj4+IHRoZXNlIHBhdGNoZXMgYmVmb3JlIHRoZXkgY2FuIGJlIG1lcmdlZC4KPj4K Pj4gQW55IGNvbW1lbnRzIGFib3V0IHRoaXMgdjI/Cj4gCj4gU29ycnkgZm9yIHRha2luZyBzbyBs b25nLiBUaGlzIGdvdCBidXJyaWVkIHVuZGVyIGEgbG90IG9mIG90aGVyIHN0dWZmLgoKTm8gcHJv YmxlbSEgTXVjaCBhcHByZWNpYXRlZCB0aGF0IHlvdSB0b29rIHRoZSB0aW1lIGZvciB0aGlzIHJl dmlldy4KCj4gSSBoYXZlIHNvbWUgbWlub3IgY29tbWVudHMgdG8gcGF0Y2ggMi8zLCBidXQgb24g dGhlIHdob2xlIHRoaXMgbG9va3MgdmVyeQo+IG5pY2UuCgpJJ2xsIG1ha2UgYSB2MyAocHJvYmFi bHkgdG9tb3Jyb3cpIGZpeGluZyBtb3N0IG9mIHlvdXIgY29tbWVudHMgYWx0aG91Z2ggSSdtCmtl ZXBpbmcgaGRtaV9sb2cuIFVzaW5nIGRldl9wcmludGsganVzdCBtYWRlIHRoZSBjb2RlIGEgbG90 IGhhcmRlciB0byByZWFkCklNSE8uIEkgcGxhbiB0byBhZGRyZXNzIGFsbCBvdGhlciBjb21tZW50 cy4KCj4+IElmIG5vdCwgaXMgdGhpcyBzb21ldGhpbmcgeW91IG9yIHNvbWVvbmUgZWxzZSBmcm9t IGRyaS1kZXZlbCB3aWxsCj4+IHRha2UsIG9yIGNhbiBpdCBiZSBtZXJnZWQgdGhyb3VnaCB0aGUg bWVkaWEgZ2l0IHJlcG9zaXRvcnk/Cj4gCj4gSSdtIG5vdCBhd2FyZSBvZiBhbnlvbmUgY3VycmVu dGx5IGRvaW5nIHdvcmsgb24gdGhpcyBmb3IgRFJNLCBzbyBJIHRoaW5rCj4gaXQnZCBiZSBmaW5l IGlmIHlvdSB0b29rIGl0IHRocm91Z2ggdGhlIG1lZGlhIGdpdCB0cmVlLCBlc3BlY2lhbGx5IHNp bmNlCj4gcGF0Y2ggMy8zIGNsZWFybHkgYmVsb25ncyB0aGVyZS4KCk9LLCBncmVhdC4gSSdkIGFw cHJlY2lhdGUgaXQgaWYgeW91IGNhbiBBY2sgdGhlIHYzIHBhdGNoIHNlcmllcyB3aGVuIGl0J3MK cG9zdGVkLgoKPiBJZiB3ZSBldmVyIG5lZWQgdG8gcmVzb2x2ZSBkZXBlbmRlbmNpZXMgYmV0d2Vl biB0aGlzIGFuZCBuZXcgd29yayBpbiBEUk0KPiB3ZSBjb3VsZCBzZXQgdXAgYSBzdGFibGUgYnJh bmNoIGNvbnRhaW5pbmcgcGF0Y2hlcyAxLzMgYW5kIDIvMyB3aGljaCBjYW4KPiBiZSBtZXJnZWQg aW50byBib3RoIHRyZWVzLgoKUmVnYXJkcywKCglIYW5zCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:57675 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbaLRJVb (ORCPT ); Thu, 18 Dec 2014 04:21:31 -0500 Message-ID: <54929C3E.7020001@xs4all.nl> Date: Thu, 18 Dec 2014 10:19:58 +0100 From: Hans Verkuil MIME-Version: 1.0 To: Thierry Reding CC: linux-media@vger.kernel.org, marbugge@cisco.com, dri-devel@lists.freedesktop.org Subject: Re: [PATCHv2 0/3] hdmi: add unpack and logging functions References: <1417522126-31771-1-git-send-email-hverkuil@xs4all.nl> <54895C92.9000007@xs4all.nl> <20141218082457.GB29856@ulmo> In-Reply-To: <20141218082457.GB29856@ulmo> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 12/18/14 09:24, Thierry Reding wrote: > On Thu, Dec 11, 2014 at 09:57:54AM +0100, Hans Verkuil wrote: >> Hi Thierry, >> >> On 12/02/14 13:08, Hans Verkuil wrote: >>> This patch series adds new HDMI 2.0/CEA-861-F defines to hdmi.h and >>> adds unpacking and logging functions to hdmi.c. It also uses those >>> in the V4L2 adv7842 driver (and they will be used in other HDMI drivers >>> once this functionality is merged). >>> >>> Patches 2 and 3 have been posted before by Martin Bugge. It stalled, but >>> I am taking over from Martin to try and get this is. I want to use this >>> in a bunch of v4l2 drivers, so I would really like to see this merged. >>> >>> Changes since v1: >>> >>> - rename HDMI_CONTENT_TYPE_NONE to HDMI_CONTENT_TYPE_GRAPHICS to conform >>> to CEA-861-F. >>> - added missing HDMI_AUDIO_CODING_TYPE_CXT. >>> - Be explicit: out of range values are called "Invalid", reserved >>> values are called "Reserved". >>> - Incorporated most of Thierry's suggestions. Exception: I didn't >>> create ..._get_name(buffer, length, ...) functions. I think it makes >>> the API awkward and I am not convinced that it is that useful. >>> I also kept "No Data" since that's what CEA-861-F calls it. I also >>> think that "No Data" is a better description than "None" since it >>> really means that nobody bothered to fill this in. >>> >>> Please let me know if there are more things that need to be addressed in >>> these patches before they can be merged. >> >> Any comments about this v2? > > Sorry for taking so long. This got burried under a lot of other stuff. No problem! Much appreciated that you took the time for this review. > I have some minor comments to patch 2/3, but on the whole this looks very > nice. I'll make a v3 (probably tomorrow) fixing most of your comments although I'm keeping hdmi_log. Using dev_printk just made the code a lot harder to read IMHO. I plan to address all other comments. >> If not, is this something you or someone else from dri-devel will >> take, or can it be merged through the media git repository? > > I'm not aware of anyone currently doing work on this for DRM, so I think > it'd be fine if you took it through the media git tree, especially since > patch 3/3 clearly belongs there. OK, great. I'd appreciate it if you can Ack the v3 patch series when it's posted. > If we ever need to resolve dependencies between this and new work in DRM > we could set up a stable branch containing patches 1/3 and 2/3 which can > be merged into both trees. Regards, Hans