From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call
Date: Thu, 18 Dec 2014 10:26:46 +0100 [thread overview]
Message-ID: <54929DD6.8080208@6wind.com> (raw)
In-Reply-To: <54929301.2010007-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Hi,
On 12/18/2014 09:40 AM, Olivier MATZ wrote:
> Hi Neil,
>
> On 12/17/2014 06:03 PM, Neil Horman wrote:
>> Back in:
>>
>> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db
>> Author: Alan Carew <alan.carew-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>> Date: Fri Dec 5 15:19:07 2014 +0100
>>
>> cmdline: fix overflow on bsd
>>
>> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. This
>> patch makes the needed correction to avoid a build break
>>
>> Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
>
> Sorry, I missed that one, thank you for fixing it.
>
> Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Hmm, I agree with Thomas that sizeof(dict->addr) would be better
as it explicitly uses the length of the field we write into.
Regards,
Olivier
next prev parent reply other threads:[~2014-12-18 9:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 17:03 [PATCH] xenvirt: Fix build break on cmdline_parse_etheraddr call Neil Horman
[not found] ` <1418835808-18803-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-12-17 22:20 ` Thomas Monjalon
2014-12-18 11:25 ` Neil Horman
[not found] ` <20141218112523.GA18008-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-12-18 12:21 ` Thomas Monjalon
2014-12-18 19:57 ` Neil Horman
2014-12-18 13:51 ` Qiu, Michael
[not found] ` <533710CFB86FA344BFBF2D6802E60286CA0EE5-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-18 19:58 ` Neil Horman
2014-12-18 3:40 ` Cao, Waterman
[not found] ` <AA3F441F262C58498CD6D0C1801DE7EB0AC3A900-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-18 11:26 ` Neil Horman
2014-12-18 8:40 ` Olivier MATZ
[not found] ` <54929301.2010007-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-18 9:26 ` Olivier MATZ [this message]
2014-12-18 11:31 ` [PATCH v2] " Neil Horman
2014-12-18 13:45 ` Qiu, Michael
[not found] ` <533710CFB86FA344BFBF2D6802E60286CA0ECB-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-18 20:54 ` Neil Horman
2014-12-19 5:02 ` Qiu, Michael
[not found] ` <1418902316-30266-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-12-18 22:13 ` Thomas Monjalon
2014-12-18 16:17 ` [PATCH] " Stephen Hemminger
2014-12-18 16:40 ` Thomas Monjalon
2014-12-18 20:57 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54929DD6.8080208@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.