All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kevin Hilman <khilman@kernel.org>
Cc: amit daniel kachhap <amit.daniel@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	LAK <linux-arm-kernel@lists.infradead.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Len Brown <len.brown@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Thomas Abraham <thomas.ab@samsung.com>,
	Pankaj Dubey <pankaj.dubey@samsung.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC v3 1/2] PM / Domains: Extend API pm_genpd_dev_need_restore to use restore types
Date: Thu, 18 Dec 2014 11:05:18 +0100	[thread overview]
Message-ID: <5492A6DE.5020704@samsung.com> (raw)
In-Reply-To: <5418986.E58ik2Q1Hm@vostro.rjw.lan>

On 18/12/14 01:58, Rafael J. Wysocki wrote:
>>>> What's needed to solve this problem is a generalized way to have runtime
>>>> > >> PM dependencies between devices.  Runtime PM already automatically
>>>> > >> handles parent devices as one type of dependent device (e.g. a parent
>>>> > >> device needs to be runtime PM resumed before its child.)  So what's
>>>> > >> needed is a generic way to other PM dependencies with the runtime PM
>>>> > >> core (not the genpd core.)
>>> > >
>>> > > Considering the example above with three devices, device D1 and D2 are
>>> > > passive components in this power domain. These devices only need to
>>> > > know the state changes of the power domains but would not control the
>>> > > power domain themselves nor put forth constraints in the power domain
>>> > > state changes. So I did not clearly understand as to how this example
>>> > > could be solved by introducing changes in runtime PM core.
>> > 
>> > Your solution only solves the problems for devices managed by genpd.
>> > 
>> > If I understood your example correctly, what you really want to solve
>> > this problem more generically is to be able to tell the runtime PM core
>> > that D3 has a dependency on D1 and D2.  Then, whenver the runtime PM
>> > core is doing get/put operations for D3, it needs to also do them for D1
>> > and D2.

Indeed, I think it would solve most of the problems if we were able to
model the PM dependencies between devices which would then be handled
in the PM core.  I recall something like this has been proposed a while
ago [1].

>> > This will accomplish the same as your proposed approach, but work for
>> > any devices in any PM domains.
>
> Plus, it is not limited to runtime PM, really.  It affects system suspend
> too.

[1] https://lkml.org/lkml/2009/8/26/485

-- 
Regards,
Sylwester

WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC v3 1/2] PM / Domains: Extend API pm_genpd_dev_need_restore to use restore types
Date: Thu, 18 Dec 2014 11:05:18 +0100	[thread overview]
Message-ID: <5492A6DE.5020704@samsung.com> (raw)
In-Reply-To: <5418986.E58ik2Q1Hm@vostro.rjw.lan>

On 18/12/14 01:58, Rafael J. Wysocki wrote:
>>>> What's needed to solve this problem is a generalized way to have runtime
>>>> > >> PM dependencies between devices.  Runtime PM already automatically
>>>> > >> handles parent devices as one type of dependent device (e.g. a parent
>>>> > >> device needs to be runtime PM resumed before its child.)  So what's
>>>> > >> needed is a generic way to other PM dependencies with the runtime PM
>>>> > >> core (not the genpd core.)
>>> > >
>>> > > Considering the example above with three devices, device D1 and D2 are
>>> > > passive components in this power domain. These devices only need to
>>> > > know the state changes of the power domains but would not control the
>>> > > power domain themselves nor put forth constraints in the power domain
>>> > > state changes. So I did not clearly understand as to how this example
>>> > > could be solved by introducing changes in runtime PM core.
>> > 
>> > Your solution only solves the problems for devices managed by genpd.
>> > 
>> > If I understood your example correctly, what you really want to solve
>> > this problem more generically is to be able to tell the runtime PM core
>> > that D3 has a dependency on D1 and D2.  Then, whenver the runtime PM
>> > core is doing get/put operations for D3, it needs to also do them for D1
>> > and D2.

Indeed, I think it would solve most of the problems if we were able to
model the PM dependencies between devices which would then be handled
in the PM core.  I recall something like this has been proposed a while
ago [1].

>> > This will accomplish the same as your proposed approach, but work for
>> > any devices in any PM domains.
>
> Plus, it is not limited to runtime PM, really.  It affects system suspend
> too.

[1] https://lkml.org/lkml/2009/8/26/485

-- 
Regards,
Sylwester

  reply	other threads:[~2014-12-18 10:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-13 16:51 [PATCH RFC v3 1/2] PM / Domains: Extend API pm_genpd_dev_need_restore to use restore types Amit Daniel Kachhap
2014-12-13 16:51 ` Amit Daniel Kachhap
2014-12-13 16:51 ` [PATCH RFC v3 2/2] clk: samsung: Add PM runtime support for clocks Amit Daniel Kachhap
2014-12-13 16:51   ` Amit Daniel Kachhap
2014-12-16 11:10 ` [PATCH RFC v3 1/2] PM / Domains: Extend API pm_genpd_dev_need_restore to use restore types Marek Szyprowski
2014-12-16 11:10   ` Marek Szyprowski
2014-12-16 22:10   ` Kevin Hilman
2014-12-16 22:10     ` Kevin Hilman
2014-12-17 14:36     ` amit daniel kachhap
2014-12-17 14:36       ` amit daniel kachhap
2014-12-17 18:25       ` Kevin Hilman
2014-12-17 18:25         ` Kevin Hilman
2014-12-17 18:25         ` Kevin Hilman
2014-12-18  0:58         ` Rafael J. Wysocki
2014-12-18  0:58           ` Rafael J. Wysocki
2014-12-18 10:05           ` Sylwester Nawrocki [this message]
2014-12-18 10:05             ` Sylwester Nawrocki
2014-12-19  2:17             ` Rafael J. Wysocki
2014-12-19  2:17               ` Rafael J. Wysocki
2014-12-17  2:43   ` amit daniel kachhap
2014-12-17  2:43     ` amit daniel kachhap
2014-12-17 13:08     ` Marek Szyprowski
2014-12-17 13:08       ` Marek Szyprowski
2014-12-17 14:56       ` amit daniel kachhap
2014-12-17 14:56         ` amit daniel kachhap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5492A6DE.5020704@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=amit.daniel@samsung.com \
    --cc=geert+renesas@glider.be \
    --cc=kgene.kim@samsung.com \
    --cc=khilman@kernel.org \
    --cc=len.brown@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=pankaj.dubey@samsung.com \
    --cc=rjw@rjwysocki.net \
    --cc=thomas.ab@samsung.com \
    --cc=tomasz.figa@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.