Re: [PATCH] xfs_repair: fix max block offset test

From: Eric Sandeen <sandeen@redhat.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Eryu Guan <eguan@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_repair: fix max block offset test
Date: Thu, 18 Dec 2014 10:43:03 -0600	[thread overview]
Message-ID: <54930417.7030601@redhat.com> (raw)
In-Reply-To: <20141218151835.GC13471@laptop.bfoster>

On 12/18/14 9:18 AM, Brian Foster wrote:

> Thought this looked familiar:
> 
> http://oss.sgi.com/archives/xfs/2014-09/msg00524.html

oh, whoops.  let me go read that, sorry!

-Eric

> Either one is fine with me. If we use the fix below, I think we should
> update the error message since it technically refers to the extent
> offset and we slightly tweak the meaning of the failure.
> 
> Brian
> 
>>
>> diff --git a/repair/dinode.c b/repair/dinode.c
>> index 38a6562..ca57a61 100644
>> --- a/repair/dinode.c
>> +++ b/repair/dinode.c
>> @@ -667,7 +667,9 @@ _("inode %" PRIu64 " - bad extent overflows - start %" PRIu64 ", "
>>  					irec.br_startoff);
>>  				goto done;
>>  		}
>> -		if (irec.br_startoff >= fs_max_file_offset)  {
>> +		/* Ensure this extent does not extend beyond the max offset */
>> +		if (irec.br_startoff + irec.br_blockcount - 1 >
>> +							fs_max_file_offset) {
>>  			do_warn(
>>  _("inode %" PRIu64 " - extent offset too large - start %" PRIu64 ", "
>>    "count %" PRIu64 ", offset %" PRIu64 "\n"),
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs