From: Lars-Peter Clausen <lars@metafoo.de>
To: Karol Wrona <k.wrona@samsung.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Karol Wrona <wrona.vy@gmail.com>
Subject: Re: [RFC PATCH 2/2] iio: kfifo: Add resource management devm_iio_kfifo_allocate/free
Date: Thu, 18 Dec 2014 17:46:44 +0100 [thread overview]
Message-ID: <549304F4.5070105@metafoo.de> (raw)
In-Reply-To: <1418153385-18212-3-git-send-email-k.wrona@samsung.com>
On 12/09/2014 08:29 PM, Karol Wrona wrote:
> iio kfifo allocate/free gained their devm_ wrappers.
>
> Change-Id: I10c19ccd7c01491caf088b3629137425ddccd29c
> Signed-off-by: Karol Wrona <k.wrona@samsung.com>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
Looks good to me.
[...]
> +struct iio_buffer *devm_iio_kfifo_allocate(struct device *dev)
> +{
> + struct iio_buffer **ptr, *r;
> +
> + ptr = devres_alloc(devm_iio_kfifo_release, sizeof *ptr, GFP_KERNEL);
But this should be sizeof(*ptr) to compliant with the Linux kernel coding style.
[...]
prev parent reply other threads:[~2014-12-18 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 19:29 [RFC PATCH 0/2] iio: kfifo: Add resource management alloc/free Karol Wrona
2014-12-09 19:29 ` [RFC PATCH 1/2] iio: kfifo: Remove unused argument in iio_kfifo_allocate Karol Wrona
2014-12-18 16:42 ` Lars-Peter Clausen
2014-12-09 19:29 ` [RFC PATCH 2/2] iio: kfifo: Add resource management devm_iio_kfifo_allocate/free Karol Wrona
2014-12-18 16:46 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549304F4.5070105@metafoo.de \
--to=lars@metafoo.de \
--cc=b.zolnierkie@samsung.com \
--cc=jic23@kernel.org \
--cc=k.wrona@samsung.com \
--cc=knaack.h@gmx.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wrona.vy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.