From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1pwC-0007rp-HD for qemu-devel@nongnu.org; Fri, 19 Dec 2014 00:17:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1pw6-0004yf-8y for qemu-devel@nongnu.org; Fri, 19 Dec 2014 00:17:16 -0500 Received: from [59.151.112.132] (port=4033 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1pw5-0004yP-T5 for qemu-devel@nongnu.org; Fri, 19 Dec 2014 00:17:10 -0500 Message-ID: <5493B112.9000002@cn.fujitsu.com> Date: Fri, 19 Dec 2014 13:01:06 +0800 From: Gu Zheng MIME-Version: 1.0 References: <1418370238-24386-1-git-send-email-guz.fnst@cn.fujitsu.com> In-Reply-To: <1418370238-24386-1-git-send-email-guz.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 0/6] cpu: add device_add foo-x86_64-cpu support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: imammedo@redhat.com Cc: zhugh.fnst@cn.fujitsu.com, qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, anshul.makkar@profitbricks.com, afaerber@suse.de ping... On 12/12/2014 03:43 PM, Gu Zheng wrote: > This series is based on the previous patchset from Chen Fan: > https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html >=20 > We try to make cpu hotplug with device_add, and make > "-device foo-x86_64-cpu" available=EF=BC=8Calso we can set apic-id > property with command line, if without setting apic-id property, > we offer the first unoccupied apic id as the default new apic id. > When hotplug cpu with device_add, additional check of APIC ID will be > done after cpu object initialization which was different from > 'cpu_add' command that check 'ids' at the beginning. >=20 > The is the first half of the previous series: > [RFC V2 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove= support > https://lists.nongnu.org/archive/html/qemu-devel/2014-08/msg04779.html >=20 > --- > Changelog since v1: > -rebased on latest upstream. > -introduce a help function to hide the access to icc_bus. > -use a macro ACPI_ID_NOT_SET to replace the magic number(0xFFFFFFFF). >=20 > Changelog since RFC: > -split out APIC vmstate/QMP-monitor changes into separate patches. > -add the handle of the startup cpus(-device foo). > -remove duplicated checking about env->cpuid_apic_id. > -do actual APIC ID allocation at realize time if it is not set before. > -remove the unneeded x86_cpu_cpudef_instance_init(). > -split off device_del support out here. > --- >=20 > Chen Fan (2): > cpu: introduce CpuTopoInfo structure for argument simplification > cpu: add device_add foo-x86_64-cpu support >=20 > Gu Zheng (4): > qom/cpu: move register_vmstate to common CPUClass.realizefn > qom/cpu: move apic vmstate register into x86_cpu_apic_realize > monitor: use cc->get_arch_id as the cpu index > acpi:cpu hotplug: set pcmachine as icc bus' hotplug handler >=20 > cpus.c | 4 ++- > exec.c | 32 +++++++++++++--------- > hw/acpi/cpu_hotplug.c | 7 +++- > hw/cpu/icc_bus.c | 5 +++ > hw/i386/pc.c | 6 ---- > hw/i386/pc_piix.c | 5 +++ > hw/i386/pc_q35.c | 5 +++ > hw/intc/apic_common.c | 3 +- > include/hw/cpu/icc_bus.h | 2 + > include/hw/i386/apic_internal.h | 3 ++ > include/qom/cpu.h | 2 + > monitor.c | 4 ++- > qom/cpu.c | 2 + > target-i386/cpu.c | 55 +++++++++++++++++++++++++++++++++= +++--- > target-i386/topology.h | 51 ++++++++++++++++++++++++---------= -- > 15 files changed, 141 insertions(+), 45 deletions(-) >=20