From: Arend van Spriel <arend@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Gautam Kumar Shukla <gautams@broadcom.com>
Subject: Re: [RFC V2] cfg80211: Add feature flag for 4-way handshake offload
Date: Fri, 19 Dec 2014 10:59:01 +0100 [thread overview]
Message-ID: <5493F6E5.5060907@broadcom.com> (raw)
In-Reply-To: <5493F34A.4040500@broadcom.com>
On 12/19/14 10:43, Arend van Spriel wrote:
> On 12/19/14 10:18, Johannes Berg wrote:
>> On Thu, 2014-12-18 at 21:42 +0100, Arend van Spriel wrote:
>>
>>> + u8 ext_features[(NUM_NL80211_EXT_FEATURES / 8) + 1];
>>
>> Should probably use DIV_ROUND_UP() here.
>
> Will do.
Looking at this again I wonder if it would be of value to have this as
NL80211_EXT_FEATURES_ATTR_LEN in nl80211.h so user-space can check the
nla_len() against it and detect API in-compatibility. Just can not use
DIV_ROUND_UP() in that case. What's your opinion?
Regards,
Arend
next prev parent reply other threads:[~2014-12-19 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 20:42 [RFC V2] cfg80211: Add feature flag for 4-way handshake offload Arend van Spriel
2014-12-19 9:18 ` Johannes Berg
2014-12-19 9:43 ` Arend van Spriel
2014-12-19 9:59 ` Arend van Spriel [this message]
2014-12-19 10:05 ` Johannes Berg
2014-12-19 10:15 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5493F6E5.5060907@broadcom.com \
--to=arend@broadcom.com \
--cc=gautams@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.