From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCHv2 2/3] hdmi: added unpack and logging functions for InfoFrames Date: Fri, 19 Dec 2014 13:09:40 +0100 Message-ID: <54941584.90801@xs4all.nl> References: <1417522126-31771-1-git-send-email-hverkuil@xs4all.nl> <1417522126-31771-3-git-send-email-hverkuil@xs4all.nl> <20141218081927.GA29856@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lb3-smtp-cloud6.xs4all.net (lb3-smtp-cloud6.xs4all.net [194.109.24.31]) by gabe.freedesktop.org (Postfix) with ESMTP id 46E0C89ED3 for ; Fri, 19 Dec 2014 04:09:46 -0800 (PST) In-Reply-To: <20141218081927.GA29856@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: marbugge@cisco.com, Hans Verkuil , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgVGhpZXJyeSwKCk9uIDEyLzE4LzIwMTQgMDk6MTkgQU0sIFRoaWVycnkgUmVkaW5nIHdyb3Rl Ogo+PiArc3RhdGljIGludCBoZG1pX2F2aV9pbmZvZnJhbWVfdW5wYWNrKHN0cnVjdCBoZG1pX2F2 aV9pbmZvZnJhbWUgKmZyYW1lLAo+PiArCQkJCSAgICAgdm9pZCAqYnVmZmVyKQo+PiArewo+PiAr CXU4ICpwdHIgPSBidWZmZXI7Cj4+ICsJaW50IHJldDsKPj4gKwo+PiArCWlmIChwdHJbMF0gIT0g SERNSV9JTkZPRlJBTUVfVFlQRV9BVkkgfHwKPj4gKwkgICAgcHRyWzFdICE9IDIgfHwKPj4gKwkg ICAgcHRyWzJdICE9IEhETUlfQVZJX0lORk9GUkFNRV9TSVpFKQo+PiArCQlyZXR1cm4gLUVJTlZB TDsKPj4gKwo+PiArCWlmIChoZG1pX2luZm9mcmFtZV9jaGVja3N1bShidWZmZXIsIEhETUlfSU5G T0ZSQU1FX1NJWkUoQVZJKSkgIT0gMCkKPiAKPiBZb3UgdXNlIHRoZSBwYXJhbWV0ZXJpemVkIEhE TUlfSU5GT0ZSQU1FX1NJWkUoKSBoZXJlLCBidXQgdGhlIHBsYWluCj4gbWFjcm8gYWJvdmUuIFBl cmhhcHMgbWFrZSB0aG9zZSBjb25zaXN0ZW50PwoKSSdtIG5vdCBzdXJlIHdoYXQgeW91IG1lYW4g aGVyZSBzaW5jZSBIRE1JX0FWSV9JTkZPRlJBTUVfU0laRSAhPSBIRE1JX0lORk9GUkFNRV9TSVpF KEFWSSkuClRoZSBsYXR0ZXIgaW5jbHVkZXMgdGhlIGluZm9mcmFtZSBoZWFkZXIgc2l6ZS4KCkkn bSBhc3N1bWluZyB5b3UgbWlzc2VkIHRoYXQuIElmIG5vdCwgdGhlbiBwbGVhc2UgY2xhcmlmeS4K ClJlZ2FyZHMsCgoJSGFucwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb1-smtp-cloud6.xs4all.net ([194.109.24.24]:60035 "EHLO lb1-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751871AbaLSMJp (ORCPT ); Fri, 19 Dec 2014 07:09:45 -0500 Message-ID: <54941584.90801@xs4all.nl> Date: Fri, 19 Dec 2014 13:09:40 +0100 From: Hans Verkuil MIME-Version: 1.0 To: Thierry Reding CC: linux-media@vger.kernel.org, marbugge@cisco.com, dri-devel@lists.freedesktop.org, Hans Verkuil Subject: Re: [PATCHv2 2/3] hdmi: added unpack and logging functions for InfoFrames References: <1417522126-31771-1-git-send-email-hverkuil@xs4all.nl> <1417522126-31771-3-git-send-email-hverkuil@xs4all.nl> <20141218081927.GA29856@ulmo> In-Reply-To: <20141218081927.GA29856@ulmo> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Thierry, On 12/18/2014 09:19 AM, Thierry Reding wrote: >> +static int hdmi_avi_infoframe_unpack(struct hdmi_avi_infoframe *frame, >> + void *buffer) >> +{ >> + u8 *ptr = buffer; >> + int ret; >> + >> + if (ptr[0] != HDMI_INFOFRAME_TYPE_AVI || >> + ptr[1] != 2 || >> + ptr[2] != HDMI_AVI_INFOFRAME_SIZE) >> + return -EINVAL; >> + >> + if (hdmi_infoframe_checksum(buffer, HDMI_INFOFRAME_SIZE(AVI)) != 0) > > You use the parameterized HDMI_INFOFRAME_SIZE() here, but the plain > macro above. Perhaps make those consistent? I'm not sure what you mean here since HDMI_AVI_INFOFRAME_SIZE != HDMI_INFOFRAME_SIZE(AVI). The latter includes the infoframe header size. I'm assuming you missed that. If not, then please clarify. Regards, Hans