From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58745)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Y1zUX-0007Up-Lb
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 10:29:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Y1zUR-0002zy-He
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 10:29:21 -0500
Received: from resqmta-po-03v.sys.comcast.net ([96.114.154.162]:60417)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Y1zUR-0002zf-BX
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 10:29:15 -0500
Message-ID: <54944449.8060901@redhat.com>
Date: Fri, 19 Dec 2014 08:29:13 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1418645123-32256-1-git-send-email-royv@ezchip.com>
In-Reply-To: <1418645123-32256-1-git-send-email-royv@ezchip.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Roy Vardi <royv@ezchip.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, stefanha@redhat.com, aliguori@amazon.com, lcapitulino@redhat.com

On 12/15/2014 05:05 AM, Roy Vardi wrote:
> From: Roy Vardi <royv@ezchip.com>
> 
>     Add 'persistent' boolean flag to -net tap option.
>     When set to off - tap interface will be released on shutdown
>     When set to on\not specified - tap interface will remain
> 
>     Running with -net tap,persistent=off will force the tap interface
>     down when qemu goes down, thus ensuring that there're no zombie tap
>     interfaces left
> 
>     This is achieved using another ioctl
> 
>     Note: This commit includes the above support only for linux systems
> 
> Signed-off-by: Roy Vardi <royv@ezchip.com>
> ---

> +++ b/qapi-schema.json
> @@ -2007,6 +2007,8 @@
>  #
>  # @queues: #optional number of queues to be created for multiqueue capable tap
>  #
> +# @persistent: #optional for opening tap in persistent mode

Missing a '(since 2.3)' designator; also might be worth mentioning that
the default is true if omitted.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org