From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v3 04/32] drm/exynos: Use manager_op initialize in fimd
Date: Fri, 01 Nov 2013 20:57:08 +0100
Message-ID: <5496080.x5dJWoLJ7D@flatron>
References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org>
	<1821959.flD2ZDaB3W@flatron>
	<CAOw6vbKoD7=JQ_SVnvnVny4KKUrYbZ1=kh7LCaxvwfiCGr3row@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com
	[209.85.214.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 6B553F078D
	for <dri-devel@lists.freedesktop.org>;
	Fri,  1 Nov 2013 12:57:07 -0700 (PDT)
Received: by mail-bk0-f49.google.com with SMTP id w14so1924617bkz.22
	for <dri-devel@lists.freedesktop.org>;
	Fri, 01 Nov 2013 12:57:06 -0700 (PDT)
In-Reply-To: <CAOw6vbKoD7=JQ_SVnvnVny4KKUrYbZ1=kh7LCaxvwfiCGr3row@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel <dri-devel@lists.freedesktop.org>, =?ISO-8859-1?Q?St=E9phane?= Marchesin <marcheu@chromium.org>
List-Id: dri-devel@lists.freedesktop.org

On Friday 01 of November 2013 15:51:00 Sean Paul wrote:
> On Thu, Oct 31, 2013 at 7:49 PM, Tomasz Figa <tomasz.figa@gmail.com> 
wrote:
> > Hi Sean,
> > 
> > On Tuesday 29 of October 2013 12:12:50 Sean Paul wrote:
> >> This patch implements the intitialize manager op in fimd.
> >> 
> >> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> >> ---
> >> 
> >> Changes in v2: None
> >> Changes in v3: None
> >> 
> >>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 19 +++++++++++++++----
> >>  1 file changed, 15 insertions(+), 4 deletions(-)
> > 
> > [snip]
> > 
> >>  static void fimd_dpms(struct device *subdrv_dev, int mode)
> >>  {
> >>  
> >>       struct fimd_context *ctx = get_fimd_context(subdrv_dev);
> >> 
> >> @@ -660,6 +671,7 @@ static void fimd_wait_for_vblank(struct device
> >> *dev) }
> >> 
> >>  static struct exynos_drm_manager_ops fimd_manager_ops = {
> >> 
> >> +     .initialize = fimd_mgr_initialize,
> >> 
> >>       .dpms = fimd_dpms,
> >>       .apply = fimd_apply,
> >>       .commit = fimd_commit,
> >> 
> >> @@ -681,7 +693,6 @@ static irqreturn_t fimd_irq_handler(int irq, void
> >> *dev_id) {
> >> 
> >>       struct fimd_context *ctx = (struct fimd_context *)dev_id;
> >>       struct exynos_drm_subdrv *subdrv = &ctx->subdrv;
> >> 
> >> -     struct drm_device *drm_dev = subdrv->drm_dev;
> > 
> > Apparently the driver already can have a reference to drm_device,
> > without the .initialize() method being called.
> > 
> > I guess your change makes it somehow better, but patch description
> > fails to explain this.
> 
> I've updated the patch description. This change is needed to remove
> all subdrv references from fimd so we can just implement manager.

Fair enough. Thanks.

Best regards,
Tomasz