From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init Date: Sun, 21 Dec 2014 13:12:47 +0200 Message-ID: <5496AB2F.9050804@amd.com> References: <1419108374-7020-1-git-send-email-oded.gabbay@amd.com> <1419108374-7020-2-git-send-email-oded.gabbay@amd.com> <20141220212515.GA30589@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0121.outbound.protection.outlook.com [207.46.100.121]) by gabe.freedesktop.org (Postfix) with ESMTP id 455D56E23E for ; Sun, 21 Dec 2014 03:13:10 -0800 (PST) In-Reply-To: <20141220212515.GA30589@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Greg KH Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alexander.Deucher@amd.com List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMi8yMC8yMDE0IDExOjI1IFBNLCBHcmVnIEtIIHdyb3RlOgo+IE9uIFNhdCwgRGVjIDIw LCAyMDE0IGF0IDEwOjQ2OjEyUE0gKzAyMDAsIE9kZWQgR2FiYmF5IHdyb3RlOgo+PiBXaGVuIGFt ZGtmZCBhbmQgcmFkZW9uIGFyZSBjb21waWxlZCBpbnNpZGUgdGhlIGtlcm5lbCBpbWFnZSAobm90 IGFzIG1vZHVsZXMpLAo+PiByYWRlb24gd2lsbCBsb2FkIGJlZm9yZSBhbWRrZmQgYW5kIHdpbGwg c2V0ICprZmQya2dkIHRvIGl0cyBpbnRlcmZhY2UKPj4gc3RydWN0dXJlLiBUaGVyZWZvcmUsIHdl IG11c3Qgbm90IHNldCAqa2ZkMmtnZCB0byBOVUxMIHdoZW4gYW1ka2ZkIGlzIGxvYWRlZAo+PiBi ZWNhdXNlIGl0IHdpbGwgb3ZlcnJpZGUgcmFkZW9uJ3MgaW5pdGlhbGl6YXRpb24gYW5kIGNhdXNl IGtlcm5lbCBCVUcuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE9kZWQgR2FiYmF5IDxvZGVkLmdhYmJh eUBhbWQuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfbW9k dWxlLmMgfCA1ICsrLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2Zk L2tmZF9tb2R1bGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9tb2R1bGUuYwo+ PiBpbmRleCA5NWQ1YWYxLi4yMzY1NjJmIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v YW1kL2FtZGtmZC9rZmRfbW9kdWxlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRr ZmQva2ZkX21vZHVsZS5jCj4+IEBAIC0zNCw3ICszNCw3IEBACj4+ICAgI2RlZmluZSBLRkRfRFJJ VkVSX01JTk9SCTcKPj4gICAjZGVmaW5lIEtGRF9EUklWRVJfUEFUQ0hMRVZFTAkwCj4+Cj4+IC1j b25zdCBzdHJ1Y3Qga2ZkMmtnZF9jYWxscyAqa2ZkMmtnZDsKPj4gK2NvbnN0IHN0cnVjdCBrZmQy a2dkX2NhbGxzICprZmQya2dkID0gTlVMTDsKPgo+IFRoaXMgY2hhbmdlIGRvZXMgbm90aGluZywg dGhhdCBpcyB3aGF0IHRoZSBvcmlnaW5hbCBjb2RlIGRpZCBhbHJlYWR5Lgo+Cj4gdGhhbmtzLAo+ Cj4gZ3JlZyBrLWgKWWVhaC4gU29ycnksIEkgd2lsbCByZW1vdmUgaXQuCgkKCU9kZWQKPiAtLQo+ IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmli ZSBsaW51eC1rZXJuZWwiIGluCj4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2 Z2VyLmtlcm5lbC5vcmcKPiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJu ZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwKPiBQbGVhc2UgcmVhZCB0aGUgRkFRIGF0ICBodHRw Oi8vd3d3LnR1eC5vcmcvbGttbC8KPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbaLULNT (ORCPT ); Sun, 21 Dec 2014 06:13:19 -0500 Received: from mail-by2on0147.outbound.protection.outlook.com ([207.46.100.147]:7206 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751204AbaLULNP (ORCPT ); Sun, 21 Dec 2014 06:13:15 -0500 X-WSS-ID: 0NGXJ5S-07-8T4-02 X-M-MSG: Message-ID: <5496AB2F.9050804@amd.com> Date: Sun, 21 Dec 2014 13:12:47 +0200 From: Oded Gabbay Organization: AMD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Greg KH CC: , David Airlie , Jerome Glisse , Joerg Roedel , , John Bridgman , Subject: Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init References: <1419108374-7020-1-git-send-email-oded.gabbay@amd.com> <1419108374-7020-2-git-send-email-oded.gabbay@amd.com> <20141220212515.GA30589@kroah.com> In-Reply-To: <20141220212515.GA30589@kroah.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.0.84] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Oded.Gabbay@amd.com; X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(51704005)(24454002)(377454003)(479174004)(189002)(199003)(46102003)(65816999)(101416001)(97736003)(21056001)(99396003)(76176999)(50986999)(59896002)(54356999)(77156002)(62966003)(50466002)(120916001)(87936001)(20776003)(64706001)(33656002)(2950100001)(4396001)(83506001)(65956001)(65806001)(15975445007)(68736005)(77096005)(64126003)(84676001)(31966008)(19580405001)(47776003)(80316001)(106466001)(105586002)(107046002)(23746002)(92566001)(110136001)(19580395003)(36756003)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB197;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB197; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:BN1PR02MB197; X-Forefront-PRVS: 0432A04947 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB197; X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2014 11:13:06.4927 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB197 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/20/2014 11:25 PM, Greg KH wrote: > On Sat, Dec 20, 2014 at 10:46:12PM +0200, Oded Gabbay wrote: >> When amdkfd and radeon are compiled inside the kernel image (not as modules), >> radeon will load before amdkfd and will set *kfd2kgd to its interface >> structure. Therefore, we must not set *kfd2kgd to NULL when amdkfd is loaded >> because it will override radeon's initialization and cause kernel BUG. >> >> Signed-off-by: Oded Gabbay >> --- >> drivers/gpu/drm/amd/amdkfd/kfd_module.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_module.c b/drivers/gpu/drm/amd/amdkfd/kfd_module.c >> index 95d5af1..236562f 100644 >> --- a/drivers/gpu/drm/amd/amdkfd/kfd_module.c >> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_module.c >> @@ -34,7 +34,7 @@ >> #define KFD_DRIVER_MINOR 7 >> #define KFD_DRIVER_PATCHLEVEL 0 >> >> -const struct kfd2kgd_calls *kfd2kgd; >> +const struct kfd2kgd_calls *kfd2kgd = NULL; > > This change does nothing, that is what the original code did already. > > thanks, > > greg k-h Yeah. Sorry, I will remove it. Oded > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >