From: Malcolm Priestley <tvboxspy@gmail.com>
To: Mike Krinkin <krinkin.m.u@gmail.com>,
gregkh@linuxfoundation.org, forest@alittletooquiet.net,
gclement@baobob.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: fix sparse warnings: incorrect argument type
Date: Sun, 21 Dec 2014 14:59:12 +0000 [thread overview]
Message-ID: <5496E040.5060408@gmail.com> (raw)
In-Reply-To: <1419170207-2585-1-git-send-email-krinkin.m.u@gmail.com>
On 21/12/14 13:56, Mike Krinkin wrote:
> this patch fixes following sparse warnings:
>
> drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *
> drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
> drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *
Good catch
also needed for 3.19
Thanks
Malcolm
>
> Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
> ---
> drivers/staging/vt6655/device_main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index 83e4162..ce616f9 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1500,9 +1500,11 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
> if (conf->enable_beacon) {
> vnt_beacon_enable(priv, vif, conf);
>
> - MACvRegBitsOn(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
> + MACvRegBitsOn(priv->PortOffset, MAC_REG_TCR,
> + TCR_AUTOBCNTX);
> } else {
> - MACvRegBitsOff(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
> + MACvRegBitsOff(priv->PortOffset, MAC_REG_TCR,
> + TCR_AUTOBCNTX);
> }
> }
>
>
prev parent reply other threads:[~2014-12-21 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 13:56 [PATCH] staging: vt6655: fix sparse warnings: incorrect argument type Mike Krinkin
2014-12-21 14:59 ` Malcolm Priestley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5496E040.5060408@gmail.com \
--to=tvboxspy@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gclement@baobob.org \
--cc=gregkh@linuxfoundation.org \
--cc=krinkin.m.u@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.