From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by kanga.kvack.org (Postfix) with ESMTP id 9E8D06B0032 for ; Sun, 21 Dec 2014 13:02:53 -0500 (EST) Received: by mail-pa0-f51.google.com with SMTP id ey11so4466660pad.38 for ; Sun, 21 Dec 2014 10:02:53 -0800 (PST) Received: from mga09.intel.com (mga09.intel.com. [134.134.136.24]) by mx.google.com with ESMTP id qd7si22336176pbb.22.2014.12.21.10.02.51 for ; Sun, 21 Dec 2014 10:02:52 -0800 (PST) Message-ID: <54970B49.3070104@linux.intel.com> Date: Sun, 21 Dec 2014 10:02:49 -0800 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps References: <20141220183613.GA19229@phnom.home.cmpxchg.org> <20141220194457.GA3166@x61.redhat.com> In-Reply-To: <20141220194457.GA3166@x61.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Rafael Aquini , Johannes Weiner Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, oleg@redhat.com, rientjes@google.com, linux-mm@kvack.org On 12/20/2014 11:44 AM, Rafael Aquini wrote: >> > >> > It would be simpler to include this unconditionally. Otherwise you >> > are forcing everybody parsing the file and trying to run calculations >> > of it to check for its presence, and then have them fall back and get >> > the value from somewhere else if not. > I'm fine either way, it makes the change even simpler. Also, if we > decide to get rid of page_size != PAGE_SIZE condition I believe we can > also get rid of that "huge" hint being conditionally printed out too. That would break existing users of the "huge" flag. That makes it out of the question, right? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181AbaLUSCw (ORCPT ); Sun, 21 Dec 2014 13:02:52 -0500 Received: from mga01.intel.com ([192.55.52.88]:63354 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbaLUSCv (ORCPT ); Sun, 21 Dec 2014 13:02:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="502305545" Message-ID: <54970B49.3070104@linux.intel.com> Date: Sun, 21 Dec 2014 10:02:49 -0800 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Rafael Aquini , Johannes Weiner CC: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, oleg@redhat.com, rientjes@google.com, linux-mm@kvack.org Subject: Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps References: <20141220183613.GA19229@phnom.home.cmpxchg.org> <20141220194457.GA3166@x61.redhat.com> In-Reply-To: <20141220194457.GA3166@x61.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/20/2014 11:44 AM, Rafael Aquini wrote: >> > >> > It would be simpler to include this unconditionally. Otherwise you >> > are forcing everybody parsing the file and trying to run calculations >> > of it to check for its presence, and then have them fall back and get >> > the value from somewhere else if not. > I'm fine either way, it makes the change even simpler. Also, if we > decide to get rid of page_size != PAGE_SIZE condition I believe we can > also get rid of that "huge" hint being conditionally printed out too. That would break existing users of the "huge" flag. That makes it out of the question, right?