From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH RFC 2/2] package/perl-gd: Add a new option to set the path to gdlib-config
Date: Sun, 21 Dec 2014 22:24:31 +0100 [thread overview]
Message-ID: <54973A8F.3080100@openwide.fr> (raw)
In-Reply-To: <20141221132027.0d69abf8@free-electrons.com>
Hi Thomas,
Le 21/12/2014 13:20, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Sun, 21 Dec 2014 00:51:00 +0100, Romain Naour wrote:
>> The build of perl-gd use the gdlib-config from the host that in result
>> incorect features enabled, incorrect header and library paths.
>>
>> Should fixes:
>> http://autobuild.buildroot.net/results/15c/15ce69b916167305aba2820a157c880e487ee8c7/
>> http://autobuild.buildroot.net/results/504/504d64d992eb504e02c127feb4734a917ad95d0a/
>> http://autobuild.buildroot.net/results/551/5512213c8861e51b390c1c223d53add0ec1ed758/
>>
>> And many more.
>>
>> Note:
>> In the generated Makefile, LDFLAGS still contains "-L/usr/local/lib"
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> .../0004-gdlib-config-is-now-configurable.patch | 67 ++++++++++++++++++++++
>> package/perl-gd/perl-gd.mk | 3 +-
>> 2 files changed, 69 insertions(+), 1 deletion(-)
>> create mode 100644 package/perl-gd/0004-gdlib-config-is-now-configurable.patch
> We have another patch from Fran?ois for the same issue, at
> http://patchwork.ozlabs.org/patch/415924/. However, Peter raised some
> concerns about Fran?ois approach, and your patch indeed seems better.
>
> Fran?ois, can you comment/review Romain's patch? See
> http://patchwork.ozlabs.org/patch/423143/.
>
> Romain, any chance you can submit your patch upstream?
>
I'll do.
perl-gd upstream has added a new Build.PL file that has the same issues for cross-compiling. Also, Fran?ois's patches haven't been merged yet.
Best regards,
Romain Naour
next prev parent reply other threads:[~2014-12-21 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 23:50 [Buildroot] [PATCH 1/2] package/perl-gd: rename patches to follow the new name convention Romain Naour
2014-12-20 23:51 ` [Buildroot] [PATCH RFC 2/2] package/perl-gd: Add a new option to set the path to gdlib-config Romain Naour
2014-12-21 12:20 ` Thomas Petazzoni
2014-12-21 21:24 ` Romain Naour [this message]
2014-12-24 8:54 ` François Perrad
2014-12-24 11:12 ` Thomas Petazzoni
2014-12-21 12:18 ` [Buildroot] [PATCH 1/2] package/perl-gd: rename patches to follow the new name convention Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54973A8F.3080100@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.