From: Jaehoon Chung <jh80.chung@samsung.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, Chris Ball <chris@printf.net>
Subject: Re: [PATCH 4/6] mmc: sdhci-s3c: Handle error from mmc_of_parse()
Date: Mon, 22 Dec 2014 13:23:29 +0900 [thread overview]
Message-ID: <54979CC1.2040107@samsung.com> (raw)
In-Reply-To: <1418895704-25908-5-git-send-email-ulf.hansson@linaro.org>
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
On 12/18/2014 06:41 PM, Ulf Hansson wrote:
> Since mmc_of_parse() may fail, let's deal with it and thus do proper
> error handling.
>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/mmc/host/sdhci-s3c.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index c45b893..a282822 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -607,7 +607,9 @@ static int sdhci_s3c_probe(struct platform_device *pdev)
> pm_runtime_use_autosuspend(&pdev->dev);
> pm_suspend_ignore_children(&pdev->dev, 1);
>
> - mmc_of_parse(host->mmc);
> + ret = mmc_of_parse(host->mmc);
> + if (ret)
> + goto err_req_regs;
>
> ret = sdhci_add_host(host);
> if (ret) {
>
next prev parent reply other threads:[~2014-12-22 4:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 9:41 [PATCH 0/6] mmc: Fix error handling for mmc_of_parse() Ulf Hansson
2014-12-18 9:41 ` [PATCH 1/6] mmc: moxart: Handle error from mmc_of_parse() Ulf Hansson
2014-12-18 9:41 ` [PATCH 2/6] mmc: sdhci-bcm-kona: " Ulf Hansson
2014-12-21 9:43 ` Florian Fainelli
2014-12-18 9:41 ` [PATCH 3/6] mmc: sdhci-of-esdhc: " Ulf Hansson
2014-12-18 9:41 ` [PATCH 4/6] mmc: sdhci-s3c: " Ulf Hansson
2014-12-22 4:23 ` Jaehoon Chung [this message]
2014-12-18 9:41 ` [PATCH 5/6] mmc: sdhci-st: Do cleanup while mmc_of_parse() return an error Ulf Hansson
2014-12-18 9:44 ` Maxime Coquelin
2014-12-18 9:41 ` [PATCH 6/6] mmc: core: Return error at failure of request CD/WP in mmc_of_parse() Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54979CC1.2040107@samsung.com \
--to=jh80.chung@samsung.com \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.