From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhhy.zhanghaoyu@gmail.com>) id 1Y2xIA-0000mE-LD
	for qemu-devel@nongnu.org; Mon, 22 Dec 2014 02:20:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhhy.zhanghaoyu@gmail.com>) id 1Y2xI5-0007Bq-7I
	for qemu-devel@nongnu.org; Mon, 22 Dec 2014 02:20:34 -0500
Received: from mail-pa0-x244.google.com ([2607:f8b0:400e:c03::244]:34734)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhhy.zhanghaoyu@gmail.com>) id 1Y2xI4-0007Bh-TM
	for qemu-devel@nongnu.org; Mon, 22 Dec 2014 02:20:29 -0500
Received: by mail-pa0-f68.google.com with SMTP id kq14so4106938pab.11
	for <qemu-devel@nongnu.org>; Sun, 21 Dec 2014 23:20:28 -0800 (PST)
Message-ID: <5497C62C.4060902@gmail.com>
Date: Mon, 22 Dec 2014 15:20:12 +0800
From: Zhang Haoyu <zhhy.zhanghaoyu@gmail.com>
MIME-Version: 1.0
References: <1419231973-11648-1-git-send-email-zhang.zhangkun@huawei.com>
In-Reply-To: <1419231973-11648-1-git-send-email-zhang.zhangkun@huawei.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] support vhost-user socket to reconnect
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zhangkun <zhang.zhangkun@huawei.com>, qemu-devel@nongnu.org

Hi, Kun

Is this patch one of patch series?
I don't see any place to reference "is_reconnect" field.

On 2014/12/22 15:06, zhangkun wrote:
> From: zhangkun <zhang.zhangkun@huawei.com>
> 
> Signed-off-by: zhangkun <zhang.zhangkun@huawei.com>
> ---
>  net/vhost-user.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/net/vhost-user.c b/net/vhost-user.c
> index 24e050c..957e78c 100644
> --- a/net/vhost-user.c
> +++ b/net/vhost-user.c
> @@ -26,6 +26,7 @@ typedef struct VhostUserChardevProps {
>      bool is_socket;
>      bool is_unix;
>      bool is_server;
> +    bool is_reconnect;
>  } VhostUserChardevProps;
>  
>  VHostNetState *vhost_user_get_vhost_net(NetClientState *nc)
> @@ -132,6 +133,11 @@ static void net_vhost_user_event(void *opaque, int event)
>      }
>  }
>  
> +static bool net_vhost_user_can_read(void *opaque)
> +{
> +    return true;
> +} 
> +
>  static int net_vhost_user_init(NetClientState *peer, const char *device,
>                                 const char *name, CharDriverState *chr,
>                                 bool vhostforce)
> @@ -151,7 +157,7 @@ static int net_vhost_user_init(NetClientState *peer, const char *device,
>      s->chr = chr;
>      s->vhostforce = vhostforce;
>  
> -    qemu_chr_add_handlers(s->chr, NULL, NULL, net_vhost_user_event, s);
> +    qemu_chr_add_handlers(s->chr, net_vhost_user_can_read, NULL, net_vhost_user_event, s);
>  
Why no read handler?

>      return 0;
>  }
> @@ -167,6 +173,8 @@ static int net_vhost_chardev_opts(const char *name, const char *value,
>          props->is_unix = true;
>      } else if (strcmp(name, "server") == 0) {
>          props->is_server = true;
> +    } else if (strcmp(name, "reconnect") == 0) {
> +        props->is_reconnect = true;
>      } else {
>          error_report("vhost-user does not support a chardev"
>                       " with the following option:\n %s = %s",
>