All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aron Szabo <aron@ubit.hu>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: fix the wrong directory passed to ocfs2_lookup_ino_from_name() when link file
Date: Mon, 22 Dec 2014 09:52:14 +0100	[thread overview]
Message-ID: <5497DBBE.7060700@ubit.hu> (raw)
In-Reply-To: <20141219141513.d68d5737c625c1b188004c89@linux-foundation.org>

Hi Andew!

Hard linking works again, when paths are relative with at least one 
subdirectory. This is how the problem was reproducable:

# mkdir a
# mkdir b
# touch a/test
# ln a/test b/test
ln: failed to create hard link `b/test' => `a/test': No such file or 
directory

However when creating links in the same dir, it worked well.

Now the link gets created.

Thanks for the quick fix Xue!

Yours,
Aron

12/19/2014 11:15 PM keltez?ssel, Andrew Morton ?rta:
> On Fri, 19 Dec 2014 18:07:45 +0800 Xue jiufei <xuejiufei@huawei.com> wrote:
>
>> In function ocfs2_link(), parent directory inode passed to function
>> ocfs2_lookup_ino_from_name() is wrong. Parameter dir is the parent
>> of new_dentry not old_dentry. We should get old_dir from old_dentry
>> and lookup old_dentry in old_dir in case another node remove the old dentry.
> What are the user-visible effects of this change?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20141222/0cf52b56/attachment.html 

  reply	other threads:[~2014-12-22  8:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 10:07 [Ocfs2-devel] [PATCH] ocfs2: fix the wrong directory passed to ocfs2_lookup_ino_from_name() when link file Xue jiufei
2014-12-19 22:15 ` Andrew Morton
2014-12-22  8:52   ` Aron Szabo [this message]
2015-01-05 22:16     ` Andrew Morton
2015-01-06  1:07       ` Joseph Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5497DBBE.7060700@ubit.hu \
    --to=aron@ubit.hu \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.