From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init Date: Mon, 22 Dec 2014 11:26:47 +0200 Message-ID: <5497E3D7.1060405@amd.com> References: <1419108374-7020-1-git-send-email-oded.gabbay@amd.com> <1419108374-7020-2-git-send-email-oded.gabbay@amd.com> <5496AEAD.3090003@vodafone.de> <5496B04C.50502@amd.com> <5496BAE0.5090901@vodafone.de> <5496C5EA.7050200@amd.com> <5496CA0F.8000800@amd.com> <5496EDF1.7080106@vodafone.de> <5496EF34.70302@amd.com> <5496F0DD.40903@vodafone.de> <5497C98C.2080208@amd.com> <5497CB91.2080306@amd.com> <5497DD0E.7040400@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0126.outbound.protection.outlook.com [65.55.169.126]) by gabe.freedesktop.org (Postfix) with ESMTP id 1006B6E0C2 for ; Mon, 22 Dec 2014 01:27:09 -0800 (PST) In-Reply-To: <5497DD0E.7040400@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Dave Airlie Cc: "Deucher, Alexander" , "Elifaz, Dana" , LKML , dri-devel List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMi8yMi8yMDE0IDEwOjU3IEFNLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+IEFtIDIy LjEyLjIwMTQgdW0gMDg6NDMgc2NocmllYiBPZGVkIEdhYmJheToKPj4KPj4KPj4gT24gMTIvMjIv MjAxNCAwOTo0MCBBTSwgRGF2ZSBBaXJsaWUgd3JvdGU6Cj4+Pj4+Pj4+IFRoZXJlIHNob3VsZCBi ZSwgYnV0IHdoZW4gdGhlIG1vZHVsZXMgYXJlIGNvbXBpbGVkIGluLCB0aGV5IGFyZSBsb2FkZWQK Pj4+Pj4+Pj4gYmFzZWQgb24KPj4+Pj4+Pj4gbGluayBvcmRlciBvbmx5LCBpZiB0aGV5IGFyZSBp biB0aGUgc2FtZSBncm91cCwgYW5kIHRoZSBncm91cHMgYXJlCj4+Pj4+Pj4+IGxvYWRlZCBieSBh Cj4+Pj4+Pj4+IHByZS1kZWZpbmVkIG9yZGVyLgo+Pj4+Pj4+Cj4+Pj4+Pj4gSXMgdGhhdCByZWFs bHkgc3RpbGwgdXAgdG8gZGF0ZT8gSSd2ZSBzZWVuIGVmZm9ydCB0byBjaGFuZ2UgdGhhdAo+Pj4+ Pj4+IHNvbWV0aGluZyBsaWtlCj4+Pj4+Pj4gMTArIHllYXJzIGFnbyB3aGVuIFJ1c3R5IHJld29y a2VkIHRoZSBtb2R1bGUgc3lzdGVtLiBBbmQgaXQgaXMgY29tbWluZwo+Pj4+Pj4+IHVwIG9uIHRo ZQo+Pj4+Pj4+IGxpc3RzIGFnYWluIGZyb20gdGltZSB0byB0aW1lLgo+Pj4+Pj4KPj4+Pj4+ICBG cm9tIHdoYXQgSSBjYW4gc2VlIGluIHRoZSBNYWtlZmlsZSBydWxlcywgY29kZSBhbmQgZ29vZ2xl LCB5ZXMsIHRoYXQncwo+Pj4+Pj4gc3RpbGwKPj4+Pj4+IHRoZSBzaXR1YXRpb24uIElmIHNvbWVv bmUgd2lsbCBwcm92ZSBtZSB3cm9uZyBJIHdpbGwgYmUgbW9yZSB0aGFuIGhhcHB5Cj4+Pj4+PiB0 bwo+Pj4+Pj4gY29ycmVjdCBteSBjb2RlLgo+Pj4+Pj4+Cj4+Pj4+Pj4KPj4+Pj4+Pj4gSSBkb24n dCB3YW50IHRvIG1vdmUgaW9tbXUgYmVmb3JlIGdwdSwgc28gSSBkb24ndCBoYXZlIGEgc29sdXRp b24gZm9yCj4+Pj4+Pj4+IHRoZQo+Pj4+Pj4+PiBvcmRlciBiZXR3ZWVuIGFtZGtmZCBhbmQgYW1k X2lvbW11X3YyLgo+Pj4+Pj4+Cj4+Pj4+Pj4gV2h5IG5vdD8gVGhhdCdzIHN0aWxsIGJldHRlciB0 aGFuIGNyZWF0aW5nIGEga2VybmVsIHdvcmtxdWV1ZSwKPj4+Pj4+PiBzY2hlZHVsaW5nIG9uZQo+ Pj4+Pj4+IHdvcmsgaXRlbSBvbiBpdCwgcmVzY2hlZHVsaW5nIHRoZSB0YXNrIHVudGlsIGV2ZXJ5 dGhpbmcgaXMgY29tcGxldGVkIGFuZAo+Pj4+Pj4+IHlvdSBjYW4KPj4+Pj4+PiBjb250aW51ZS4K Pj4+Pj4+Cj4+Pj4+PiBCZWNhdXNlIEkgZG9uJ3Qga25vdyB0aGUgY29uc2VxdWVuY2VzIG9mIG1v dmluZyBhbiBlbnRpcmUgc3Vic3lzdGVtIGluCj4+Pj4+PiBmcm9udAo+Pj4+Pj4gb2YgYW5vdGhl ciBvbmUuIEluIGFkZGl0aW9uLCBldmVuIGlmIGV2ZXJ5b25lIGFncmVlcywgSSdtIHByZXR0eSBz dXJlCj4+Pj4+PiB0aGF0Cj4+Pj4+PiBMaW51cyB3b24ndCBiZSBoYXBweSB0byBkbyB0aGF0IGlu IC1yYyBzdGFnZXMuIFNvIG1heWJlIHRoaXMgaXMgc29tZXRoaW5nCj4+Pj4+PiB0bwo+Pj4+Pj4g Y29uc2lkZXIgZm9yIDMuMjAgbWVyZ2Ugd2luZG93LCBidXQgSSB3b3VsZCBzdGlsbCBsaWtlIHRv IHByb3ZpZGUgYQo+Pj4+Pj4gc29sdXRpb24KPj4+Pj4+IGZvciAzLjE5Lgo+Pj4+Pgo+Pj4+Pgo+ Pj4+PiBZZWFoLCB0cnVlIGluZGVlZC4gSG93IGFib3V0IGRlcGVuZGluZyBvbiBldmVyeXRoaW5n IGJlaW5nIGNvbXBpbGVkIGFzCj4+Pj4+IG1vZHVsZQo+Pj4+PiBmb3IgMy4xOSB0aGVuPyBTdGls bCBiZXR0ZXIgdGhhbiBoYXZpbmcgc3VjaCBhIGhhY2sgaW4gdGhlIGRyaXZlciBmb3IgYXMgYQo+ Pj4+PiB0ZW1wb3Jhcnkgd29ya2Fyb3VuZCBmb3Igb25lIHJlbGVhc2UuCj4+Pj4+Cj4+Pj4gSSB0 aG91Z2h0IGFib3V0IGl0LCBidXQgYmVjYXVzZSB0aGlzIHByb2JsZW0gd2FzIG9yaWdpbmFsbHkg cmVwb3J0ZWQgYnkgYQo+Pj4+IHVzZXIgdGhhdCB0b2xkIHVzIGhlIGNvdWxkbid0IHVzZSBtb2R1 bGVzIGJlY2F1c2Ugb2YgaGlzIHNldHVwLCBJIGRlY2lkZWQKPj4+PiBub3QgdG8uCj4+Pj4gSSBh c3N1bWUgdGhlcmUgYXJlIG90aGVyIHVzZXJzIG91dCB0aGVyZSB3aG8gbmVlZHMgdGhpcyBvcHRp b24gKGNvbXBpbGVkCj4+Pj4gZXZlcnl0aGluZyBpbiB0aGUga2VybmVsIC0gZW1iZWRkZWQgPyks IHNvIEkgZG9uJ3Qgd2FudCB0byBtYWtlIHRoZWlyIGxpZmUKPj4+PiBoYXJkZXIuCj4+Pj4KPj4+ PiBJbiBhZGRpdGlvbiwgc2F5aW5nIGl0IGlzIGEgd29ya2Fyb3VuZCBmb3Igb25lIHJlbGVhc2Ug aXMgdHJ1ZSBpbiBjYXNlCj4+Pj4gbW92aW5nIGlvbW11IHN1YnN5c3RlbSBpbiBmcm9udCBvZiBn cHUgc3Vic3lzdGVtIGlzIGFjY2VwdGFibGUgYW5kIGRvZXNuJ3QKPj4+PiBjYXVzZSBvdGhlciBw cm9ibGVtcywgdW5rbm93biBhdCB0aGlzIHBvaW50Lgo+Pj4+Cj4+Pj4gQm90dG9tIGxpbmUsIG15 IHBlcnNvbmFsIHByZWZlcmVuY2UgaXMgdG8gaGVscCB0aGUgdXNlcnMgX25vd18gYW5kIGlmIGEK Pj4+PiBiZXR0ZXIgZml4IGlzIGZvdW5kIGluIHRoZSBmdXR1cmUsIGNoYW5nZSB0aGUgY29kZSBh Y2NvcmRpbmdseS4KPj4+Cj4+PiBNeSBndWVzcyBpcyBtb3ZpbmcgdGhlIGlvbW11IHN1YnN5c3Rl bSBpbiBmcm9udCBvZiB0aGUgR1BVIHdvdWxkIGJlIHJhdGlvbmFsLgo+Pj4KPj4+IEl0IGRvZXMg c2VlbSBsaWtlIGl0IHdvdWxkIGdlbmVyYWxseSBoYXZlIGEgZGVwZW5kIGluIHRoYXQgb3JkZXIu Cj4+Pgo+Pj4gRGF2ZS4KPj4+Cj4+IERhdmUsCj4+IEkgYWdyZWUsIGJ1dCBkb24ndCB5b3UgdGhp bmsgaXQgaXMgdG9vIHJpc2t5IGZvciAtcmMgc3RhZ2VzID8KPj4gSWYgbm90LCBJIGNhbiB0cnkg aXQgYW5kIGlmIGl0IHdvcmtzIG9uIEtWLCBJIGNhbiBzdWJtaXQgYSBwYXRjaC4KPj4gQnV0IGlm IHlvdSBkbyB0aGluayBpdCBpcyByaXNreSwgd2hhdCBkbyB5b3UgcmVjb21tZW5kIGZvciAzLjE5 ID8gRG8gdGhlIGZpeCBJCj4+IHN1Z2dlc3RlZCBvciBkaXNhYmxlIGJ1aWxkLWluIGNvbXBpbGF0 aW9uIG9wdGlvbiA/Cj4KPiBJIHdvdWxkIHNheSBjcmVhdGUgdGhlIHBhdGNoIG9mIGNoYW5naW5n IHRoZSBvcmRlciAoc2hvdWxkIGJlIHRyaXZpYWwpLCBkZXNjcmliZQo+IGluIGRldGFpbCBpbiB0 aGUgY29tbWl0IG1lc3NhZ2Ugd2hhdCB0aGlzIGlzIHN1cHBvc2VkIHRvIGZpeCBhbmQgd2h5IHN1 Y2ggYW4KPiBzZXZlcmUgY2hhbmdlIHdhcyBkb25lIGluIC1yYzEgYW5kIHN1Ym1pdCBpdCB1cHN0 cmVhbS4KPgo+IFdlIGNhbiBzdGlsbCByZXZlcnQgaXQgaW4gLXJjMiBpZiBpdCBicmVha3MgYW55 dGhpbmcuCj4KPiBDaHJpc3RpYW4uCj4KPj4KPj4gICAgIE9kZWQKPgoKT0ssIEknbGwgdHJ5IGl0 IG9uIG15IG1hY2hpbmUgYW5kIGlmIGl0IHdvcmtzLCBJIHdpbGwgc2VuZCB0aGUgcGF0Y2ggdG8g dGhlIGxpc3QuCgoJT2RlZApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754158AbaLVJ1M (ORCPT ); Mon, 22 Dec 2014 04:27:12 -0500 Received: from mail-bn1on0137.outbound.protection.outlook.com ([157.56.110.137]:52976 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754164AbaLVJ1K convert rfc822-to-8bit (ORCPT ); Mon, 22 Dec 2014 04:27:10 -0500 X-WSS-ID: 0NGZ8X2-08-96Q-02 X-M-MSG: Message-ID: <5497E3D7.1060405@amd.com> Date: Mon, 22 Dec 2014 11:26:47 +0200 From: Oded Gabbay Organization: AMD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , "Dave Airlie" CC: dri-devel , "Deucher, Alexander" , "Elifaz, Dana" , LKML Subject: Re: [PATCH 1/3] amdkfd: Don't clear *kfd2kgd on kfd_module_init References: <1419108374-7020-1-git-send-email-oded.gabbay@amd.com> <1419108374-7020-2-git-send-email-oded.gabbay@amd.com> <5496AEAD.3090003@vodafone.de> <5496B04C.50502@amd.com> <5496BAE0.5090901@vodafone.de> <5496C5EA.7050200@amd.com> <5496CA0F.8000800@amd.com> <5496EDF1.7080106@vodafone.de> <5496EF34.70302@amd.com> <5496F0DD.40903@vodafone.de> <5497C98C.2080208@amd.com> <5497CB91.2080306@amd.com> <5497DD0E.7040400@vodafone.de> In-Reply-To: <5497DD0E.7040400@vodafone.de> Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [10.20.0.84] Content-Transfer-Encoding: 8BIT X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Oded.Gabbay@amd.com; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(377454003)(51704005)(24454002)(479174004)(189002)(199003)(31966008)(97736003)(50986999)(87936001)(59896002)(99396003)(101416001)(54356999)(76176999)(21056001)(36756003)(77096005)(2950100001)(4396001)(33656002)(105586002)(86362001)(62966003)(107046002)(77156002)(106466001)(93886004)(120916001)(46102003)(80316001)(64126003)(68736005)(92566001)(84676001)(87266999)(65956001)(65806001)(20776003)(50466002)(23676002)(64706001)(47776003)(83506001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB200;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB200; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:BN1PR02MB200; X-Forefront-PRVS: 0433DB2766 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB200; X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2014 09:27:07.0689 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2014 10:57 AM, Christian König wrote: > Am 22.12.2014 um 08:43 schrieb Oded Gabbay: >> >> >> On 12/22/2014 09:40 AM, Dave Airlie wrote: >>>>>>>> There should be, but when the modules are compiled in, they are loaded >>>>>>>> based on >>>>>>>> link order only, if they are in the same group, and the groups are >>>>>>>> loaded by a >>>>>>>> pre-defined order. >>>>>>> >>>>>>> Is that really still up to date? I've seen effort to change that >>>>>>> something like >>>>>>> 10+ years ago when Rusty reworked the module system. And it is comming >>>>>>> up on the >>>>>>> lists again from time to time. >>>>>> >>>>>> From what I can see in the Makefile rules, code and google, yes, that's >>>>>> still >>>>>> the situation. If someone will prove me wrong I will be more than happy >>>>>> to >>>>>> correct my code. >>>>>>> >>>>>>> >>>>>>>> I don't want to move iommu before gpu, so I don't have a solution for >>>>>>>> the >>>>>>>> order between amdkfd and amd_iommu_v2. >>>>>>> >>>>>>> Why not? That's still better than creating a kernel workqueue, >>>>>>> scheduling one >>>>>>> work item on it, rescheduling the task until everything is completed and >>>>>>> you can >>>>>>> continue. >>>>>> >>>>>> Because I don't know the consequences of moving an entire subsystem in >>>>>> front >>>>>> of another one. In addition, even if everyone agrees, I'm pretty sure >>>>>> that >>>>>> Linus won't be happy to do that in -rc stages. So maybe this is something >>>>>> to >>>>>> consider for 3.20 merge window, but I would still like to provide a >>>>>> solution >>>>>> for 3.19. >>>>> >>>>> >>>>> Yeah, true indeed. How about depending on everything being compiled as >>>>> module >>>>> for 3.19 then? Still better than having such a hack in the driver for as a >>>>> temporary workaround for one release. >>>>> >>>> I thought about it, but because this problem was originally reported by a >>>> user that told us he couldn't use modules because of his setup, I decided >>>> not to. >>>> I assume there are other users out there who needs this option (compiled >>>> everything in the kernel - embedded ?), so I don't want to make their life >>>> harder. >>>> >>>> In addition, saying it is a workaround for one release is true in case >>>> moving iommu subsystem in front of gpu subsystem is acceptable and doesn't >>>> cause other problems, unknown at this point. >>>> >>>> Bottom line, my personal preference is to help the users _now_ and if a >>>> better fix is found in the future, change the code accordingly. >>> >>> My guess is moving the iommu subsystem in front of the GPU would be rational. >>> >>> It does seem like it would generally have a depend in that order. >>> >>> Dave. >>> >> Dave, >> I agree, but don't you think it is too risky for -rc stages ? >> If not, I can try it and if it works on KV, I can submit a patch. >> But if you do think it is risky, what do you recommend for 3.19 ? Do the fix I >> suggested or disable build-in compilation option ? > > I would say create the patch of changing the order (should be trivial), describe > in detail in the commit message what this is supposed to fix and why such an > severe change was done in -rc1 and submit it upstream. > > We can still revert it in -rc2 if it breaks anything. > > Christian. > >> >> Oded > OK, I'll try it on my machine and if it works, I will send the patch to the list. Oded