From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH] xen: arm: correct off-by-one error in
	consider_modules
Date: Mon, 22 Dec 2014 11:54:01 +0100
Message-ID: <5497F849.3050806@linaro.org>
References: <1419160733-31534-1-git-send-email-ijc@hellion.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1419160733-31534-1-git-send-email-ijc@hellion.org.uk>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ijc@hellion.org.uk>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 21/12/2014 12:18, Ian Campbell wrote:
> By iterating up to <= mi->nr_mods we are running off the end of the boot
> modules, but more importantly it causes us to then skip the first FDT reserved
> region, meaning we might clobber it.

Oops. Good catch!

OOI, how did you find it?

> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>

Reviewed-by: Julien Grall <julien.grall@linaro.org>

> ---
> For 4.5: I think this bug fix should go in, it fixes a real issue and is low
> risk.

Agreed.

> I'll also add to my list of things to consider for backport to 4.4.

Ditto.

Regards,

-- 
Julien Grall