Re: [PATCH] cx23885: Split Hauppauge WinTV Starburst from HVR4400 card entry

[Matthias Schwarzott <zzam@gentoo.org>]

On 22.12.2014 13:59, Steven Toth wrote:
> On Sun, Dec 21, 2014 at 2:59 PM, Matthias Schwarzott <zzam@gentoo.org> wrote:
>> Unconditionally attaching Si2161/Si2165 demod driver
>> breaks Hauppauge WinTV Starburst.
>> So create own card entry for this.
>>
>> Add card name comments to the subsystem ids.
>>
>> Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
> 
> Matthias,
> 
> Thank you for your work. However, nobody knows or cares what
> 'STARBURST' is. When I created the original driver I was careful to
> name the card identified to match the actual hardware names that were
> sold in retail, this eases future maintenance for people with no
> knowledge of the hardware and makes Linux support for the HVR550 much
> more obvious in google.
> 
> Please change CX23885_BOARD_HAUPPAUGE_STARBURST to
> CX23885_BOARD_HAUPPAUGE_HVR5500.
> 
> Thanks,
> 
Hi Steven,

thank you for your feedback.

I rechecked the names and this are the more or less supported devices:
* Starburst supports DVB-S2 only
* HVR-4400 supports DVB-S2 + DVB-T (Si2161)
* HVR-5500 supports DVB-S2 + DVB-C/T (Si2165)

As starburst has only one demod and HVR-4400/HVR-5500 have two, there is
one card entry for HVR-4400/HVR-5500 and a second one with different
name for the Sturburst.

Checking hauppauge homepage I directly get to the WinTV-Starburst:
http://www.hauppauge.de/site/products/data_starburst.html

So I see this is an official product name. Why not show this name?

Regards
Matthias