Re: [meta-fsl-arm][PATCH V2 ] qe-ucode :add recipes for Layerscape1 support

[Gary Thomas <samoht.yrag@gmail.com>]

On 2014-12-22 01:43, b40290@freescale.com wrote:
> From: Chunrong Guo <B40290@freescale.com>
>
>     QE microcode from Freescale is typically provided as a header file.
>     This header file contains macros that define the microcode binary itself as well as
>     some other data used in uploading that microcode
>
> Signed-off-by: Chunrong Guo <B40290@freescale.com>
> ---
>   conf/machine/ls1021aqds.conf         |  2 ++
>   conf/machine/ls1021atwr.conf         |  1 +
>   recipes-bsp/qe-ucode/qe-ucode_git.bb | 28 ++++++++++++++++++++++++++++
>   3 files changed, 31 insertions(+)
>   create mode 100644 recipes-bsp/qe-ucode/qe-ucode_git.bb
>
> diff --git a/conf/machine/ls1021aqds.conf b/conf/machine/ls1021aqds.conf
> index d659196..60df6c0 100644
> --- a/conf/machine/ls1021aqds.conf
> +++ b/conf/machine/ls1021aqds.conf
> @@ -15,6 +15,8 @@ UBOOT_CONFIG[qspi] = "ls1021aqds_qspi_config"
>   UBOOT_CONFIG[nor-secboot] = "ls1021aqds_nor_secboot_config"
>   UBOOT_CONFIG[lpuart] = "ls1021aqds_lpuart_config"
>
> +QE_UCODE="iram_Type_A_LS1021a_r1.0.bin"
> +
>   KERNEL_DEVICETREE = "ls1021aqds.dtb"
>
>   SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1 115200;ttyEHV0 115200;ttyLP0"
> diff --git a/conf/machine/ls1021atwr.conf b/conf/machine/ls1021atwr.conf
> index e549ac3..73f222d 100644
> --- a/conf/machine/ls1021atwr.conf
> +++ b/conf/machine/ls1021atwr.conf
> @@ -14,6 +14,7 @@ UBOOT_CONFIG[nor] = "ls1021atwr_nor_config"
>   UBOOT_CONFIG[sdcard] = "ls1021atwr_sdcard_config,sdcard"
>   UBOOT_CONFIG[lpuart] = "ls1021atwr_lpuart_config"
>
> +QE_UCODE="iram_Type_A_LS1021a_r1.0.bin"
>
>   KERNEL_DEVICETREE ?= "ls1021atwr.dtb"
>
> diff --git a/recipes-bsp/qe-ucode/qe-ucode_git.bb b/recipes-bsp/qe-ucode/qe-ucode_git.bb
> new file mode 100644
> index 0000000..1983d9a
> --- /dev/null
> +++ b/recipes-bsp/qe-ucode/qe-ucode_git.bb
> @@ -0,0 +1,28 @@
> +DESCRIPTION = "qe microcode binary"
> +SECTION = "qe-ucode"
> +LICENSE = "Freescale-EULA"
> +LIC_FILES_CHKSUM = "file://EULA;md5=60037ccba533a5995e8d1a838d85799c"
> +
> +inherit deploy
> +
> +SRC_URI = "git://git.freescale.com/ppc/sdk/qe-ucode.git;nobranch=1"
> +SRCREV= "49efc94b553de5c2a9bd28093592eff0068e161c"
> +
> +S = "${WORKDIR}/git"
> +
> +do_install () {
> +	install -d ${D}/
> +	install -m 644 ${QE_UCODE} ${D}/
> +}
> +
> +do_deploy () {
> +	install -d ${DEPLOYDIR}/
> +	install -m 644 ${QE_UCODE} ${DEPLOYDIR}/
> +}
> +addtask deploy before do_build after do_install
> +
> +PACKAGES += "${PN}-image"
> +FILES_${PN}-image += "/*"
> +ALLOW_EMPTY_${PN} = "1"
> +COMPATIBLE_MACHINE = "(ls1021atwr|ls1021aqds)"

Is this recipe truly *machine* dependent, or *SOC* dependent?  e.g. I have
a target which is roughly the same as the ls1021atwr which could use this
and the way this recipe is written, I'd have to write a .bbappend to
extend COMPATIBLE_MACHINE which seems a bit sad...