From: Jens Axboe <axboe@fb.com>
To: Shaohua Li <shli@fb.com>, linux-ide@vger.kernel.org
Cc: Kernel-team@fb.com, Tejun Heo <tj@kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2 2/3] blk-mq: add tag allocation policy
Date: Mon, 22 Dec 2014 16:25:19 -0700 [thread overview]
Message-ID: <5498A85F.7090508@fb.com> (raw)
In-Reply-To: <be6eb099c483f26e63dc43080055e7644bc2bcad.1418928090.git.shli@fb.com>
On 12/18/2014 11:46 AM, Shaohua Li wrote:
> This is the blk-mq part to support tag allocation policy. The default
> allocation policy isn't changed (though it's not a strict FIFO). The new
> policy is round-robin for libata. But it's a try-best implementation. If
> multiple tasks are competing, the tags returned will be mixed (which is
> unavoidable even with !mq, as requests from different tasks can be
> mixed in queue)
Can we get rid of the atomic_read() on non-rr? It's never set outside of
initialization there.
--
Jens Axboe
next prev parent reply other threads:[~2014-12-22 23:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 18:46 [PATCH v2 1/3] block: support different tag allocation policy Shaohua Li
2014-12-18 18:46 ` [PATCH v2 2/3] blk-mq: add " Shaohua Li
2014-12-22 23:25 ` Jens Axboe [this message]
2015-01-02 19:43 ` Shaohua Li
2014-12-18 18:46 ` [PATCH v2 3/3] libata: use blk taging Shaohua Li
2015-01-09 18:15 ` Shaohua Li
2015-01-09 21:43 ` Tejun Heo
2015-01-09 21:59 ` Shaohua Li
2015-01-09 22:12 ` Shaohua Li
2015-01-14 8:08 ` Dan Williams
2015-01-14 16:30 ` Shaohua Li
2015-01-14 17:09 ` Dan Williams
[not found] ` <CAPcyv4hMwpGzeaovnXtqyYFM46wodRamZd7CNVoR43JJYh0Tjg@mail.gmail.com>
2015-01-14 17:13 ` Shaohua Li
2015-01-14 17:37 ` Dan Williams
2015-01-15 9:28 ` Christoph Hellwig
2015-01-15 15:02 ` Tejun Heo
2015-01-15 18:40 ` Shaohua Li
2015-01-15 18:57 ` Tejun Heo
2015-01-15 18:59 ` Dan Williams
2015-01-15 19:03 ` Tejun Heo
2015-01-15 19:15 ` Jens Axboe
2015-01-15 19:51 ` Dan Williams
2015-01-15 22:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5498A85F.7090508@fb.com \
--to=axboe@fb.com \
--cc=Kernel-team@fb.com \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=shli@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.