From: Mike Christie <michaelc@cs.wisc.edu>
To: John Soni Jose <sony.john-n@Emulex.Com>, linux-scsi@vger.kernel.org
Cc: Minh Tran <minhduc.tran@Emulex.Com>,
Jayamohan Kallickal <jayamohan.kallickal@Emulex.Com>
Subject: Re: [PATCH V2 1/4] be2iscsi : Fix the retry count for boot targets
Date: Mon, 22 Dec 2014 17:54:54 -0600 [thread overview]
Message-ID: <5498AF4E.1030903@cs.wisc.edu> (raw)
In-Reply-To: <5498ADA9.7080104@cs.wisc.edu>
On 12/22/2014 05:47 PM, Mike Christie wrote:
> On 12/19/2014 06:51 PM, John Soni Jose wrote:
>> @@ -5376,8 +5387,14 @@ beiscsi_hw_health_check(struct work_struct *work)
>> be_eqd_update(phba);
>>
>> if (phba->state & BE_ADAPTER_CHECK_BOOT) {
>> - phba->state &= ~BE_ADAPTER_CHECK_BOOT;
>> - be_check_boot_session(phba);
>> + if ((phba->get_boot > 0) && (!phba->boot_kset)) {
>> + phba->get_boot--;
>> + if (!(phba->get_boot % BE_GET_BOOT_TO))
>> + be_check_boot_session(phba);
>> + } else {
>> + phba->state &= ~BE_ADAPTER_CHECK_BOOT;
>> + phba->get_boot = 0;
>> + }
>> }
>
> Hey, I just want to make sure I am reading this patch correctly. If the
> user had the network up, but the target was not able to handle the login
> for longer than the timeout we are adding in this patch, then we will
> not be able to get any notification (the iscsi boot info would not show
> up in sysfs) later when we can login.
>
Actually, I think I am wrong. If we hit the above scenario, then
eventually the fw would log in and we would then get a
ASYNC_EVENT_NEW_ISCSI_CONN event right?
next prev parent reply other threads:[~2014-12-22 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 0:51 [PATCH V2 1/4] be2iscsi : Fix the retry count for boot targets John Soni Jose
2014-12-22 23:47 ` Mike Christie
2014-12-22 23:54 ` Mike Christie [this message]
2014-12-24 7:38 ` Sony John-N
2015-02-28 21:07 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5498AF4E.1030903@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jayamohan.kallickal@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
--cc=minhduc.tran@Emulex.Com \
--cc=sony.john-n@Emulex.Com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.