From: Ding Tianhong <dingtianhong@huawei.com>
To: Wengang Wang <wen.gang.wang@oracle.com>, <netdev@vger.kernel.org>,
<gospo@cumulusnetworks.com>
Subject: Re: [PATCH] bonding: change error message to debug message in __bond_release_one()
Date: Tue, 23 Dec 2014 09:48:38 +0800 [thread overview]
Message-ID: <5498C9F6.70608@huawei.com> (raw)
In-Reply-To: <1419297876-1412-1-git-send-email-wen.gang.wang@oracle.com>
On 2014/12/23 9:24, Wengang Wang wrote:
> In __bond_release_one(), when the interface is not a slave or not a slave of
> "this" master, it log error message.
>
> The message actually should be a debug message matching what bond_enslave()
> does.
>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 184c434..0dceba1 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1648,7 +1648,7 @@ static int __bond_release_one(struct net_device *bond_dev,
> /* slave is not a slave or master is not master of this slave */
> if (!(slave_dev->flags & IFF_SLAVE) ||
> !netdev_has_upper_dev(slave_dev, bond_dev)) {
> - netdev_err(bond_dev, "cannot release %s\n",
> + netdev_dbg(bond_dev, "cannot release %s\n",
> slave_dev->name);
> return -EINVAL;
> }
>
Acked-by: Ding Tianhong <dingtianhong@huawei.com>
next prev parent reply other threads:[~2014-12-23 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 1:24 [PATCH] bonding: change error message to debug message in __bond_release_one() Wengang Wang
2014-12-23 1:48 ` Ding Tianhong [this message]
2014-12-23 16:02 ` Andy Gospodarek
2014-12-25 23:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5498C9F6.70608@huawei.com \
--to=dingtianhong@huawei.com \
--cc=gospo@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=wen.gang.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.