From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH 1/2] drivers: Move iommu/ before gpu/ in Makefile Date: Tue, 23 Dec 2014 14:09:07 +0200 Message-ID: <54995B63.5090808@amd.com> References: <1419246435-7050-1-git-send-email-oded.gabbay@amd.com> <1419246435-7050-2-git-send-email-oded.gabbay@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1419246435-7050-2-git-send-email-oded.gabbay@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Torvalds Cc: Geert Uytterhoeven , Greg Kroah-Hartman , Dana Elifaz , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, Alexander Deucher , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= List-Id: iommu@lists.linux-foundation.org SGVsbG8gTGludXMsCkRhdmUgQWlybGllIGFza2VkIG1lIHRvIHNlbmQgdGhpcyBwYXRjaCB0byB5 b3UgZm9yIHJldmlldy4KU2VlIGxpbmsgYmVsb3cgZm9yIGNvdmVyLWxldHRlciBmb3IgdGhpcyBw YXRjaCB0aGF0IGV4cGxhaW5zIHRoZSBiYWNrZ3JvdW5kIGEgCmJpdCBtb3JlOgpodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE0LURlY2VtYmVyLzA3NDQ1 Mi5odG1sCgpUaGFua3MsCglPZGVkCgoKT24gMTIvMjIvMjAxNCAwMTowNyBQTSwgT2RlZCBHYWJi YXkgd3JvdGU6Cj4gQU1EIEdQVSBkZXZpY2VzIGFyZSBkZXBlbmRlbnQgb24gQU1EIElPTU1VIGNv bnRyb2xsZXIgZnVuY3Rpb25hbGl0eSB0byBhbGxvdwo+IHRoZSBHUFUgdG8gYWNjZXNzIGEgcHJv Y2VzcydzIHZpcnR1YWwgbWVtb3J5IGFkZHJlc3Mgc3BhY2UsIHdpdGhvdXQgdGhlIG5lZWQKPiBm b3IgcGlubmluZyB0aGUgbWVtb3J5Lgo+Cj4gVGhpcyBwYXRjaCBjaGFuZ2VzIHRoZSBvcmRlciBp biB0aGUgZHJpdmVycyBtYWtlZmlsZSwgc28gaW9tbXUvIHN1YnN5c3RlbSBpcwo+IGxpbmtlZCBi ZWZvcmUgZ3B1LyBzdWJzeXN0ZW0uIFRoYXQgd2F5LCBpZiB0aGUgZ3B1IGFuZCBpb21tdSBkcml2 ZXJzIGFyZQo+IGNvbXBpbGVkIGluc2lkZSB0aGUga2VybmVsIGltYWdlIChub3QgYXMgbW9kdWxl cyksIHRoZSBjb3JyZWN0IG9yZGVyIG9mIGRldmljZQo+IGxvYWRpbmcgaXMgc3RpbGwgbWFpbnRh aW5lZCAoaW9tbXUgbW9kdWxlIGlzIGxvYWRlZCBiZWZvcmUgZ3B1IG1vZHVsZSkuCj4KPiBTaWdu ZWQtb2ZmLWJ5OiBPZGVkIEdhYmJheSA8b2RlZC5nYWJiYXlAYW1kLmNvbT4KPiAtLS0KPiAgIGRy aXZlcnMvTWFrZWZpbGUgfCA2ICsrKystLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL01ha2VmaWxlIGIv ZHJpdmVycy9NYWtlZmlsZQo+IGluZGV4IGViZWU1NTUuLjEwNjIwMGYgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9NYWtlZmlsZQo+ICsrKyBiL2RyaXZlcnMvTWFrZWZpbGUKPiBAQCAtNTAsNyArNTAs MTAgQEAgb2JqLSQoQ09ORklHX1JFU0VUX0NPTlRST0xMRVIpCSs9IHJlc2V0Lwo+ICAgb2JqLXkJ CQkJKz0gdHR5Lwo+ICAgb2JqLXkJCQkJKz0gY2hhci8KPgo+IC0jIGdwdS8gY29tZXMgYWZ0ZXIg Y2hhciBmb3IgQUdQIHZzIERSTSBzdGFydHVwCj4gKyMgaW9tbXUvIGNvbWVzIGJlZm9yZSBncHUg YXMgZ3B1IGFyZSB1c2luZyBpb21tdSBjb250cm9sbGVycwo+ICtvYmotJChDT05GSUdfSU9NTVVf U1VQUE9SVCkJKz0gaW9tbXUvCj4gKwo+ICsjIGdwdS8gY29tZXMgYWZ0ZXIgY2hhciBmb3IgQUdQ IHZzIERSTSBzdGFydHVwIGFuZCBhZnRlciBpb21tdQo+ICAgb2JqLXkJCQkJKz0gZ3B1Lwo+Cj4g ICBvYmotJChDT05GSUdfQ09OTkVDVE9SKQkJKz0gY29ubmVjdG9yLwo+IEBAIC0xNDEsNyArMTQ0 LDYgQEAgb2JqLXkJCQkJKz0gY2xrLwo+Cj4gICBvYmotJChDT05GSUdfTUFJTEJPWCkJCSs9IG1h aWxib3gvCj4gICBvYmotJChDT05GSUdfSFdTUElOTE9DSykJKz0gaHdzcGlubG9jay8KPiAtb2Jq LSQoQ09ORklHX0lPTU1VX1NVUFBPUlQpCSs9IGlvbW11Lwo+ICAgb2JqLSQoQ09ORklHX1JFTU9U RVBST0MpCSs9IHJlbW90ZXByb2MvCj4gICBvYmotJChDT05GSUdfUlBNU0cpCQkrPSBycG1zZy8K Pgo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755542AbaLWMJg (ORCPT ); Tue, 23 Dec 2014 07:09:36 -0500 Received: from mail-bn1bbn0109.outbound.protection.outlook.com ([157.56.111.109]:30883 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754733AbaLWMJe (ORCPT ); Tue, 23 Dec 2014 07:09:34 -0500 X-WSS-ID: 0NH1B3P-08-A3D-02 X-M-MSG: Message-ID: <54995B63.5090808@amd.com> Date: Tue, 23 Dec 2014 14:09:07 +0200 From: Oded Gabbay Organization: AMD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Linus Torvalds CC: David Airlie , Greg Kroah-Hartman , Geert Uytterhoeven , Dana Elifaz , , , Alexander Deucher , , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: [PATCH 1/2] drivers: Move iommu/ before gpu/ in Makefile References: <1419246435-7050-1-git-send-email-oded.gabbay@amd.com> <1419246435-7050-2-git-send-email-oded.gabbay@amd.com> In-Reply-To: <1419246435-7050-2-git-send-email-oded.gabbay@amd.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.0.84] X-EOPAttributedMessage: 0 Authentication-Results: spf=temperror (sender IP is 165.204.84.222) smtp.mailfrom=Oded.Gabbay@amd.com; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(51704005)(24454002)(377454003)(164054003)(479174004)(189002)(199003)(21056001)(46102003)(97736003)(87936001)(120916001)(50986999)(87266999)(54356999)(99396003)(59896002)(65816999)(62966003)(50466002)(77156002)(64706001)(33656002)(2950100001)(4396001)(20776003)(76176999)(65806001)(65956001)(15975445007)(77096005)(64126003)(68736005)(84676001)(31966008)(19580405001)(47776003)(80316001)(106466001)(92566001)(83506001)(19580395003)(23676002)(36756003)(110136001)(107046002)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB197;H:atltwp02.amd.com;FPR:;SPF:TempError;MLV:sfv;PTR:InfoDomainNonexistent;MX:1;A:3;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB197; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:BN1PR02MB197; X-Forefront-PRVS: 04347F8039 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB197; X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2014 12:09:28.0713 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB197 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Linus, Dave Airlie asked me to send this patch to you for review. See link below for cover-letter for this patch that explains the background a bit more: http://lists.freedesktop.org/archives/dri-devel/2014-December/074452.html Thanks, Oded On 12/22/2014 01:07 PM, Oded Gabbay wrote: > AMD GPU devices are dependent on AMD IOMMU controller functionality to allow > the GPU to access a process's virtual memory address space, without the need > for pinning the memory. > > This patch changes the order in the drivers makefile, so iommu/ subsystem is > linked before gpu/ subsystem. That way, if the gpu and iommu drivers are > compiled inside the kernel image (not as modules), the correct order of device > loading is still maintained (iommu module is loaded before gpu module). > > Signed-off-by: Oded Gabbay > --- > drivers/Makefile | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/Makefile b/drivers/Makefile > index ebee555..106200f 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -50,7 +50,10 @@ obj-$(CONFIG_RESET_CONTROLLER) += reset/ > obj-y += tty/ > obj-y += char/ > > -# gpu/ comes after char for AGP vs DRM startup > +# iommu/ comes before gpu as gpu are using iommu controllers > +obj-$(CONFIG_IOMMU_SUPPORT) += iommu/ > + > +# gpu/ comes after char for AGP vs DRM startup and after iommu > obj-y += gpu/ > > obj-$(CONFIG_CONNECTOR) += connector/ > @@ -141,7 +144,6 @@ obj-y += clk/ > > obj-$(CONFIG_MAILBOX) += mailbox/ > obj-$(CONFIG_HWSPINLOCK) += hwspinlock/ > -obj-$(CONFIG_IOMMU_SUPPORT) += iommu/ > obj-$(CONFIG_REMOTEPROC) += remoteproc/ > obj-$(CONFIG_RPMSG) += rpmsg/ > >