All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: 尹杰 <writalnaie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Missing "{" in perf_event_open's document
Date: Tue, 23 Dec 2014 16:31:19 +0100	[thread overview]
Message-ID: <54998AC7.2050303@gmail.com> (raw)
In-Reply-To: <CACeBgBsJVfFok5sv1DnOqe-_yRTG6ERso-x2Z15NH1bRLsrQ6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 12/18/2014 02:49 PM, 尹杰 wrote:
> Hi all,
> 
> I am a operating system researcher in Tsinghua University. I find that
> there is a missing "{" in the definition of struct read_format's inner
> struct definition in the function perf_event_open
> <http://man7.org/linux/man-pages/man2/perf_event_open.2.html>'s document :
> 
>              struct read_format {
>                  u64 nr;            /* The number of events */
>                  u64 time_enabled;  /* if PERF_FORMAT_TOTAL_TIME_ENABLED */
>                  u64 time_running;  /* if PERF_FORMAT_TOTAL_TIME_RUNNING */
>                  struct
>                      u64 value;     /* The value of the event */
>                      u64 id;        /* if PERF_FORMAT_ID */
>                  } values[nr];
>              };
> 
> 
> should be
> 
>              struct read_format {
>                  u64 nr;            /* The number of events */
>                  u64 time_enabled;  /* if PERF_FORMAT_TOTAL_TIME_ENABLED */
>                  u64 time_running;  /* if PERF_FORMAT_TOTAL_TIME_RUNNING */
>                  struct {
>                      u64 value;     /* The value of the event */
>                      u64 id;        /* if PERF_FORMAT_ID */
>                  } values[nr];
>              };

Hello Jie Yin, 

Thanks for the report. I fixed the page as you suggest.

Cheers,

Michael
 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

           reply	other threads:[~2014-12-23 15:31 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CACeBgBsJVfFok5sv1DnOqe-_yRTG6ERso-x2Z15NH1bRLsrQ6g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54998AC7.2050303@gmail.com \
    --to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=writalnaie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.