From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Arend van Spriel <arend@broadcom.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Hante Meuleman <meuleman@broadcom.com>
Subject: Re: [PATCH 02/10] brcmfmac: Fix possible dereference of NULL pointer.
Date: Tue, 23 Dec 2014 18:07:42 +0100 [thread overview]
Message-ID: <5499A15E.9080307@broadcom.com> (raw)
In-Reply-To: <1419162233-19492-3-git-send-email-arend@broadcom.com>
On 12/21/14 12:43, Arend van Spriel wrote:
> From: Hante Meuleman<meuleman@broadcom.com>
>
> With the introduction of WOWL for SDIO a possible dereference of a
> NULL pointer got introduced. Found by static checker.
Kalle,
Can you drop this patch and take the one from Mika instead with
Message-ID:
1419346112-173303-1-git-send-email-mika.westerberg@linux.intel.com [1]
Regards,
Arend
[1]
http://mid.gmane.org/1419346112-173303-1-git-send-email-mika.westerberg@linux.intel.com
> Reported-by: Dan Carpenter<dan.carpenter@oracle.com>
> Reviewed-by: Arend Van Spriel<arend@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts<pieterpg@broadcom.com>
> Signed-off-by: Hante Meuleman<meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel<arend@broadcom.com>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> index 3c06e93..9583dcd 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c
> @@ -1070,7 +1070,7 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func,
> */
> if ((sdio_get_host_pm_caps(sdiodev->func[1])& MMC_PM_KEEP_POWER)&&
> ((sdio_get_host_pm_caps(sdiodev->func[1])& MMC_PM_WAKE_SDIO_IRQ) ||
> - (sdiodev->pdata->oob_irq_supported)))
> + ((sdiodev->pdata)&& (sdiodev->pdata->oob_irq_supported))))
> bus_if->wowl_supported = true;
> #endif
>
next prev parent reply other threads:[~2014-12-23 17:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-21 11:43 [PATCH 00/10] brcmfmac: new device support and more Arend van Spriel
2014-12-21 11:43 ` [PATCH 01/10] brcmfmac: Fix incorrect casting of 64 bit physical address Arend van Spriel
2014-12-21 17:24 ` Joe Perches
2014-12-21 11:43 ` [PATCH 02/10] brcmfmac: Fix possible dereference of NULL pointer Arend van Spriel
2014-12-23 17:07 ` Arend van Spriel [this message]
2014-12-21 11:43 ` [PATCH 03/10] brcmfmac: Add support for bcm43340/1 wireless chipsets Arend van Spriel
2014-12-21 17:50 ` Marcel Holtmann
2014-12-21 19:56 ` Arend van Spriel
2014-12-21 20:14 ` Rafał Miłecki
2014-12-22 9:05 ` Arend van Spriel
2014-12-22 9:33 ` Rafał Miłecki
2014-12-21 11:43 ` [PATCH 04/10] brcmfmac: get rid of duplicate SDIO device identifiers Arend van Spriel
2015-01-06 18:35 ` Kalle Valo
2014-12-21 11:43 ` [PATCH 05/10] brcmfmac: remove unused/duplicate defines in chip.c Arend van Spriel
2014-12-21 11:43 ` [PATCH 06/10] brcmfmac: Fix WEP configuration for AP mode Arend van Spriel
2014-12-21 11:43 ` [PATCH 07/10] brcmfmac: Change error log in standard log for rxbufpost Arend van Spriel
2014-12-21 11:43 ` [PATCH 08/10] brcmfmac: follow user-space regulatory domain selection Arend van Spriel
2014-12-21 11:43 ` [PATCH 09/10] brcmfmac: signal completion of 802.1x Arend van Spriel
2014-12-21 11:43 ` [PATCH 10/10] brcmfmac: enable 802.11d support in firmware Arend van Spriel
2015-01-06 18:36 ` [PATCH 00/10] brcmfmac: new device support and more Kalle Valo
2015-01-06 19:07 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5499A15E.9080307@broadcom.com \
--to=arend@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.