From: Johannes Sixt <j6t@kdbg.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] is_hfs_dotgit: loosen over-eager match of \u{..47}
Date: Tue, 23 Dec 2014 21:31:10 +0100 [thread overview]
Message-ID: <5499D10E.5050704@kdbg.org> (raw)
In-Reply-To: <20141223084536.GA25190@peff.net>
Am 23.12.2014 um 09:45 schrieb Jeff King:
> @@ -606,7 +606,7 @@ static ucs_char_t next_hfs_char(const char **in)
> * but this is enough to catch anything that will convert
> * to ".git"
> */
> - return tolower(out);
> + return out;
Did you consider changing the comment that we see in the pre-context here?
-- Hannes
next prev parent reply other threads:[~2014-12-23 20:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 8:45 [PATCH] is_hfs_dotgit: loosen over-eager match of \u{..47} Jeff King
2014-12-23 15:24 ` Torsten Bögershausen
2014-12-23 18:17 ` Junio C Hamano
2014-12-23 18:18 ` Jeff King
2014-12-23 20:14 ` Jonathan Nieder
2014-12-23 21:02 ` Junio C Hamano
2014-12-23 21:12 ` Jeff King
2014-12-23 21:09 ` Jeff King
2014-12-23 20:31 ` Johannes Sixt [this message]
2014-12-23 21:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5499D10E.5050704@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.