All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: "Andreas Müller" <schnitzeltony@googlemail.com>,
	openembedded-core@lists.openembedded.org, raj.khem@gmail.com
Subject: Re: [PATCH][V2 2/3] gettext-native: build libintl so that other native recipes can use them
Date: Wed, 24 Dec 2014 10:58:40 -0800	[thread overview]
Message-ID: <549B0CE0.20003@linux.intel.com> (raw)
In-Reply-To: <1417610456-788-2-git-send-email-schnitzeltony@googlemail.com>

On 12/03/2014 04:40 AM, Andreas Müller wrote:
> I have a native recipe around which directly compiles/links against libintl.
> Gettext contains this code (usually supplied by glibc) as fallback. In native
> case this code is used by default because we don't have glibc there. This patch
> changes static linking into dynamic linking making libintl code shareable.
>
> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
> ---
>   meta/recipes-core/gettext/gettext_0.18.3.2.bb | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-core/gettext/gettext_0.18.3.2.bb b/meta/recipes-core/gettext/gettext_0.18.3.2.bb
> index 65d4103..98838d7 100644
> --- a/meta/recipes-core/gettext/gettext_0.18.3.2.bb
> +++ b/meta/recipes-core/gettext/gettext_0.18.3.2.bb
> @@ -39,6 +39,9 @@ EXTRA_OECONF += "--without-lispdir \
>                    --with-included-libunistring \
>                   "
>
> +# we have no glib intl
> +EXTRA_OECONF_append_class-native = "--with-included-gettext --enable-shared"
> +

This patch might be causing problems in other places, we had a recent 
failure on the Autobuilder:

> | Building program /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-deb/build/build/tmp/work/x86_64-linux/apt-native/0.9.9.4-r0/build/bin/methods/mirror
> | /usr/bin/ld: /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-deb/build/build/tmp/work/x86_64-linux/apt-native/0.9.9.4-r0/build/obj/methods/mirror.o: undefined reference to symbol 'libintl_dgettext'
> | /usr/bin/ld: note: 'libintl_dgettext' is defined in DSO /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-deb/build/build/tmp/sysroots/x86_64-linux/usr/lib/libintl.so.8 so try adding it to the linker command line
> | /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-deb/build/build/tmp/sysroots/x86_64-linux/usr/lib/libintl.so.8: could not read symbols: Invalid operation
> | collect2: error: ld returned 1 exit status
> | make[2]: *** [/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-deb/build/build/tmp/work/x86_64-linux/apt-native/0.9.9.4-r0/build/bin/methods/mirror] Error 1
> | make[1]: *** [all] Error 2
> | make: *** [all] Error 2
> | ERROR: oe_runmake failed
> | WARNING: exit code 1 from a shell command.
> | ERROR: Function failed: do_compile (log file is located at /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-deb/build/build/tmp/work/x86_64-linux/apt-native/0.9.9.4-r0/temp/log.do_compile.12994)
> NOTE: recipe apt-native-0.9.9.4-r0: task do_compile: Failed

Since gettext affects alot of other projects, can you try a world build 
to ensure there is not other issues with this change. Or check at least 
check more native recipes.

Thanks

Sau!
>   acpaths = '-I ${S}/gettext-runtime/m4 \
>              -I ${S}/gettext-tools/m4'
>
>


  parent reply	other threads:[~2014-12-24 18:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-03 12:40 [PATCH][V2 1/3] pythonnative: set PYTHON_EXECUTABLE so that cmake can find it Andreas Müller
2014-12-03 12:40 ` [PATCH][V2 2/3] gettext-native: build libintl so that other native recipes can use them Andreas Müller
2014-12-15 10:30   ` Andreas Müller
2014-12-24 18:58   ` Saul Wold [this message]
2014-12-03 12:40 ` [PATCH][V2 3/3] fix cross-localedef build with gettext-native in sysroot Andreas Müller
2014-12-15 10:31   ` Andreas Müller
2014-12-15  9:12 ` [PATCH][V2 1/3] pythonnative: set PYTHON_EXECUTABLE so that cmake can find it Andreas Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549B0CE0.20003@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=schnitzeltony@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.