From: Dirk Behme <dirk.behme@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] scripts: fix binutils-version.sh
Date: Thu, 25 Dec 2014 07:58:41 +0100 [thread overview]
Message-ID: <549BB5A1.80709@gmail.com> (raw)
In-Reply-To: <1419473384-15413-1-git-send-email-yamada.m@jp.panasonic.com>
On 25.12.2014 03:09, Masahiro Yamada wrote:
> The current binutils-version.sh expects the version string at the end
> of the first line. It turned out to not work with Linaro toolchain:
> It has "Linaro 2014.09" at the back.
>
> To fix this issue, let's parse the word right after the close
> parenthesis.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Reported-by: York Sun <yorksun@freescale.com>
Acked-by: Dirk Behme <dirk.behme@gmail.com>
This fixes the issue [1] for me :)
I'd propose to apply this to 2015.01-rc3.
Thanks!
Dirk
[1] http://lists.denx.de/pipermail/u-boot/2014-December/199515.html
> ---
>
> scripts/binutils-version.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/binutils-version.sh b/scripts/binutils-version.sh
> index d4d9eb4..0bc26cf 100755
> --- a/scripts/binutils-version.sh
> +++ b/scripts/binutils-version.sh
> @@ -14,7 +14,9 @@ if [ ${#gas} -eq 0 ]; then
> exit 1
> fi
>
> -MAJOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 1)
> -MINOR=$($gas --version | head -1 | awk '{print $NF}' | cut -d . -f 2)
> +version_string=$($gas --version | head -1 | sed -e 's/.*) *\([0-9.]*\).*/\1/' )
> +
> +MAJOR=$(echo $version_string | cut -d . -f 1)
> +MINOR=$(echo $version_string | cut -d . -f 2)
>
> printf "%02d%02d\\n" $MAJOR $MINOR
>
next prev parent reply other threads:[~2014-12-25 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 2:09 [U-Boot] [PATCH] scripts: fix binutils-version.sh Masahiro Yamada
2014-12-25 6:58 ` Dirk Behme [this message]
2014-12-30 2:27 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549BB5A1.80709@gmail.com \
--to=dirk.behme@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.