All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Barry Song <21cnbao@gmail.com>,
	peter.ujfalusi@ti.com, tiwai@suse.de, broonie@linaro.org
Cc: alsa-devel@alsa-project.org, workgroup.linux@csr.com,
	Barry Song <Baohua.Song@csr.com>
Subject: Re: [PATCH] ALSA: pcm_dmaengine: correct the error handler of dmaengine_prep_dma_cyclic
Date: Thu, 25 Dec 2014 10:02:33 +0100	[thread overview]
Message-ID: <549BD2A9.505@metafoo.de> (raw)
In-Reply-To: <1419482475-4911-1-git-send-email-21cnbao@gmail.com>

On 12/25/2014 05:41 AM, Barry Song wrote:
> From: Barry Song <Baohua.Song@csr.com>
>
> preparing cyclic DMA description can fail either due to DMA desc list
> is full(-ENOMEM), or due to the coming DMA configuration is illegal or
> not supported by the acting DMA hardware(other ERR codes).

According to the API definition this returns either NULL or a valid 
descriptor, so the behavior in pcm_dmaengine is correct. Maybe your 
particular dmaengine driver as a incorrect implementation.

- Lars

  reply	other threads:[~2014-12-25  9:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-25  4:41 [PATCH] ALSA: pcm_dmaengine: correct the error handler of dmaengine_prep_dma_cyclic Barry Song
2014-12-25  9:02 ` Lars-Peter Clausen [this message]
2014-12-25  9:08   ` Barry Song
2014-12-25  9:35     ` Barry Song
2014-12-25  9:45     ` Lars-Peter Clausen
2014-12-25  9:53       ` Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549BD2A9.505@metafoo.de \
    --to=lars@metafoo.de \
    --cc=21cnbao@gmail.com \
    --cc=Baohua.Song@csr.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@linaro.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tiwai@suse.de \
    --cc=workgroup.linux@csr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.