From: hujianyang <hujianyang@huawei.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>, shengyong1@huawei.com
Subject: [PATCH RFC 1/2] UBIFS: fix empty log leb error
Date: Thu, 25 Dec 2014 20:58:56 +0800 [thread overview]
Message-ID: <549C0A10.3000201@huawei.com> (raw)
If first log leb which is indicated by @log_lnum in mst_node
is empty, current UBIFS will stop finding cs_node and directly
mount the partition.
This patch fix this problem by checking c->cs_sqnum to
guarantee the empty leb is not first log leb and return an
error if the first log leb is incorrectly empty.
Signed-off-by: hujianyang <hujianyang@huawei.com>
---
fs/ubifs/replay.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c
index 3187925..f13f4b2 100644
--- a/fs/ubifs/replay.c
+++ b/fs/ubifs/replay.c
@@ -846,7 +846,14 @@ static int replay_log_leb(struct ubifs_info *c, int lnum, int offs, void *sbuf)
}
if (sleb->nodes_cnt == 0) {
- err = 1;
+ if (unlikely(c->cs_sqnum == 0)) {
+ /* This is the first log LEB, should not be empty */
+ ubifs_err("first log leb LEB %d:%d is empty, no CS node exist",
+ lnum, offs);
+ err = -EINVAL;
+ } else {
+ err = 1;
+ }
goto out;
}
--
1.6.0.2
next reply other threads:[~2014-12-25 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 12:58 hujianyang [this message]
2014-12-25 13:10 ` [PATCH RFC 2/2] UBIFS: scan all log lebs during log replay hujianyang
2015-01-31 12:46 ` Artem Bityutskiy
2015-02-02 2:49 ` hujianyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549C0A10.3000201@huawei.com \
--to=hujianyang@huawei.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=shengyong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.