diff for duplicates of <549C0C3C.8060601@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 90f8f6f..aecc37f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -13,7 +13,7 @@ On 22.12.2014 13:57, Evgeni Dobrev wrote: > > The third led is wired to show the SATA activity on the two drives. > -> Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com> +> Signed-off-by: Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org> Evgeni, @@ -53,7 +53,7 @@ board. Can we make it a little bit more specific like > +/* > + * Device Tree file for Seagate BlackArmor NAS220 > + * -> + * Copyright (C) 2014 Evgeni Dobrev <evgeni@studio-punkt.com> +> + * Copyright (C) 2014 Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org> > + * > + * Licensed under GPLv2 or later. > + */ @@ -87,8 +87,8 @@ compatible should reflect the chosen base name above. > + stdout-path = &uart0; > + }; > + -> + ocp at f1000000 { -> + pinctrl: pin-controller at 10000 { +> + ocp@f1000000 { +> + pinctrl: pin-controller@10000 { v3.19 should already have a label for the common pinctrl node. Please do not replay the bus structure but use a node reference @@ -143,7 +143,7 @@ Remove extra blank line. Nice! Can you also clarify if TX/RX are as seen from the SoC or remote end? -> + serial at 12000 { +> + serial@12000 { Please use node references where possible, IIRC v3.19 should have labels for serial, sata, and i2c. Avoid to replay the bus structure. @@ -151,7 +151,7 @@ labels for serial, sata, and i2c. Avoid to replay the bus structure. > + status = "okay"; > + }; > + -> + sata at 80000 { +> + sata@80000 { > + status = "okay"; > + nr-ports = <2>; @@ -161,14 +161,14 @@ new binding. > + }; > + -> + i2c at 11000 { +> + i2c@11000 { > + status = "okay"; -> + adt7476: adt7476a at 2e { +> + adt7476: adt7476a@2e { I know we have a lot of bad examples, but: node names should reflect device function, not device name, i.e. -adt7476: thermal at 2e { +adt7476: thermal@2e { ... }; @@ -188,7 +188,7 @@ adt7476: thermal at 2e { Add a blank line between nodes. -> + button at 1{ +> + button@1{ > + label = "Reset push button"; Reduce label to "Reset" and "Power" below. @@ -196,7 +196,7 @@ Reduce label to "Reset" and "Power" below. > + linux,code = <KEY_POWER>; > + gpios = <&gpio0 29 GPIO_ACTIVE_HIGH>; > + }; -> + button at 2{ +> + button@2{ > + label = "Power push button"; > + linux,code = <KEY_SLEEP>; > + gpios = <&gpio0 26 GPIO_ACTIVE_LOW>; @@ -222,7 +222,7 @@ Add a blank line between nodes. > + pinctrl-0 = <&pmx_power_sata0 &pmx_power_sata1>; > + pinctrl-names = "default"; > + -> + sata0_power: regulator at 1 { +> + sata0_power: regulator@1 { > + compatible = "regulator-fixed"; > + reg = <1>; > + regulator-name = "SATA0 Power"; @@ -238,7 +238,7 @@ Also, gpio property could use GPIO_ACTIVE_HIGH/LOW here too. > + }; > + -> + sata1_power: regulator at 2 { +> + sata1_power: regulator@2 { > + compatible = "regulator-fixed"; > + reg = <2>; > + regulator-name = "SATA1 Power"; @@ -261,7 +261,7 @@ ditto. > + > +&mdio { > + status = "okay"; -> + ethphy0: ethernet-phy at 8 { +> + ethphy0: ethernet-phy@8 { > + reg = <8>; > + }; @@ -271,7 +271,7 @@ Remove extra space before brace. > + > +ð0 { > + status = "okay"; -> + ethernet0-port at 0 { +> + ethernet0-port@0 { > + phy-handle = <ðphy0>; > + }; > +}; @@ -279,6 +279,11 @@ Remove extra space before brace. Overall, this look fine to me, with the nits taken care of -Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> +Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Thanks! + +-- +To unsubscribe from this list: send the line "unsubscribe devicetree" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index b189121..37812e0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,16 @@ "ref\020141215203855.GA28940@anne\0" "ref\020141222125750.GA29163@anne\0" - "From\0sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)\0" - "Subject\0[PATCH v3 1/1] add support for Seagate BlackArmor NAS220\0" + "From\0Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Subject\0Re: [PATCH v3 1/1] add support for Seagate BlackArmor NAS220\0" "Date\0Thu, 25 Dec 2014 14:08:12 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org>" + " devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "Cc\0linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org> + Sebastian Hesselbarth <sebastian.hesselbarth-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> + Gregory Clement <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> + " Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>\0" "\00:1\0" "b\0" "On 22.12.2014 13:57, Evgeni Dobrev wrote:\n" @@ -21,7 +28,7 @@ ">\n" "> The third led is wired to show the SATA activity on the two drives.\n" ">\n" - "> Signed-off-by: Evgeni Dobrev <evgeni@studio-punkt.com>\n" + "> Signed-off-by: Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org>\n" "\n" "Evgeni,\n" "\n" @@ -61,7 +68,7 @@ "> +/*\n" "> + * Device Tree file for Seagate BlackArmor NAS220\n" "> + *\n" - "> + * Copyright (C) 2014 Evgeni Dobrev <evgeni@studio-punkt.com>\n" + "> + * Copyright (C) 2014 Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org>\n" "> + *\n" "> + * Licensed under GPLv2 or later.\n" "> + */\n" @@ -95,8 +102,8 @@ "> +\t\tstdout-path = &uart0;\n" "> +\t};\n" "> +\n" - "> +\tocp at f1000000 {\n" - "> +\t\tpinctrl: pin-controller at 10000 {\n" + "> +\tocp@f1000000 {\n" + "> +\t\tpinctrl: pin-controller@10000 {\n" "\n" "v3.19 should already have a label for the common pinctrl node.\n" "Please do not replay the bus structure but use a node reference\n" @@ -151,7 +158,7 @@ "Nice! Can you also clarify if TX/RX are as seen from the SoC or\n" "remote end?\n" "\n" - "> +\t\tserial at 12000 {\n" + "> +\t\tserial@12000 {\n" "\n" "Please use node references where possible, IIRC v3.19 should have\n" "labels for serial, sata, and i2c. Avoid to replay the bus structure.\n" @@ -159,7 +166,7 @@ "> +\t\t\tstatus = \"okay\";\n" "> +\t\t};\n" "> +\n" - "> +\t\tsata at 80000 {\n" + "> +\t\tsata@80000 {\n" "> +\t\t\tstatus = \"okay\";\n" "> +\t\t\tnr-ports = <2>;\n" "\n" @@ -169,14 +176,14 @@ "\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c at 11000 {\n" + "> +\t\ti2c@11000 {\n" "> +\t\t\tstatus = \"okay\";\n" - "> +\t\t\tadt7476: adt7476a at 2e {\n" + "> +\t\t\tadt7476: adt7476a@2e {\n" "\n" "I know we have a lot of bad examples, but: node names should reflect\n" "device function, not device name, i.e.\n" "\n" - "adt7476: thermal at 2e {\n" + "adt7476: thermal@2e {\n" "\t...\n" "};\n" "\n" @@ -196,7 +203,7 @@ "\n" "Add a blank line between nodes.\n" "\n" - "> +\t\tbutton at 1{\n" + "> +\t\tbutton@1{\n" "> +\t\t\tlabel = \"Reset push button\";\n" "\n" "Reduce label to \"Reset\" and \"Power\" below.\n" @@ -204,7 +211,7 @@ "> +\t\t\tlinux,code = <KEY_POWER>;\n" "> +\t\t\tgpios = <&gpio0 29 GPIO_ACTIVE_HIGH>;\n" "> +\t\t};\n" - "> +\t\tbutton at 2{\n" + "> +\t\tbutton@2{\n" "> +\t\t\tlabel = \"Power push button\";\n" "> +\t\t\tlinux,code = <KEY_SLEEP>;\n" "> +\t\t\tgpios = <&gpio0 26 GPIO_ACTIVE_LOW>;\n" @@ -230,7 +237,7 @@ "> +\t\tpinctrl-0 = <&pmx_power_sata0 &pmx_power_sata1>;\n" "> +\t\tpinctrl-names = \"default\";\n" "> +\n" - "> +\t\tsata0_power: regulator at 1 {\n" + "> +\t\tsata0_power: regulator@1 {\n" "> +\t\t\tcompatible = \"regulator-fixed\";\n" "> +\t\t\treg = <1>;\n" "> +\t\t\tregulator-name = \"SATA0 Power\";\n" @@ -246,7 +253,7 @@ "\n" "> +\t\t};\n" "> +\n" - "> +\t\tsata1_power: regulator at 2 {\n" + "> +\t\tsata1_power: regulator@2 {\n" "> +\t\t\tcompatible = \"regulator-fixed\";\n" "> +\t\t\treg = <2>;\n" "> +\t\t\tregulator-name = \"SATA1 Power\";\n" @@ -269,7 +276,7 @@ "> +\n" "> +&mdio {\n" "> +\tstatus = \"okay\";\n" - "> +\tethphy0: ethernet-phy at 8 {\n" + "> +\tethphy0: ethernet-phy@8 {\n" "> +\t\t reg = <8>;\n" "> +\t };\n" "\n" @@ -279,7 +286,7 @@ "> +\n" "> +ð0 {\n" "> +\tstatus = \"okay\";\n" - "> +\tethernet0-port at 0 {\n" + "> +\tethernet0-port@0 {\n" "> +\t\tphy-handle = <ðphy0>;\n" "> +\t};\n" "> +};\n" @@ -287,8 +294,13 @@ "\n" "Overall, this look fine to me, with the nits taken care of\n" "\n" - "Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>\n" + "Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" "\n" - Thanks! + "Thanks!\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -41e37486deb83fcd96054e8f2acd6578f38ac83043689d4eb1b9647c0917c297 +0765ac2b565f1eba2e64d0e4d808f93d9ca49c70736cf381ee2c22355e0bd2b3
diff --git a/a/1.txt b/N2/1.txt index 90f8f6f..e0c061e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -87,8 +87,8 @@ compatible should reflect the chosen base name above. > + stdout-path = &uart0; > + }; > + -> + ocp at f1000000 { -> + pinctrl: pin-controller at 10000 { +> + ocp@f1000000 { +> + pinctrl: pin-controller@10000 { v3.19 should already have a label for the common pinctrl node. Please do not replay the bus structure but use a node reference @@ -143,7 +143,7 @@ Remove extra blank line. Nice! Can you also clarify if TX/RX are as seen from the SoC or remote end? -> + serial at 12000 { +> + serial@12000 { Please use node references where possible, IIRC v3.19 should have labels for serial, sata, and i2c. Avoid to replay the bus structure. @@ -151,7 +151,7 @@ labels for serial, sata, and i2c. Avoid to replay the bus structure. > + status = "okay"; > + }; > + -> + sata at 80000 { +> + sata@80000 { > + status = "okay"; > + nr-ports = <2>; @@ -161,14 +161,14 @@ new binding. > + }; > + -> + i2c at 11000 { +> + i2c@11000 { > + status = "okay"; -> + adt7476: adt7476a at 2e { +> + adt7476: adt7476a@2e { I know we have a lot of bad examples, but: node names should reflect device function, not device name, i.e. -adt7476: thermal at 2e { +adt7476: thermal@2e { ... }; @@ -188,7 +188,7 @@ adt7476: thermal at 2e { Add a blank line between nodes. -> + button at 1{ +> + button@1{ > + label = "Reset push button"; Reduce label to "Reset" and "Power" below. @@ -196,7 +196,7 @@ Reduce label to "Reset" and "Power" below. > + linux,code = <KEY_POWER>; > + gpios = <&gpio0 29 GPIO_ACTIVE_HIGH>; > + }; -> + button at 2{ +> + button@2{ > + label = "Power push button"; > + linux,code = <KEY_SLEEP>; > + gpios = <&gpio0 26 GPIO_ACTIVE_LOW>; @@ -222,7 +222,7 @@ Add a blank line between nodes. > + pinctrl-0 = <&pmx_power_sata0 &pmx_power_sata1>; > + pinctrl-names = "default"; > + -> + sata0_power: regulator at 1 { +> + sata0_power: regulator@1 { > + compatible = "regulator-fixed"; > + reg = <1>; > + regulator-name = "SATA0 Power"; @@ -238,7 +238,7 @@ Also, gpio property could use GPIO_ACTIVE_HIGH/LOW here too. > + }; > + -> + sata1_power: regulator at 2 { +> + sata1_power: regulator@2 { > + compatible = "regulator-fixed"; > + reg = <2>; > + regulator-name = "SATA1 Power"; @@ -261,7 +261,7 @@ ditto. > + > +&mdio { > + status = "okay"; -> + ethphy0: ethernet-phy at 8 { +> + ethphy0: ethernet-phy@8 { > + reg = <8>; > + }; @@ -271,7 +271,7 @@ Remove extra space before brace. > + > +ð0 { > + status = "okay"; -> + ethernet0-port at 0 { +> + ethernet0-port@0 { > + phy-handle = <ðphy0>; > + }; > +}; diff --git a/a/content_digest b/N2/content_digest index b189121..759195c 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,9 +1,16 @@ "ref\020141215203855.GA28940@anne\0" "ref\020141222125750.GA29163@anne\0" - "From\0sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)\0" - "Subject\0[PATCH v3 1/1] add support for Seagate BlackArmor NAS220\0" + "From\0Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>\0" + "Subject\0Re: [PATCH v3 1/1] add support for Seagate BlackArmor NAS220\0" "Date\0Thu, 25 Dec 2014 14:08:12 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Evgeni Dobrev <evgeni@studio-punkt.com>" + " devicetree@vger.kernel.org\0" + "Cc\0linux-kernel@vger.kernel.org" + linux-arm-kernel@lists.infradead.org + Jason Cooper <jason@lakedaemon.net> + Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com> + Gregory Clement <gregory.clement@free-electrons.com> + " Andrew Lunn <andrew@lunn.ch>\0" "\00:1\0" "b\0" "On 22.12.2014 13:57, Evgeni Dobrev wrote:\n" @@ -95,8 +102,8 @@ "> +\t\tstdout-path = &uart0;\n" "> +\t};\n" "> +\n" - "> +\tocp at f1000000 {\n" - "> +\t\tpinctrl: pin-controller at 10000 {\n" + "> +\tocp@f1000000 {\n" + "> +\t\tpinctrl: pin-controller@10000 {\n" "\n" "v3.19 should already have a label for the common pinctrl node.\n" "Please do not replay the bus structure but use a node reference\n" @@ -151,7 +158,7 @@ "Nice! Can you also clarify if TX/RX are as seen from the SoC or\n" "remote end?\n" "\n" - "> +\t\tserial at 12000 {\n" + "> +\t\tserial@12000 {\n" "\n" "Please use node references where possible, IIRC v3.19 should have\n" "labels for serial, sata, and i2c. Avoid to replay the bus structure.\n" @@ -159,7 +166,7 @@ "> +\t\t\tstatus = \"okay\";\n" "> +\t\t};\n" "> +\n" - "> +\t\tsata at 80000 {\n" + "> +\t\tsata@80000 {\n" "> +\t\t\tstatus = \"okay\";\n" "> +\t\t\tnr-ports = <2>;\n" "\n" @@ -169,14 +176,14 @@ "\n" "> +\t\t};\n" "> +\n" - "> +\t\ti2c at 11000 {\n" + "> +\t\ti2c@11000 {\n" "> +\t\t\tstatus = \"okay\";\n" - "> +\t\t\tadt7476: adt7476a at 2e {\n" + "> +\t\t\tadt7476: adt7476a@2e {\n" "\n" "I know we have a lot of bad examples, but: node names should reflect\n" "device function, not device name, i.e.\n" "\n" - "adt7476: thermal at 2e {\n" + "adt7476: thermal@2e {\n" "\t...\n" "};\n" "\n" @@ -196,7 +203,7 @@ "\n" "Add a blank line between nodes.\n" "\n" - "> +\t\tbutton at 1{\n" + "> +\t\tbutton@1{\n" "> +\t\t\tlabel = \"Reset push button\";\n" "\n" "Reduce label to \"Reset\" and \"Power\" below.\n" @@ -204,7 +211,7 @@ "> +\t\t\tlinux,code = <KEY_POWER>;\n" "> +\t\t\tgpios = <&gpio0 29 GPIO_ACTIVE_HIGH>;\n" "> +\t\t};\n" - "> +\t\tbutton at 2{\n" + "> +\t\tbutton@2{\n" "> +\t\t\tlabel = \"Power push button\";\n" "> +\t\t\tlinux,code = <KEY_SLEEP>;\n" "> +\t\t\tgpios = <&gpio0 26 GPIO_ACTIVE_LOW>;\n" @@ -230,7 +237,7 @@ "> +\t\tpinctrl-0 = <&pmx_power_sata0 &pmx_power_sata1>;\n" "> +\t\tpinctrl-names = \"default\";\n" "> +\n" - "> +\t\tsata0_power: regulator at 1 {\n" + "> +\t\tsata0_power: regulator@1 {\n" "> +\t\t\tcompatible = \"regulator-fixed\";\n" "> +\t\t\treg = <1>;\n" "> +\t\t\tregulator-name = \"SATA0 Power\";\n" @@ -246,7 +253,7 @@ "\n" "> +\t\t};\n" "> +\n" - "> +\t\tsata1_power: regulator at 2 {\n" + "> +\t\tsata1_power: regulator@2 {\n" "> +\t\t\tcompatible = \"regulator-fixed\";\n" "> +\t\t\treg = <2>;\n" "> +\t\t\tregulator-name = \"SATA1 Power\";\n" @@ -269,7 +276,7 @@ "> +\n" "> +&mdio {\n" "> +\tstatus = \"okay\";\n" - "> +\tethphy0: ethernet-phy at 8 {\n" + "> +\tethphy0: ethernet-phy@8 {\n" "> +\t\t reg = <8>;\n" "> +\t };\n" "\n" @@ -279,7 +286,7 @@ "> +\n" "> +ð0 {\n" "> +\tstatus = \"okay\";\n" - "> +\tethernet0-port at 0 {\n" + "> +\tethernet0-port@0 {\n" "> +\t\tphy-handle = <ðphy0>;\n" "> +\t};\n" "> +};\n" @@ -291,4 +298,4 @@ "\n" Thanks! -41e37486deb83fcd96054e8f2acd6578f38ac83043689d4eb1b9647c0917c297 +b1fdc041def4a43da7d3ce69ddbc6f87c779383ebcadc8ba506a29df56f2afaa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.