From: Jonathan Cameron <jic23@kernel.org>
To: Karol Wrona <k.wrona@samsung.com>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Karol Wrona <wrona.vy@gmail.com>
Subject: Re: [PATCH v2 3/3] iio: core: Get rid of misleading comment
Date: Fri, 26 Dec 2014 11:41:39 +0000 [thread overview]
Message-ID: <549D4973.5020700@kernel.org> (raw)
In-Reply-To: <1419010766-13557-4-git-send-email-k.wrona@samsung.com>
On 19/12/14 17:39, Karol Wrona wrote:
> This comment did not fit here. It explains why devm_kmalloc
> uses dr_alloc. Generally is not needed at all.
>
A classic bit of cut and paste I guess. Anyhow, applied.
Jonathan
> Signed-off-by: Karol Wrona <k.wrona@samsung.com>
> ---
> drivers/iio/industrialio-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index af3e76d..1d030ae 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -1035,7 +1035,6 @@ struct iio_dev *devm_iio_device_alloc(struct device *dev, int sizeof_priv)
> if (!ptr)
> return NULL;
>
> - /* use raw alloc_dr for kmalloc caller tracing */
> iio_dev = iio_device_alloc(sizeof_priv);
> if (iio_dev) {
> *ptr = iio_dev;
>
prev parent reply other threads:[~2014-12-26 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 17:39 [PATCH v2 0/3] iio: Add resource management kfifo alloc/free Karol Wrona
2014-12-19 17:39 ` [PATCH v2 1/3] iio: kfifo: Remove unused argument in iio_kfifo_allocate Karol Wrona
2014-12-26 11:35 ` Jonathan Cameron
2014-12-19 17:39 ` [PATCH v2 2/3] iio: kfifo: Add resource management devm_iio_kfifo_allocate/free Karol Wrona
2014-12-26 11:40 ` Jonathan Cameron
2014-12-19 17:39 ` [PATCH v2 3/3] iio: core: Get rid of misleading comment Karol Wrona
2014-12-26 11:41 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549D4973.5020700@kernel.org \
--to=jic23@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=k.wrona@samsung.com \
--cc=knaack.h@gmx.de \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=wrona.vy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.