From: Jonathan Cameron <jic23@kernel.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-iio@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH 2/3] iio: imu: inv_mpu6050: Added adapter class
Date: Fri, 26 Dec 2014 12:37:36 +0000 [thread overview]
Message-ID: <549D5690.1070104@kernel.org> (raw)
In-Reply-To: <1418678363-22437-3-git-send-email-srinivas.pandruvada@linux.intel.com>
On 15/12/14 21:19, Srinivas Pandruvada wrote:
> To use i2c auto detect to work we need to have a non zero class.
> The closest class is I2C_CLASS_HWMON, as it defined to be used
> with all hw monitoring drivers.
>
> Also this class is already used by some iio driver, hid drivers, led
> and misc drivers. So this is not new that this is used outside
> hwmon drivers.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Been meaning to sort this out for a while. We really shouldn't be camping
on the HWMON class (nor should anyone else).
Wolfram, do you mind new classes being added?
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index f73e60b..4af2d24 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -813,7 +813,7 @@ static int inv_mpu_probe(struct i2c_client *client,
> st->mux_adapter = i2c_add_mux_adapter(client->adapter,
> &client->dev,
> indio_dev,
> - 0, 0, 0,
> + 0, 0, I2C_CLASS_HWMON,
> inv_mpu6050_select_bypass,
> inv_mpu6050_deselect_bypass);
> if (!st->mux_adapter) {
>
next prev parent reply other threads:[~2014-12-26 12:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 21:19 [PATCH 0/3] Enable AK8963 conneted via INV6500 Srinivas Pandruvada
2014-12-15 21:19 ` [PATCH 1/3] iio: imu: inv_mpu6050: ACPI enumeration Srinivas Pandruvada
2014-12-26 12:39 ` Jonathan Cameron
2014-12-15 21:19 ` [PATCH 2/3] iio: imu: inv_mpu6050: Added adapter class Srinivas Pandruvada
2014-12-26 12:37 ` Jonathan Cameron [this message]
2014-12-31 10:25 ` Wolfram Sang
2015-01-01 12:27 ` Jonathan Cameron
2015-01-04 19:20 ` Jean Delvare
2014-12-15 21:19 ` [PATCH 3/3] iio: ak8975: Added autodetect feature for ACPI Srinivas Pandruvada
[not found] ` <1418678363-22437-4-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-12-18 16:28 ` Lars-Peter Clausen
2014-12-18 16:28 ` Lars-Peter Clausen
[not found] ` <549300A5.5080904-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-12-18 16:52 ` Srinivas Pandruvada
2014-12-18 16:52 ` Srinivas Pandruvada
[not found] ` <1418921521.740.282.camel-hINH/TbAiWppyMZ9rn1DP+ejPoqOX1/hEvhb3Hwu1Ks@public.gmane.org>
2014-12-18 17:05 ` Lars-Peter Clausen
2014-12-18 17:05 ` Lars-Peter Clausen
[not found] ` <54930965.3030008-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-12-18 17:30 ` Srinivas Pandruvada
2014-12-18 17:30 ` Srinivas Pandruvada
[not found] ` <1418923812.4459.8.camel-hINH/TbAiWppyMZ9rn1DP+ejPoqOX1/hEvhb3Hwu1Ks@public.gmane.org>
2014-12-18 17:54 ` Lars-Peter Clausen
2014-12-18 17:54 ` Lars-Peter Clausen
[not found] ` <549314C4.8090001-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2014-12-18 18:00 ` Srinivas Pandruvada
2014-12-18 18:00 ` Srinivas Pandruvada
[not found] ` <1418925641.4459.11.camel-hINH/TbAiWppyMZ9rn1DP+ejPoqOX1/hEvhb3Hwu1Ks@public.gmane.org>
2014-12-26 11:53 ` Jonathan Cameron
2014-12-26 11:53 ` Jonathan Cameron
[not found] ` <549D4C1F.6050907-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-01-08 16:40 ` Wolfram Sang
2015-01-08 16:40 ` Wolfram Sang
2015-01-08 16:54 ` Srinivas Pandruvada
2015-01-08 16:54 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549D5690.1070104@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.