[PATCH] arch: mips: fw: arc: file.c: Remove some unused functions

[PATCH] arch: mips: fw: arc: file.c: Remove some unused functions

[Rickard Strandqvist]

Removes some functions that are not used anywhere:
ArcSetFileInformation() ArcGetFileInformation() ArcSeek()
ArcGetReadStatus() ArcClose() ArcOpen() ArcGetDirectoryEntry()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 arch/mips/fw/arc/file.c |   43 -------------------------------------------
 1 file changed, 43 deletions(-)

diff --git a/arch/mips/fw/arc/file.c b/arch/mips/fw/arc/file.c
index 49fd3ff..ebd69de 100644
--- a/arch/mips/fw/arc/file.c
+++ b/arch/mips/fw/arc/file.c
@@ -13,62 +13,19 @@
 #include <asm/sgialib.h>
 
 LONG
-ArcGetDirectoryEntry(ULONG FileID, struct linux_vdirent *Buffer,
-		     ULONG N, ULONG *Count)
-{
-	return ARC_CALL4(get_vdirent, FileID, Buffer, N, Count);
-}
-
-LONG
-ArcOpen(CHAR *Path, enum linux_omode OpenMode, ULONG *FileID)
-{
-	return ARC_CALL3(open, Path, OpenMode, FileID);
-}
-
-LONG
-ArcClose(ULONG FileID)
-{
-	return ARC_CALL1(close, FileID);
-}
-
-LONG
 ArcRead(ULONG FileID, VOID *Buffer, ULONG N, ULONG *Count)
 {
 	return ARC_CALL4(read, FileID, Buffer, N, Count);
 }
 
 LONG
-ArcGetReadStatus(ULONG FileID)
-{
-	return ARC_CALL1(get_rstatus, FileID);
-}
-
-LONG
 ArcWrite(ULONG FileID, PVOID Buffer, ULONG N, PULONG Count)
 {
 	return ARC_CALL4(write, FileID, Buffer, N, Count);
 }
 
 LONG
-ArcSeek(ULONG FileID, struct linux_bigint *Position, enum linux_seekmode SeekMode)
-{
-	return ARC_CALL3(seek, FileID, Position, SeekMode);
-}
-
-LONG
 ArcMount(char *name, enum linux_mountops op)
 {
 	return ARC_CALL2(mount, name, op);
 }
-
-LONG
-ArcGetFileInformation(ULONG FileID, struct linux_finfo *Information)
-{
-	return ARC_CALL2(get_finfo, FileID, Information);
-}
-
-LONG ArcSetFileInformation(ULONG FileID, ULONG AttributeFlags,
-			   ULONG AttributeMask)
-{
-	return ARC_CALL3(set_finfo, FileID, AttributeFlags, AttributeMask);
-}
-- 
1.7.10.4

Re: [PATCH] arch: mips: fw: arc: file.c: Remove some unused functions

[Joshua Kinard]

On 12/21/2014 12:16, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> ArcSetFileInformation() ArcGetFileInformation() ArcSeek()
> ArcGetReadStatus() ArcClose() ArcOpen() ArcGetDirectoryEntry()
> 
> This was partially found by using a static code analysis program called cppcheck.

A lot of these functions are for the ARCS PROM used in SGI systems.  They might
be unused functionally, but probably provide some kind of documentation on
known ARCS internals.  Or maybe, one day, they'll have a purpose if we ever try
to utilize ARCS for other things.

--J



> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  arch/mips/fw/arc/file.c |   43 -------------------------------------------
>  1 file changed, 43 deletions(-)
> 
> diff --git a/arch/mips/fw/arc/file.c b/arch/mips/fw/arc/file.c
> index 49fd3ff..ebd69de 100644
> --- a/arch/mips/fw/arc/file.c
> +++ b/arch/mips/fw/arc/file.c
> @@ -13,62 +13,19 @@
>  #include <asm/sgialib.h>
>  
>  LONG
> -ArcGetDirectoryEntry(ULONG FileID, struct linux_vdirent *Buffer,
> -		     ULONG N, ULONG *Count)
> -{
> -	return ARC_CALL4(get_vdirent, FileID, Buffer, N, Count);
> -}
> -
> -LONG
> -ArcOpen(CHAR *Path, enum linux_omode OpenMode, ULONG *FileID)
> -{
> -	return ARC_CALL3(open, Path, OpenMode, FileID);
> -}
> -
> -LONG
> -ArcClose(ULONG FileID)
> -{
> -	return ARC_CALL1(close, FileID);
> -}
> -
> -LONG
>  ArcRead(ULONG FileID, VOID *Buffer, ULONG N, ULONG *Count)
>  {
>  	return ARC_CALL4(read, FileID, Buffer, N, Count);
>  }
>  
>  LONG
> -ArcGetReadStatus(ULONG FileID)
> -{
> -	return ARC_CALL1(get_rstatus, FileID);
> -}
> -
> -LONG
>  ArcWrite(ULONG FileID, PVOID Buffer, ULONG N, PULONG Count)
>  {
>  	return ARC_CALL4(write, FileID, Buffer, N, Count);
>  }
>  
>  LONG
> -ArcSeek(ULONG FileID, struct linux_bigint *Position, enum linux_seekmode SeekMode)
> -{
> -	return ARC_CALL3(seek, FileID, Position, SeekMode);
> -}
> -
> -LONG
>  ArcMount(char *name, enum linux_mountops op)
>  {
>  	return ARC_CALL2(mount, name, op);
>  }
> -
> -LONG
> -ArcGetFileInformation(ULONG FileID, struct linux_finfo *Information)
> -{
> -	return ARC_CALL2(get_finfo, FileID, Information);
> -}
> -
> -LONG ArcSetFileInformation(ULONG FileID, ULONG AttributeFlags,
> -			   ULONG AttributeMask)
> -{
> -	return ARC_CALL3(set_finfo, FileID, AttributeFlags, AttributeMask);
> -}
> 


-- 
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org
4096R/D25D95E3 2011-03-28

"The past tempts us, the present confuses us, the future frightens us.  And our
lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic