From: Guillaume Gardet <guillaume.gardet@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: mmc: Fix raw boot mode (related to commit 4c5bbc2328a24f5e1ee990c9a9527e48e5fb3b5f)
Date: Sat, 27 Dec 2014 10:53:03 +0100 [thread overview]
Message-ID: <549E817F.5000001@free.fr> (raw)
In-Reply-To: <1418727644-12897-1-git-send-email-guillaume.gardet@free.fr>
Ping.
This patch is needed for the release. Otherwise, raw boot mode is broken if FAT/SPL support is also enabled.
Guillaume
Le 16/12/2014 12:00, Guillaume GARDET a ?crit :
> As reported by Robert Nelson, commit 4c5bbc2328a24f5e1ee990c9a9527e48e5fb3b5f
> may break MMC RAW boot mode.
> This patch fixes the check path to fix MMC Raw boot mode.
>
> Tested raw boot mode and FS boot mode on a pandaboard (rev. A3).
>
> Reported-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>
> Cc: Tom Rini <trini@ti.com>
> Cc: Robert Nelson <robertcnelson@gmail.com>
>
> ---
> common/spl/spl_mmc.c | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c
> index 7bae16b..c2e596b 100644
> --- a/common/spl/spl_mmc.c
> +++ b/common/spl/spl_mmc.c
> @@ -172,11 +172,24 @@ void spl_mmc_load_image(void)
> err = mmc_load_image_raw_sector(mmc,
> CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR);
> #endif
> - } else {
> + }
> +
> + switch(boot_mode){
> + case MMCSD_MODE_RAW:
> +#if defined(CONFIG_SPL_FAT_SUPPORT) || defined(CONFIG_SPL_EXT_SUPPORT)
> + case MMCSD_MODE_FS:
> +#endif
> +#ifdef CONFIG_SUPPORT_EMMC_BOOT
> + case MMCSD_MODE_EMMCBOOT:
> +#endif
> + /* Boot mode is ok. Nothing to do. */
> + break;
> + case MMCSD_MODE_UNDEFINED:
> + default:
> #ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
> - puts("spl: wrong MMC boot mode\n");
> + puts("spl: wrong MMC boot mode\n");
> #endif
> - hang();
> + hang();
> }
>
> if (err)
next prev parent reply other threads:[~2014-12-27 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 11:00 [U-Boot] [PATCH] spl: mmc: Fix raw boot mode (related to commit 4c5bbc2328a24f5e1ee990c9a9527e48e5fb3b5f) Guillaume GARDET
2014-12-16 17:16 ` Robert Nelson
2014-12-16 17:43 ` Guillaume Gardet
2014-12-16 20:52 ` Robert Nelson
2014-12-27 9:53 ` Guillaume Gardet [this message]
2015-01-05 18:49 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549E817F.5000001@free.fr \
--to=guillaume.gardet@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.