From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Y5Vok-00033V-RV
	for qemu-devel@nongnu.org; Mon, 29 Dec 2014 03:36:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Y5Vof-00083n-RU
	for qemu-devel@nongnu.org; Mon, 29 Dec 2014 03:36:46 -0500
Received: from mail-r83.rz.uni-mannheim.de ([134.155.96.83]:39469)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Y5Vof-00083h-L3
	for qemu-devel@nongnu.org; Mon, 29 Dec 2014 03:36:41 -0500
Message-ID: <54A11297.5070909@weilnetz.de>
Date: Mon, 29 Dec 2014 09:36:39 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1419373100-17690-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1419373100-17690-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] s390: fix clang warnings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Alexander Graf <agraf@suse.de>, Richard Henderson <rth@twiddle.net>

Am 23.12.2014 um 23:18 schrieb Peter Maydell:
> These two patches fix warnings generated by clang; I'm hoping we can
> clear up the handful of remaining clang warnings so I can turn on
> warnings-as-errors for my builds I do before applying pullreqs, and
> then we can keep the clang builds warning-free.
> 
> For the disassembler code, I opted to simply delete the unused
> data tables. The other thing we've done in some of the disassemblers
> is to just #if-0 out the code, but that's mostly been where it's
> something we might use in future, and I think this table is for
> the benefit of the assembler, not the disassembler.
> 
> Peter Maydell (2):
>   target-s390x: Mark op_csp() as !CONFIG_USER_ONLY
>   disas/s390.c: Remove unused variables
> 
>  disas/s390.c             | 35 -----------------------------------
>  target-s390x/translate.c |  2 ++
>  2 files changed, 2 insertions(+), 35 deletions(-)


In the subject line and in the commit message of patch 1 'op_csp' should
be replaced by 'check_privileged'. Then for both patches you may add

Reviewed-by: Stefan Weil <sw@weilnetz.de>