All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@amd.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Andrew.Lewycky@amd.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, alexander.deucher@amd.com
Subject: Re: [PATCH] amdkfd: actually allocate longs for the pasid bitmask
Date: Mon, 29 Dec 2014 10:51:28 +0200	[thread overview]
Message-ID: <54A11610.901@amd.com> (raw)
In-Reply-To: <1419785077-25800-1-git-send-email-sasha.levin@oracle.com>



On 12/28/2014 06:44 PM, Sasha Levin wrote:
> Commit "amdkfd: use sizeof(long) granularity for the pasid bitmask" calculated
> the number of longs it will need, but ended up allocating that number of
> bytes rather than longs.
>
> Fix that silly error and allocate the amount of data really required.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_pasid.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> index 71699ad..4c25ef5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> @@ -32,7 +32,7 @@ int kfd_pasid_init(void)
>   {
>   	pasid_limit = max_num_of_processes;
>
> -	pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL);
> +	pasid_bitmap = kcalloc(BITS_TO_LONGS(pasid_limit), sizeof(long), GFP_KERNEL);
>   	if (!pasid_bitmap)
>   		return -ENOMEM;
>
>
Thanks!
Applied to my amdkfd-fixes tree.

	Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Oded Gabbay <oded.gabbay@amd.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: <airlied@linux.ie>, <alexander.deucher@amd.com>,
	<j.glisse@gmail.com>, <linux-kernel@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>, <John.Bridgman@amd.com>,
	<Andrew.Lewycky@amd.com>, <joro@8bytes.org>
Subject: Re: [PATCH] amdkfd: actually allocate longs for the pasid bitmask
Date: Mon, 29 Dec 2014 10:51:28 +0200	[thread overview]
Message-ID: <54A11610.901@amd.com> (raw)
In-Reply-To: <1419785077-25800-1-git-send-email-sasha.levin@oracle.com>



On 12/28/2014 06:44 PM, Sasha Levin wrote:
> Commit "amdkfd: use sizeof(long) granularity for the pasid bitmask" calculated
> the number of longs it will need, but ended up allocating that number of
> bytes rather than longs.
>
> Fix that silly error and allocate the amount of data really required.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_pasid.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> index 71699ad..4c25ef5 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c
> @@ -32,7 +32,7 @@ int kfd_pasid_init(void)
>   {
>   	pasid_limit = max_num_of_processes;
>
> -	pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL);
> +	pasid_bitmap = kcalloc(BITS_TO_LONGS(pasid_limit), sizeof(long), GFP_KERNEL);
>   	if (!pasid_bitmap)
>   		return -ENOMEM;
>
>
Thanks!
Applied to my amdkfd-fixes tree.

	Oded

  reply	other threads:[~2014-12-29  8:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-28 16:44 [PATCH] amdkfd: actually allocate longs for the pasid bitmask Sasha Levin
2014-12-29  8:51 ` Oded Gabbay [this message]
2014-12-29  8:51   ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A11610.901@amd.com \
    --to=oded.gabbay@amd.com \
    --cc=Andrew.Lewycky@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.