From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [PATCH] amdkfd: actually allocate longs for the pasid bitmask Date: Mon, 29 Dec 2014 10:51:28 +0200 Message-ID: <54A11610.901@amd.com> References: <1419785077-25800-1-git-send-email-sasha.levin@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0145.outbound.protection.outlook.com [65.55.169.145]) by gabe.freedesktop.org (Postfix) with ESMTP id D28D4898E1 for ; Mon, 29 Dec 2014 00:52:00 -0800 (PST) In-Reply-To: <1419785077-25800-1-git-send-email-sasha.levin@oracle.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sasha Levin Cc: Andrew.Lewycky@amd.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com List-Id: dri-devel@lists.freedesktop.org CgpPbiAxMi8yOC8yMDE0IDA2OjQ0IFBNLCBTYXNoYSBMZXZpbiB3cm90ZToKPiBDb21taXQgImFt ZGtmZDogdXNlIHNpemVvZihsb25nKSBncmFudWxhcml0eSBmb3IgdGhlIHBhc2lkIGJpdG1hc2si IGNhbGN1bGF0ZWQKPiB0aGUgbnVtYmVyIG9mIGxvbmdzIGl0IHdpbGwgbmVlZCwgYnV0IGVuZGVk IHVwIGFsbG9jYXRpbmcgdGhhdCBudW1iZXIgb2YKPiBieXRlcyByYXRoZXIgdGhhbiBsb25ncy4K Pgo+IEZpeCB0aGF0IHNpbGx5IGVycm9yIGFuZCBhbGxvY2F0ZSB0aGUgYW1vdW50IG9mIGRhdGEg cmVhbGx5IHJlcXVpcmVkLgo+Cj4gU2lnbmVkLW9mZi1ieTogU2FzaGEgTGV2aW4gPHNhc2hhLmxl dmluQG9yYWNsZS5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRf cGFzaWQuYyB8ICAgIDIgKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBk ZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tm ZF9wYXNpZC5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Bhc2lkLmMKPiBpbmRl eCA3MTY5OWFkLi40YzI1ZWY1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k a2ZkL2tmZF9wYXNpZC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX3Bh c2lkLmMKPiBAQCAtMzIsNyArMzIsNyBAQCBpbnQga2ZkX3Bhc2lkX2luaXQodm9pZCkKPiAgIHsK PiAgIAlwYXNpZF9saW1pdCA9IG1heF9udW1fb2ZfcHJvY2Vzc2VzOwo+Cj4gLQlwYXNpZF9iaXRt YXAgPSBremFsbG9jKEJJVFNfVE9fTE9OR1MocGFzaWRfbGltaXQpLCBHRlBfS0VSTkVMKTsKPiAr CXBhc2lkX2JpdG1hcCA9IGtjYWxsb2MoQklUU19UT19MT05HUyhwYXNpZF9saW1pdCksIHNpemVv Zihsb25nKSwgR0ZQX0tFUk5FTCk7Cj4gICAJaWYgKCFwYXNpZF9iaXRtYXApCj4gICAJCXJldHVy biAtRU5PTUVNOwo+Cj4KVGhhbmtzIQpBcHBsaWVkIHRvIG15IGFtZGtmZC1maXhlcyB0cmVlLgoK CU9kZWQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbaL2IwF (ORCPT ); Mon, 29 Dec 2014 03:52:05 -0500 Received: from mail-bl2on0120.outbound.protection.outlook.com ([65.55.169.120]:26954 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751685AbaL2IwB (ORCPT ); Mon, 29 Dec 2014 03:52:01 -0500 X-WSS-ID: 0NHC5YK-07-D3Z-02 X-M-MSG: Message-ID: <54A11610.901@amd.com> Date: Mon, 29 Dec 2014 10:51:28 +0200 From: Oded Gabbay Organization: AMD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sasha Levin CC: , , , , , , , Subject: Re: [PATCH] amdkfd: actually allocate longs for the pasid bitmask References: <1419785077-25800-1-git-send-email-sasha.levin@oracle.com> In-Reply-To: <1419785077-25800-1-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.20.0.84] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Oded.Gabbay@amd.com; X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(377454003)(189002)(51704005)(24454002)(199003)(479174004)(83506001)(107046002)(86362001)(87936001)(46102003)(84676001)(47776003)(31966008)(33656002)(21056001)(92566001)(110136001)(120916001)(20776003)(64126003)(50466002)(50986999)(76176999)(54356999)(65816999)(77096005)(64706001)(23676002)(65806001)(97736003)(4396001)(99396003)(19580405001)(106466001)(77156002)(68736005)(101416001)(62966003)(36756003)(19580395003)(2950100001);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR02MB194;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-DmarcAction: None X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(3005003);SRVR:BLUPR02MB194; X-Forefront-PRVS: 0440AC9990 X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Dec 2014 08:51:57.0175 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB194 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/28/2014 06:44 PM, Sasha Levin wrote: > Commit "amdkfd: use sizeof(long) granularity for the pasid bitmask" calculated > the number of longs it will need, but ended up allocating that number of > bytes rather than longs. > > Fix that silly error and allocate the amount of data really required. > > Signed-off-by: Sasha Levin > --- > drivers/gpu/drm/amd/amdkfd/kfd_pasid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c > index 71699ad..4c25ef5 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_pasid.c > @@ -32,7 +32,7 @@ int kfd_pasid_init(void) > { > pasid_limit = max_num_of_processes; > > - pasid_bitmap = kzalloc(BITS_TO_LONGS(pasid_limit), GFP_KERNEL); > + pasid_bitmap = kcalloc(BITS_TO_LONGS(pasid_limit), sizeof(long), GFP_KERNEL); > if (!pasid_bitmap) > return -ENOMEM; > > Thanks! Applied to my amdkfd-fixes tree. Oded