From mboxrd@z Thu Jan  1 00:00:00 1970
From: a.hajda@samsung.com (Andrzej Hajda)
Date: Mon, 29 Dec 2014 11:50:35 +0100
Subject: [PATCH RFC v6 16/21] drm: panel: Add support for Himax HX8369A
 MIPI DSI panel
In-Reply-To: <54A127D2.7080904@freescale.com>
References: <1419835168-9034-1-git-send-email-Ying.Liu@freescale.com>
 <1419835168-9034-17-git-send-email-Ying.Liu@freescale.com>
 <54A11A65.1040509@samsung.com> <54A127D2.7080904@freescale.com>
Message-ID: <54A131FB.8040809@samsung.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 12/29/2014 11:07 AM, Liu Ying wrote:
> On 12/29/2014 05:09 PM, Andrzej Hajda wrote:
>> On 12/29/2014 07:39 AM, Liu Ying wrote:
>>> This patch adds support for Himax HX8369A MIPI DSI panel.
>>>
>>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>>> ---
>>> v5->v6:
>>>   * Make the checkpatch.pl script be happier.
>>>   * Do not set the dsi channel number to be zero in probe(), because the MIPI DSI
>>>     bus driver would set it.
>>>
>>> v4->v5:
>>>   * Address Andrzej Hajda's comments.
>>>   * Get the bs-gpios property instead of the bs[3:0]-gpios properties.
>>>   * Implement error propagation for panel register configurations.
>>>   * Other minor changes to improve the code quality.
>>>
>>> v3->v4:
>>>   * Move the relevant dt-bindings to a separate patch to address Stefan
>>>     Wahren's comment.
>>>
>>> v2->v3:
>>>   * Sort the included header files alphabetically.
>>>
>>> v1->v2:
>>>   * Address almost all comments from Thierry Reding.
>>>   * Remove several DT properties as they can be implied by the compatible string.
>>>   * Add the HIMAX/himax prefixes to the driver's Kconfig name and driver name.
>>>   * Move the driver's Makefile entry place to sort the entries alphabetically.
>>>   * Reuse several standard DCS functions instead of inventing wheels.
>>>   * Move the panel resetting and power logics to the driver probe/remove stages.
>>>     This may simplify panel prepare/unprepare hooks. The power consumption should
>>>     not change a lot at DPMS since the panel enters sleep mode at that time.
>>>   * Add the module author.
>>>   * Other minor changes, such as coding style issues.
>>>
>>>   drivers/gpu/drm/panel/Kconfig               |   5 +
>>>   drivers/gpu/drm/panel/Makefile              |   1 +
>>>   drivers/gpu/drm/panel/panel-himax-hx8369a.c | 614 ++++++++++++++++++++++++++++
>>>   3 files changed, 620 insertions(+)
>>>   create mode 100644 drivers/gpu/drm/panel/panel-himax-hx8369a.c
>>>
>>> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
>>> index 024e98e..81b0bf0 100644
>>> --- a/drivers/gpu/drm/panel/Kconfig
>>> +++ b/drivers/gpu/drm/panel/Kconfig
>>> @@ -16,6 +16,11 @@ config DRM_PANEL_SIMPLE
>>>   	  that it can be automatically turned off when the panel goes into a
>>>   	  low power state.
>>>
>>> +config DRM_PANEL_HIMAX_HX8369A
>>> +	tristate "Himax HX8369A panel"
>>> +	depends on OF
>>> +	select DRM_MIPI_DSI
>>> +
>>>   config DRM_PANEL_LD9040
>>>   	tristate "LD9040 RGB/SPI panel"
>>>   	depends on OF && SPI
>>> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
>>> index 4b2a043..d5dbe06 100644
>>> --- a/drivers/gpu/drm/panel/Makefile
>>> +++ b/drivers/gpu/drm/panel/Makefile
>>> @@ -1,4 +1,5 @@
>>>   obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
>>> +obj-$(CONFIG_DRM_PANEL_HIMAX_HX8369A) += panel-himax-hx8369a.o
>>>   obj-$(CONFIG_DRM_PANEL_LD9040) += panel-ld9040.o
>>>   obj-$(CONFIG_DRM_PANEL_S6E8AA0) += panel-s6e8aa0.o
>>>   obj-$(CONFIG_DRM_PANEL_SHARP_LQ101R1SX01) += panel-sharp-lq101r1sx01.o
>>> diff --git a/drivers/gpu/drm/panel/panel-himax-hx8369a.c b/drivers/gpu/drm/panel/panel-himax-hx8369a.c
>>> new file mode 100644
>>> index 0000000..eee36a7
>>> --- /dev/null
>>> +++ b/drivers/gpu/drm/panel/panel-himax-hx8369a.c
>>> @@ -0,0 +1,614 @@
>>> +/*
>>> + * Himax HX8369A panel driver.
>>> + *
>>> + * Copyright (C) 2011-2014 Freescale Semiconductor, Inc.
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 as
>>> + * published by the Free Software Foundation.
>>> + *
>>> + * This driver is based on Samsung s6e8aa0 panel driver.
>>> + */
>>> +
>>> +#include <drm/drmP.h>
>>> +#include <drm/drm_mipi_dsi.h>
>>> +#include <drm/drm_panel.h>
>>> +
>>> +#include <linux/gpio/consumer.h>
>>> +#include <linux/of_device.h>
>>> +#include <linux/regulator/consumer.h>
>>> +
>>> +#include <video/mipi_display.h>
>>> +#include <video/of_videomode.h>
>>> +#include <video/videomode.h>
>>> +
>>> +#define WRDISBV		0x51
>>> +#define WRCTRLD		0x53
>>> +#define WRCABC		0x55
>>> +#define SETPOWER	0xb1
>>> +#define SETDISP		0xb2
>>> +#define SETCYC		0xb4
>>> +#define SETVCOM		0xb6
>>> +#define SETEXTC		0xb9
>>> +#define SETMIPI		0xba
>>> +#define SETPANEL	0xcc
>>> +#define SETGIP		0xd5
>>> +#define SETGAMMA	0xe0
>>> +
>>> +#define HX8369A_MIN_BRIGHTNESS	0x00
>>> +#define HX8369A_MAX_BRIGHTNESS	0xff
>>> +
>>> +enum hx8369a_mpu_interface {
>>> +	HX8369A_DBI_TYPE_A_8BIT,
>>> +	HX8369A_DBI_TYPE_A_9BIT,
>>> +	HX8369A_DBI_TYPE_A_16BIT,
>>> +	HX8369A_DBI_TYPE_A_18BIT,
>>> +	HX8369A_DBI_TYPE_B_8BIT,
>>> +	HX8369A_DBI_TYPE_B_9BIT,
>>> +	HX8369A_DBI_TYPE_B_16BIT,
>>> +	HX8369A_DBI_TYPE_B_18BIT,
>>> +	HX8369A_DSI_CMD_MODE,
>>> +	HX8369A_DBI_TYPE_B_24BIT,
>>> +	HX8369A_DSI_VIDEO_MODE,
>>> +	HX8369A_MDDI,
>>> +	HX8369A_DPI_DBI_TYPE_C_OPT1,
>>> +	HX8369A_DPI_DBI_TYPE_C_OPT2,
>>> +	HX8369A_DPI_DBI_TYPE_C_OPT3
>>> +};
>>> +
>>> +enum hx8369a_resolution {
>>> +	HX8369A_RES_480_864,
>>> +	HX8369A_RES_480_854,
>>> +	HX8369A_RES_480_800,
>>> +	HX8369A_RES_480_640,
>>> +	HX8369A_RES_360_640,
>>> +	HX8369A_RES_480_720,
>>> +};
>>> +
>>> +struct hx8369a_panel_desc {
>>> +	const struct drm_display_mode *mode;
>>> +
>>> +	/* ms */
>>> +	unsigned int power_on_delay;
>>> +	unsigned int reset_delay;
>>> +
>>> +	unsigned int dsi_lanes;
>>> +};
>>> +
>>> +struct hx8369a {
>>> +	struct device *dev;
>>> +	struct drm_panel panel;
>>> +
>>> +	const struct hx8369a_panel_desc *pd;
>>> +
>>> +	struct regulator_bulk_data supplies[5];
>>> +	struct gpio_desc *reset_gpio;
>>> +	struct gpio_desc *bs_gpio[4];
>>> +	u8 res_sel;
>>> +};
>>> +
>>> +static inline struct hx8369a *panel_to_hx8369a(struct drm_panel *panel)
>>> +{
>>> +	return container_of(panel, struct hx8369a, panel);
>>> +}
>>> +
>>> +static int hx8369a_dcs_write(struct hx8369a *ctx, const char *func,
>>> +			     const void *data, size_t len)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	ssize_t ret;
>>> +
>>> +	ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "%s failed: %d\n", func, ret);
>>> +		return ret;
>>> +	}
>>> +	return 0;
>> Nitpick. You can replace 4 lines above with:
>>      if (ret < 0)
>>          dev_err(ctx->dev, "%s failed: %d\n", func, ret);
>>      return ret;
> I'll do that.
>
>>> +}
>>> +
>>> +#define hx8369a_dcs_write_seq(ctx, seq...) \
>>> +({ \
>>> +	const u8 d[] = { seq }; \
>>> +	BUILD_BUG_ON_MSG(ARRAY_SIZE(d) > 64, \
>>> +			 "DCS sequence too big for stack"); \
>>> +	hx8369a_dcs_write(ctx, __func__, d, ARRAY_SIZE(d)); \
>>> +})
>>> +
>>> +#define hx8369a_dcs_write_seq_static(ctx, seq...) \
>>> +({ \
>>> +	static const u8 d[] = { seq }; \
>>> +	hx8369a_dcs_write(ctx, __func__, d, ARRAY_SIZE(d)); \
>>> +})
>>> +
>>> +static int hx8369a_dsi_set_display_related_register(struct hx8369a *ctx)
>>> +{
>>> +	u8 sec_p = (ctx->res_sel << 4) | 0x03;
>>> +
>>> +	return hx8369a_dcs_write_seq(ctx, SETDISP, 0x00, sec_p, 0x03,
>>> +			   0x03, 0x70, 0x00, 0xff, 0x00, 0x00, 0x00,
>>> +			   0x00, 0x03, 0x03, 0x00, 0x01);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_display_waveform_cycle(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETCYC, 0x00, 0x1d,
>>> +					0x5f, 0x0e, 0x06);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_gip(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETGIP, 0x00, 0x04,
>>> +				 0x03, 0x00, 0x01, 0x05, 0x1c, 0x70,
>>> +				 0x01, 0x03, 0x00, 0x00, 0x40, 0x06,
>>> +				 0x51, 0x07, 0x00, 0x00, 0x41, 0x06,
>>> +				 0x50, 0x07, 0x07, 0x0f, 0x04);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_power(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETPOWER, 0x01, 0x00,
>>> +				   0x34, 0x06, 0x00, 0x0f, 0x0f, 0x2a,
>>> +				   0x32, 0x3f, 0x3f, 0x07, 0x3a, 0x01,
>>> +				   0xe6, 0xe6, 0xe6, 0xe6, 0xe6);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_vcom_voltage(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETVCOM, 0x56, 0x56);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_panel(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETPANEL, 0x02);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_gamma_curve(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETGAMMA, 0x00, 0x1d,
>>> +				   0x22, 0x38, 0x3d, 0x3f, 0x2e, 0x4a,
>>> +				   0x06, 0x0d, 0x0f, 0x13, 0x15, 0x13,
>>> +				   0x16, 0x10, 0x19, 0x00, 0x1d, 0x22,
>>> +				   0x38, 0x3d, 0x3f, 0x2e, 0x4a, 0x06,
>>> +				   0x0d, 0x0f, 0x13, 0x15, 0x13, 0x16,
>>> +				   0x10, 0x19);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_mipi(struct hx8369a *ctx)
>>> +{
>>> +	u8 eleventh_p = ctx->pd->dsi_lanes == 2 ? 0x11 : 0x10;
>>> +
>>> +	return hx8369a_dcs_write_seq(ctx, SETMIPI, 0x00, 0xa0, 0xc6,
>>> +				 0x00, 0x0a, 0x00, 0x10, 0x30, 0x6f,
>>> +				 0x02, eleventh_p, 0x18, 0x40);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_interface_pixel_fomat(struct hx8369a *ctx)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	u8 format;
>>> +	int ret;
>>> +
>>> +	switch (dsi->format) {
>>> +	case MIPI_DSI_FMT_RGB888:
>>> +	case MIPI_DSI_FMT_RGB666:
>>> +		format = 0x77;
>>> +		break;
>>> +	case MIPI_DSI_FMT_RGB565:
>>> +		format = 0x55;
>>> +		break;
>>> +	case MIPI_DSI_FMT_RGB666_PACKED:
>>> +		format = 0x66;
>>> +		break;
>>> +	default:
>>> +		dev_err(ctx->dev, "unsupported DSI pixel format\n");
>>> +		return -EINVAL;
>>> +	}
>>> +
>>> +	ret = mipi_dsi_dcs_set_pixel_format(dsi, format);
>>> +	if (ret < 0)
>>> +		dev_err(ctx->dev, "%s failed: %d\n", __func__, ret);
>>> +	return ret;
>>> +}
>> This functions could be also DSI helper, it is not specific to this panel,
>> but it is just a suggestion.
> Any documentation can reflect this could be a common DSI helper,
> maybe the MIPI DSI spec?
> I wrote this function by taking the HX8369A panel data sheet as a
> reference.

MIPI DSI specification describes MIPI_DSI_FMT_* values and
MIPI DCS specification describes 'format' values (ie. 0x77, 0x55, 0x66).
For reference please look for phrase "Table 6 Interface Pixel Formats" in
MIPI DCS specification (or in google :) ).

>
>>> +
>>> +static int hx8369a_dsi_set_column_address(struct hx8369a *ctx)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	const struct drm_display_mode *mode = ctx->pd->mode;
>>> +	int ret;
>>> +
>>> +	ret = mipi_dsi_dcs_set_column_address(dsi, 0, mode->hdisplay - 1);
>>> +	if (ret < 0)
>>> +		dev_err(ctx->dev, "%s failed: %d\n", __func__, ret);
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_page_address(struct hx8369a *ctx)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	const struct drm_display_mode *mode = ctx->pd->mode;
>>> +	int ret;
>>> +
>>> +	ret = mipi_dsi_dcs_set_page_address(dsi, 0, mode->vdisplay - 1);
>>> +	if (ret < 0)
>>> +		dev_err(ctx->dev, "%s failed: %d\n", __func__, ret);
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_write_display_brightness(struct hx8369a *ctx,
>>> +						u8 brightness)
>>> +{
>>> +	return hx8369a_dcs_write_seq(ctx, WRDISBV, brightness);
>>> +}
>>> +
>>> +static int hx8369a_dsi_write_cabc(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, WRCABC, 0x01);
>>> +}
>>> +
>>> +static int hx8369a_dsi_write_control_display(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, WRCTRLD, 0x24);
>>> +}
>>> +
>>> +#define hx8369a_dsi_init_helper(ctx, ret, name) \
>>> +({ \
>>> +	ret = hx8369a_dsi_##name(ctx); \
>>> +	if (ret < 0) \
>>> +		return ret; \
>>> +})
>> Yeah, another hack to get rid of redundant code :)
>> Two ugly things here: ## and return from macro.
>>
>>> +
>>> +static int hx8369a_dsi_panel_init(struct hx8369a *ctx)
>>> +{
>>> +	int ret;
>>> +
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_display_related_register);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_display_waveform_cycle);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_gip);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_power);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_vcom_voltage);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_panel);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_gamma_curve);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_mipi);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_interface_pixel_fomat);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_column_address);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_page_address);
>>> +	hx8369a_dsi_init_helper(ctx, ret, write_cabc);
>>> +	hx8369a_dsi_init_helper(ctx, ret, write_control_display);
>> Maybe it would be better to replace the hack above with something like:
>> {
>>      int (*)(struct hx8369a *ctx) funcs[] = {
>>          hx8369a_dsi_set_display_related_register,
>>          hx8369a_dsi_set_display_waveform_cycle,
>>          ...
>>       };
>>      int ret, i;
>>
>>      for (i = 0; i < ARRAY_SIZE(funcs); ++i) {
>>          ret = funcs[i](ctx);
>>          if (ret)
>>              return ret;
>>      }
> I'll change to use this.  Thanks.
>
>>> +
>>> +	return 0;
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_extension_command(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETEXTC, 0xff, 0x83, 0x69);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_maximum_return_packet_size(struct hx8369a *ctx,
>>> +						      u16 size)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	int ret;
>>> +
>>> +	ret = mipi_dsi_set_maximum_return_packet_size(dsi, size);
>>> +	if (ret < 0)
>>> +		dev_err(ctx->dev,
>>> +			"error %d setting maximum return packet size to %d\n",
>>> +			ret, size);
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_sequence(struct hx8369a *ctx)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	int ret;
>>> +
>>> +	ret = hx8369a_dsi_set_extension_command(ctx);
>>> +	if (ret < 0)
>>> +		goto out;
>>> +
>>> +	ret = hx8369a_dsi_set_maximum_return_packet_size(ctx, 4);
>>> +	if (ret < 0)
>>> +		goto out;
>>> +
>>> +	ret = hx8369a_dsi_panel_init(ctx);
>>> +	if (ret < 0)
>>> +		goto out;
>>> +
>>> +	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "failed to exit sleep mode: %d\n", ret);
>>> +		goto out;
>>> +	}
>>> +
>>> +	ret = mipi_dsi_dcs_set_display_on(dsi);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "failed to set display on: %d\n", ret);
>>> +		goto out;
>>> +	}
>>> +
>>> +	/*
>>> +	 * It's necessary to wait 120msec after sending the Sleep Out
>>> +	 * command before Sleep In command can be sent, according to
>>> +	 * the HX8369A data sheet.
>>> +	 */
>>> +	msleep(120);
>>> +out:
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_disable(struct drm_panel *panel)
>>> +{
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +
>>> +	return hx8369a_dsi_write_display_brightness(ctx,
>>> +						HX8369A_MIN_BRIGHTNESS);
>>> +}
>>> +
>>> +static int hx8369a_dsi_unprepare(struct drm_panel *panel)
>>> +{
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	int ret;
>>> +
>>> +	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret);
>>> +		goto out;
>>> +	}
>>> +
>>> +	ret = mipi_dsi_dcs_set_display_off(dsi);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "failed to set display off: %d\n", ret);
>>> +		goto out;
>>> +	}
>>> +
>>> +	/*
>>> +	 * This is to allow time for the supply voltages and clock
>>> +	 * circuits to stablize, according to the HX8369A data sheet.
>>> +	 */
>>> +	msleep(5);
>>> +out:
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_prepare(struct drm_panel *panel)
>>> +{
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +
>>> +	return hx8369a_dsi_set_sequence(ctx);
>>> +}
>>> +
>>> +static int hx8369a_dsi_enable(struct drm_panel *panel)
>>> +{
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +
>>> +	return hx8369a_dsi_write_display_brightness(ctx,
>>> +						HX8369A_MAX_BRIGHTNESS);
>>> +}
>>> +
>>> +static int hx8369a_get_modes(struct drm_panel *panel)
>>> +{
>>> +	struct drm_connector *connector = panel->connector;
>>> +	struct drm_device *drm = panel->drm;
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +	struct drm_display_mode *mode;
>>> +	const struct drm_display_mode *m = ctx->pd->mode;
>>> +
>>> +	mode = drm_mode_duplicate(drm, m);
>>> +	if (!mode) {
>>> +		dev_err(drm->dev, "failed to add mode %ux%u@%u\n",
>>> +			m->hdisplay, m->vdisplay, m->vrefresh);
>>> +		return 0;
>>> +	}
>>> +
>>> +	drm_mode_set_name(mode);
>>> +	mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
>>> +
>>> +	connector->display_info.bpc = 8;
>>> +	connector->display_info.width_mm = mode->width_mm;
>>> +	connector->display_info.height_mm = mode->height_mm;
>>> +
>>> +	drm_mode_probed_add(connector, mode);
>>> +
>>> +	return 1;
>>> +}
>>> +
>>> +static const struct drm_panel_funcs hx8369a_dsi_drm_funcs = {
>>> +	.disable = hx8369a_dsi_disable,
>>> +	.unprepare = hx8369a_dsi_unprepare,
>>> +	.prepare = hx8369a_dsi_prepare,
>>> +	.enable = hx8369a_dsi_enable,
>>> +	.get_modes = hx8369a_get_modes,
>>> +};
>>> +
>>> +static int hx8369a_power_on(struct hx8369a *ctx)
>>> +{
>>> +	int ret;
>>> +
>>> +	ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
>>> +	if (ret < 0)
>>> +		return ret;
>>> +
>>> +	msleep(ctx->pd->power_on_delay);
>>> +
>>> +	gpiod_set_value(ctx->reset_gpio, 1);
>>> +	usleep_range(50, 60);
>>> +	gpiod_set_value(ctx->reset_gpio, 0);
>>> +
>>> +	msleep(ctx->pd->reset_delay);
>>> +
>>> +	return 0;
>>> +}
>>> +
>>> +static int hx8369a_power_off(struct hx8369a *ctx)
>>> +{
>>> +	return regulator_bulk_disable(ARRAY_SIZE(ctx->supplies),
>>> +				      ctx->supplies);
>>> +}
>>> +
>>> +static void hx8369a_vm_to_res_sel(struct hx8369a *ctx)
>>> +{
>>> +	const struct drm_display_mode *mode = ctx->pd->mode;
>>> +
>>> +	switch (mode->hdisplay) {
>>> +	case 480:
>>> +		switch (mode->vdisplay) {
>>> +		case 864:
>>> +			ctx->res_sel = HX8369A_RES_480_864;
>>> +			break;
>>> +		case 854:
>>> +			ctx->res_sel = HX8369A_RES_480_854;
>>> +			break;
>>> +		case 800:
>>> +			ctx->res_sel = HX8369A_RES_480_800;
>>> +			break;
>>> +		case 640:
>>> +			ctx->res_sel = HX8369A_RES_480_640;
>>> +			break;
>>> +		case 720:
>>> +			ctx->res_sel = HX8369A_RES_480_720;
>>> +			break;
>>> +		default:
>>> +			break;
>>> +		}
>>> +		break;
>>> +	case 360:
>>> +		if (mode->vdisplay == 640)
>>> +			ctx->res_sel = HX8369A_RES_360_640;
>>> +		break;
>>> +	default:
>>> +		break;
>>> +	}
>>> +}
>>> +
>>> +static const struct drm_display_mode truly_tft480800_16_e_mode = {
>>> +	.clock = 26400,
>>> +	.hdisplay = 480,
>>> +	.hsync_start = 480 + 8,
>>> +	.hsync_end = 480 + 8 + 8,
>>> +	.htotal = 480 + 8 + 8 + 8,
>>> +	.vdisplay = 800,
>>> +	.vsync_start = 800 + 6,
>>> +	.vsync_end = 800 + 6 + 6,
>>> +	.vtotal = 800 + 6 + 6 + 6,
>>> +	.vrefresh = 60,
>>> +	.width_mm = 45,
>>> +	.height_mm = 76,
>>> +};
>>> +
>>> +static const struct hx8369a_panel_desc truly_tft480800_16_e_dsi = {
>>> +	.mode = &truly_tft480800_16_e_mode,
>>> +	.power_on_delay = 10,
>>> +	.reset_delay = 10,
>>> +	.dsi_lanes = 2,
>>> +};
>>> +
>>> +static const struct of_device_id hx8369a_dsi_of_match[] = {
>>> +	{
>>> +		.compatible = "truly,tft480800-16-e-dsi",
>>> +		.data = &truly_tft480800_16_e_dsi,
>>> +	}, {
>>> +		/* sentinel */
>>> +	},
>>> +};
>>> +MODULE_DEVICE_TABLE(of, hx8369a_dsi_of_match);
>>> +
>>> +static int hx8369a_dsi_probe(struct mipi_dsi_device *dsi)
>>> +{
>>> +	struct device *dev = &dsi->dev;
>>> +	const struct of_device_id *of_id =
>>> +			of_match_device(hx8369a_dsi_of_match, dev);
>>> +	struct hx8369a *ctx;
>>> +	int ret, i;
>>> +
>>> +	ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
>>> +	if (!ctx)
>>> +		return -ENOMEM;
>>> +
>>> +	ctx->dev = dev;
>>> +
>>> +	if (of_id) {
>>> +		ctx->pd = of_id->data;
>>> +	} else {
>>> +		dev_err(dev, "cannot find compatible device\n");
>>> +		return -ENODEV;
>>> +	}
>>> +
>>> +	hx8369a_vm_to_res_sel(ctx);
>>> +
>>> +	ctx->supplies[0].supply = "vdd1";
>>> +	ctx->supplies[1].supply = "vdd2";
>>> +	ctx->supplies[2].supply = "vdd3";
>>> +	ctx->supplies[3].supply = "dsi-vcc";
>>> +	ctx->supplies[4].supply = "vpp";
>>> +	ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies),
>>> +				      ctx->supplies);
>>> +	if (ret < 0) {
>>> +		dev_info(dev, "failed to get regulators: %d\n", ret);
>>> +		return ret;
>>> +	}
>>> +
>>> +	ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>>> +	if (IS_ERR(ctx->reset_gpio)) {
>>> +		dev_info(dev, "cannot get reset-gpios %ld\n",
>>> +			 PTR_ERR(ctx->reset_gpio));
>>> +		return PTR_ERR(ctx->reset_gpio);
>>> +	}
>>> +
>>> +	for (i = 0; i < 4; i++) {
>>> +		ctx->bs_gpio[i] = devm_gpiod_get_index(dev, "bs", i,
>>> +							GPIOD_OUT_HIGH);
>>> +		if (!IS_ERR_OR_NULL(ctx->bs_gpio[i]))
>>> +			dev_dbg(dev, "bs%d-gpio is configured\n", i);
>> Are you sure you want to continue probe on error during getting gpios?
> There could be holes in the gpio list as mentioned in [1].
> For this panel, the potential holes mean that the relevant
> gpios are not controlled by the driver but only by the
> hardware.
>
> Perhaps, I need to handle the error case.
> I tried to implement it in the following way.
>
> ctx->bs_gpio[i] = devm_gpiod_get_index(dev, "bs", i,
>                                         GPIOD_OUT_HIGH);
> if (!IS_ERR_OR_NULL(ctx->bs_gpio[i])) {
>      dev_dbg(dev, "bs%d-gpio is configured\n", i);
> } else if (IS_ERR(ctx->bs_gpio[i])) {
>      dev_info(dev, "failed to get bs%d-gpio\n", i);
>      return PTR_ERR(ctx->bs_gpio[i]);
> }
>
> But, I get this in dmesg.  Any idea?
> [    1.625634] panel-hx8369a-dsi 21e0000.mipi.0: failed to get bs0-gpio
> [    1.633060] panel-hx8369a-dsi: probe of 21e0000.mipi.0 failed with 
> error -2

I guess you should use devm_gpiod_get_index_optional .

Regards
Andrzej

>
> [1] Documentation/devicetree/bindings/gpio/gpio.txt.
>
> Regards,
>
> Liu Ying
>
>> After addressing above comments you can add:
>>
>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>>
>>
>>
>> Regards
>> Andrzej
>>
>>
>>> +	}
>>> +
>>> +	ret = hx8369a_power_on(ctx);
>>> +	if (ret < 0) {
>>> +		dev_err(dev, "cannot power on\n");
>>> +		return ret;
>>> +	}
>>> +
>>> +	drm_panel_init(&ctx->panel);
>>> +	ctx->panel.dev = dev;
>>> +	ctx->panel.funcs = &hx8369a_dsi_drm_funcs;
>>> +
>>> +	ret = drm_panel_add(&ctx->panel);
>>> +	if (ret < 0)
>>> +		return ret;
>>> +
>>> +	mipi_dsi_set_drvdata(dsi, ctx);
>>> +
>>> +	dsi->lanes = ctx->pd->dsi_lanes;
>>> +	dsi->format = MIPI_DSI_FMT_RGB888;
>>> +	dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
>>> +			  MIPI_DSI_MODE_VIDEO_BURST |
>>> +			  MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
>>> +	ret = mipi_dsi_attach(dsi);
>>> +	if (ret < 0)
>>> +		drm_panel_remove(&ctx->panel);
>>> +
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_remove(struct mipi_dsi_device *dsi)
>>> +{
>>> +	struct hx8369a *ctx = mipi_dsi_get_drvdata(dsi);
>>> +
>>> +	mipi_dsi_detach(dsi);
>>> +	drm_panel_remove(&ctx->panel);
>>> +	return hx8369a_power_off(ctx);
>>> +}
>>> +
>>> +static struct mipi_dsi_driver hx8369a_dsi_driver = {
>>> +	.probe = hx8369a_dsi_probe,
>>> +	.remove = hx8369a_dsi_remove,
>>> +	.driver = {
>>> +		.name = "panel-hx8369a-dsi",
>>> +		.of_match_table = hx8369a_dsi_of_match,
>>> +	},
>>> +};
>>> +module_mipi_dsi_driver(hx8369a_dsi_driver);
>>> +
>>> +MODULE_DESCRIPTION("Himax HX8369A panel driver");
>>> +MODULE_AUTHOR("Liu Ying <Ying.Liu@freescale.com>");
>>> +MODULE_LICENSE("GPL v2");

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH RFC v6 16/21] drm: panel: Add support for Himax HX8369A
 MIPI DSI panel
Date: Mon, 29 Dec 2014 11:50:35 +0100
Message-ID: <54A131FB.8040809@samsung.com>
References: <1419835168-9034-1-git-send-email-Ying.Liu@freescale.com>
 <1419835168-9034-17-git-send-email-Ying.Liu@freescale.com>
 <54A11A65.1040509@samsung.com> <54A127D2.7080904@freescale.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-reply-to: <54A127D2.7080904@freescale.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Liu Ying <Ying.Liu@freescale.com>, dri-devel@lists.freedesktop.org
Cc: stefan.wahren@i2se.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, kernel@pengutronix.de, linux-kernel@vger.kernel.org, mturquette@linaro.org, linux-arm-kernel@lists.infradead.org, andyshrk@gmail.com
List-Id: devicetree@vger.kernel.org

T24gMTIvMjkvMjAxNCAxMTowNyBBTSwgTGl1IFlpbmcgd3JvdGU6Cj4gT24gMTIvMjkvMjAxNCAw
NTowOSBQTSwgQW5kcnplaiBIYWpkYSB3cm90ZToKPj4gT24gMTIvMjkvMjAxNCAwNzozOSBBTSwg
TGl1IFlpbmcgd3JvdGU6Cj4+PiBUaGlzIHBhdGNoIGFkZHMgc3VwcG9ydCBmb3IgSGltYXggSFg4
MzY5QSBNSVBJIERTSSBwYW5lbC4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBMaXUgWWluZyA8WWlu
Zy5MaXVAZnJlZXNjYWxlLmNvbT4KPj4+IC0tLQo+Pj4gdjUtPnY2Ogo+Pj4gICAqIE1ha2UgdGhl
IGNoZWNrcGF0Y2gucGwgc2NyaXB0IGJlIGhhcHBpZXIuCj4+PiAgICogRG8gbm90IHNldCB0aGUg
ZHNpIGNoYW5uZWwgbnVtYmVyIHRvIGJlIHplcm8gaW4gcHJvYmUoKSwgYmVjYXVzZSB0aGUgTUlQ
SSBEU0kKPj4+ICAgICBidXMgZHJpdmVyIHdvdWxkIHNldCBpdC4KPj4+Cj4+PiB2NC0+djU6Cj4+
PiAgICogQWRkcmVzcyBBbmRyemVqIEhhamRhJ3MgY29tbWVudHMuCj4+PiAgICogR2V0IHRoZSBi
cy1ncGlvcyBwcm9wZXJ0eSBpbnN0ZWFkIG9mIHRoZSBic1szOjBdLWdwaW9zIHByb3BlcnRpZXMu
Cj4+PiAgICogSW1wbGVtZW50IGVycm9yIHByb3BhZ2F0aW9uIGZvciBwYW5lbCByZWdpc3RlciBj
b25maWd1cmF0aW9ucy4KPj4+ICAgKiBPdGhlciBtaW5vciBjaGFuZ2VzIHRvIGltcHJvdmUgdGhl
IGNvZGUgcXVhbGl0eS4KPj4+Cj4+PiB2My0+djQ6Cj4+PiAgICogTW92ZSB0aGUgcmVsZXZhbnQg
ZHQtYmluZGluZ3MgdG8gYSBzZXBhcmF0ZSBwYXRjaCB0byBhZGRyZXNzIFN0ZWZhbgo+Pj4gICAg
IFdhaHJlbidzIGNvbW1lbnQuCj4+Pgo+Pj4gdjItPnYzOgo+Pj4gICAqIFNvcnQgdGhlIGluY2x1
ZGVkIGhlYWRlciBmaWxlcyBhbHBoYWJldGljYWxseS4KPj4+Cj4+PiB2MS0+djI6Cj4+PiAgICog
QWRkcmVzcyBhbG1vc3QgYWxsIGNvbW1lbnRzIGZyb20gVGhpZXJyeSBSZWRpbmcuCj4+PiAgICog
UmVtb3ZlIHNldmVyYWwgRFQgcHJvcGVydGllcyBhcyB0aGV5IGNhbiBiZSBpbXBsaWVkIGJ5IHRo
ZSBjb21wYXRpYmxlIHN0cmluZy4KPj4+ICAgKiBBZGQgdGhlIEhJTUFYL2hpbWF4IHByZWZpeGVz
IHRvIHRoZSBkcml2ZXIncyBLY29uZmlnIG5hbWUgYW5kIGRyaXZlciBuYW1lLgo+Pj4gICAqIE1v
dmUgdGhlIGRyaXZlcidzIE1ha2VmaWxlIGVudHJ5IHBsYWNlIHRvIHNvcnQgdGhlIGVudHJpZXMg
YWxwaGFiZXRpY2FsbHkuCj4+PiAgICogUmV1c2Ugc2V2ZXJhbCBzdGFuZGFyZCBEQ1MgZnVuY3Rp
b25zIGluc3RlYWQgb2YgaW52ZW50aW5nIHdoZWVscy4KPj4+ICAgKiBNb3ZlIHRoZSBwYW5lbCBy
ZXNldHRpbmcgYW5kIHBvd2VyIGxvZ2ljcyB0byB0aGUgZHJpdmVyIHByb2JlL3JlbW92ZSBzdGFn
ZXMuCj4+PiAgICAgVGhpcyBtYXkgc2ltcGxpZnkgcGFuZWwgcHJlcGFyZS91bnByZXBhcmUgaG9v
a3MuIFRoZSBwb3dlciBjb25zdW1wdGlvbiBzaG91bGQKPj4+ICAgICBub3QgY2hhbmdlIGEgbG90
IGF0IERQTVMgc2luY2UgdGhlIHBhbmVsIGVudGVycyBzbGVlcCBtb2RlIGF0IHRoYXQgdGltZS4K
Pj4+ICAgKiBBZGQgdGhlIG1vZHVsZSBhdXRob3IuCj4+PiAgICogT3RoZXIgbWlub3IgY2hhbmdl
cywgc3VjaCBhcyBjb2Rpbmcgc3R5bGUgaXNzdWVzLgo+Pj4KPj4+ICAgZHJpdmVycy9ncHUvZHJt
L3BhbmVsL0tjb25maWcgICAgICAgICAgICAgICB8ICAgNSArCj4+PiAgIGRyaXZlcnMvZ3B1L2Ry
bS9wYW5lbC9NYWtlZmlsZSAgICAgICAgICAgICAgfCAgIDEgKwo+Pj4gICBkcml2ZXJzL2dwdS9k
cm0vcGFuZWwvcGFuZWwtaGltYXgtaHg4MzY5YS5jIHwgNjE0ICsrKysrKysrKysrKysrKysrKysr
KysrKysrKysKPj4+ICAgMyBmaWxlcyBjaGFuZ2VkLCA2MjAgaW5zZXJ0aW9ucygrKQo+Pj4gICBj
cmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLWhpbWF4LWh4ODM2
OWEuYwo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvS2NvbmZpZyBi
L2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9LY29uZmlnCj4+PiBpbmRleCAwMjRlOThlLi44MWIwYmYw
IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL0tjb25maWcKPj4+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9LY29uZmlnCj4+PiBAQCAtMTYsNiArMTYsMTEgQEAgY29u
ZmlnIERSTV9QQU5FTF9TSU1QTEUKPj4+ICAgCSAgdGhhdCBpdCBjYW4gYmUgYXV0b21hdGljYWxs
eSB0dXJuZWQgb2ZmIHdoZW4gdGhlIHBhbmVsIGdvZXMgaW50byBhCj4+PiAgIAkgIGxvdyBwb3dl
ciBzdGF0ZS4KPj4+Cj4+PiArY29uZmlnIERSTV9QQU5FTF9ISU1BWF9IWDgzNjlBCj4+PiArCXRy
aXN0YXRlICJIaW1heCBIWDgzNjlBIHBhbmVsIgo+Pj4gKwlkZXBlbmRzIG9uIE9GCj4+PiArCXNl
bGVjdCBEUk1fTUlQSV9EU0kKPj4+ICsKPj4+ICAgY29uZmlnIERSTV9QQU5FTF9MRDkwNDAKPj4+
ICAgCXRyaXN0YXRlICJMRDkwNDAgUkdCL1NQSSBwYW5lbCIKPj4+ICAgCWRlcGVuZHMgb24gT0Yg
JiYgU1BJCj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL01ha2VmaWxlIGIv
ZHJpdmVycy9ncHUvZHJtL3BhbmVsL01ha2VmaWxlCj4+PiBpbmRleCA0YjJhMDQzLi5kNWRiZTA2
IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL01ha2VmaWxlCj4+PiArKysg
Yi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvTWFrZWZpbGUKPj4+IEBAIC0xLDQgKzEsNSBAQAo+Pj4g
ICBvYmotJChDT05GSUdfRFJNX1BBTkVMX1NJTVBMRSkgKz0gcGFuZWwtc2ltcGxlLm8KPj4+ICtv
YmotJChDT05GSUdfRFJNX1BBTkVMX0hJTUFYX0hYODM2OUEpICs9IHBhbmVsLWhpbWF4LWh4ODM2
OWEubwo+Pj4gICBvYmotJChDT05GSUdfRFJNX1BBTkVMX0xEOTA0MCkgKz0gcGFuZWwtbGQ5MDQw
Lm8KPj4+ICAgb2JqLSQoQ09ORklHX0RSTV9QQU5FTF9TNkU4QUEwKSArPSBwYW5lbC1zNmU4YWEw
Lm8KPj4+ICAgb2JqLSQoQ09ORklHX0RSTV9QQU5FTF9TSEFSUF9MUTEwMVIxU1gwMSkgKz0gcGFu
ZWwtc2hhcnAtbHExMDFyMXN4MDEubwo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9w
YW5lbC9wYW5lbC1oaW1heC1oeDgzNjlhLmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwt
aGltYXgtaHg4MzY5YS5jCj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+Pj4gaW5kZXggMDAwMDAw
MC4uZWVlMzZhNwo+Pj4gLS0tIC9kZXYvbnVsbAo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Bh
bmVsL3BhbmVsLWhpbWF4LWh4ODM2OWEuYwo+Pj4gQEAgLTAsMCArMSw2MTQgQEAKPj4+ICsvKgo+
Pj4gKyAqIEhpbWF4IEhYODM2OUEgcGFuZWwgZHJpdmVyLgo+Pj4gKyAqCj4+PiArICogQ29weXJp
Z2h0IChDKSAyMDExLTIwMTQgRnJlZXNjYWxlIFNlbWljb25kdWN0b3IsIEluYy4KPj4+ICsgKgo+
Pj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0
ZSBpdCBhbmQvb3IgbW9kaWZ5Cj4+PiArICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUg
R2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2ZXJzaW9uIDIgYXMKPj4+ICsgKiBwdWJsaXNoZWQgYnkg
dGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbi4KPj4+ICsgKgo+Pj4gKyAqIFRoaXMgZHJpdmVy
IGlzIGJhc2VkIG9uIFNhbXN1bmcgczZlOGFhMCBwYW5lbCBkcml2ZXIuCj4+PiArICovCj4+PiAr
Cj4+PiArI2luY2x1ZGUgPGRybS9kcm1QLmg+Cj4+PiArI2luY2x1ZGUgPGRybS9kcm1fbWlwaV9k
c2kuaD4KPj4+ICsjaW5jbHVkZSA8ZHJtL2RybV9wYW5lbC5oPgo+Pj4gKwo+Pj4gKyNpbmNsdWRl
IDxsaW51eC9ncGlvL2NvbnN1bWVyLmg+Cj4+PiArI2luY2x1ZGUgPGxpbnV4L29mX2RldmljZS5o
Pgo+Pj4gKyNpbmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvY29uc3VtZXIuaD4KPj4+ICsKPj4+ICsj
aW5jbHVkZSA8dmlkZW8vbWlwaV9kaXNwbGF5Lmg+Cj4+PiArI2luY2x1ZGUgPHZpZGVvL29mX3Zp
ZGVvbW9kZS5oPgo+Pj4gKyNpbmNsdWRlIDx2aWRlby92aWRlb21vZGUuaD4KPj4+ICsKPj4+ICsj
ZGVmaW5lIFdSRElTQlYJCTB4NTEKPj4+ICsjZGVmaW5lIFdSQ1RSTEQJCTB4NTMKPj4+ICsjZGVm
aW5lIFdSQ0FCQwkJMHg1NQo+Pj4gKyNkZWZpbmUgU0VUUE9XRVIJMHhiMQo+Pj4gKyNkZWZpbmUg
U0VURElTUAkJMHhiMgo+Pj4gKyNkZWZpbmUgU0VUQ1lDCQkweGI0Cj4+PiArI2RlZmluZSBTRVRW
Q09NCQkweGI2Cj4+PiArI2RlZmluZSBTRVRFWFRDCQkweGI5Cj4+PiArI2RlZmluZSBTRVRNSVBJ
CQkweGJhCj4+PiArI2RlZmluZSBTRVRQQU5FTAkweGNjCj4+PiArI2RlZmluZSBTRVRHSVAJCTB4
ZDUKPj4+ICsjZGVmaW5lIFNFVEdBTU1BCTB4ZTAKPj4+ICsKPj4+ICsjZGVmaW5lIEhYODM2OUFf
TUlOX0JSSUdIVE5FU1MJMHgwMAo+Pj4gKyNkZWZpbmUgSFg4MzY5QV9NQVhfQlJJR0hUTkVTUwkw
eGZmCj4+PiArCj4+PiArZW51bSBoeDgzNjlhX21wdV9pbnRlcmZhY2Ugewo+Pj4gKwlIWDgzNjlB
X0RCSV9UWVBFX0FfOEJJVCwKPj4+ICsJSFg4MzY5QV9EQklfVFlQRV9BXzlCSVQsCj4+PiArCUhY
ODM2OUFfREJJX1RZUEVfQV8xNkJJVCwKPj4+ICsJSFg4MzY5QV9EQklfVFlQRV9BXzE4QklULAo+
Pj4gKwlIWDgzNjlBX0RCSV9UWVBFX0JfOEJJVCwKPj4+ICsJSFg4MzY5QV9EQklfVFlQRV9CXzlC
SVQsCj4+PiArCUhYODM2OUFfREJJX1RZUEVfQl8xNkJJVCwKPj4+ICsJSFg4MzY5QV9EQklfVFlQ
RV9CXzE4QklULAo+Pj4gKwlIWDgzNjlBX0RTSV9DTURfTU9ERSwKPj4+ICsJSFg4MzY5QV9EQklf
VFlQRV9CXzI0QklULAo+Pj4gKwlIWDgzNjlBX0RTSV9WSURFT19NT0RFLAo+Pj4gKwlIWDgzNjlB
X01EREksCj4+PiArCUhYODM2OUFfRFBJX0RCSV9UWVBFX0NfT1BUMSwKPj4+ICsJSFg4MzY5QV9E
UElfREJJX1RZUEVfQ19PUFQyLAo+Pj4gKwlIWDgzNjlBX0RQSV9EQklfVFlQRV9DX09QVDMKPj4+
ICt9Owo+Pj4gKwo+Pj4gK2VudW0gaHg4MzY5YV9yZXNvbHV0aW9uIHsKPj4+ICsJSFg4MzY5QV9S
RVNfNDgwXzg2NCwKPj4+ICsJSFg4MzY5QV9SRVNfNDgwXzg1NCwKPj4+ICsJSFg4MzY5QV9SRVNf
NDgwXzgwMCwKPj4+ICsJSFg4MzY5QV9SRVNfNDgwXzY0MCwKPj4+ICsJSFg4MzY5QV9SRVNfMzYw
XzY0MCwKPj4+ICsJSFg4MzY5QV9SRVNfNDgwXzcyMCwKPj4+ICt9Owo+Pj4gKwo+Pj4gK3N0cnVj
dCBoeDgzNjlhX3BhbmVsX2Rlc2Mgewo+Pj4gKwljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9k
ZSAqbW9kZTsKPj4+ICsKPj4+ICsJLyogbXMgKi8KPj4+ICsJdW5zaWduZWQgaW50IHBvd2VyX29u
X2RlbGF5Owo+Pj4gKwl1bnNpZ25lZCBpbnQgcmVzZXRfZGVsYXk7Cj4+PiArCj4+PiArCXVuc2ln
bmVkIGludCBkc2lfbGFuZXM7Cj4+PiArfTsKPj4+ICsKPj4+ICtzdHJ1Y3QgaHg4MzY5YSB7Cj4+
PiArCXN0cnVjdCBkZXZpY2UgKmRldjsKPj4+ICsJc3RydWN0IGRybV9wYW5lbCBwYW5lbDsKPj4+
ICsKPj4+ICsJY29uc3Qgc3RydWN0IGh4ODM2OWFfcGFuZWxfZGVzYyAqcGQ7Cj4+PiArCj4+PiAr
CXN0cnVjdCByZWd1bGF0b3JfYnVsa19kYXRhIHN1cHBsaWVzWzVdOwo+Pj4gKwlzdHJ1Y3QgZ3Bp
b19kZXNjICpyZXNldF9ncGlvOwo+Pj4gKwlzdHJ1Y3QgZ3Bpb19kZXNjICpic19ncGlvWzRdOwo+
Pj4gKwl1OCByZXNfc2VsOwo+Pj4gK307Cj4+PiArCj4+PiArc3RhdGljIGlubGluZSBzdHJ1Y3Qg
aHg4MzY5YSAqcGFuZWxfdG9faHg4MzY5YShzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCkKPj4+ICt7
Cj4+PiArCXJldHVybiBjb250YWluZXJfb2YocGFuZWwsIHN0cnVjdCBoeDgzNjlhLCBwYW5lbCk7
Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyBpbnQgaHg4MzY5YV9kY3Nfd3JpdGUoc3RydWN0IGh4
ODM2OWEgKmN0eCwgY29uc3QgY2hhciAqZnVuYywKPj4+ICsJCQkgICAgIGNvbnN0IHZvaWQgKmRh
dGEsIHNpemVfdCBsZW4pCj4+PiArewo+Pj4gKwlzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlICpkc2kg
PSB0b19taXBpX2RzaV9kZXZpY2UoY3R4LT5kZXYpOwo+Pj4gKwlzc2l6ZV90IHJldDsKPj4+ICsK
Pj4+ICsJcmV0ID0gbWlwaV9kc2lfZGNzX3dyaXRlX2J1ZmZlcihkc2ksIGRhdGEsIGxlbik7Cj4+
PiArCWlmIChyZXQgPCAwKSB7Cj4+PiArCQlkZXZfZXJyKGN0eC0+ZGV2LCAiJXMgZmFpbGVkOiAl
ZFxuIiwgZnVuYywgcmV0KTsKPj4+ICsJCXJldHVybiByZXQ7Cj4+PiArCX0KPj4+ICsJcmV0dXJu
IDA7Cj4+IE5pdHBpY2suIFlvdSBjYW4gcmVwbGFjZSA0IGxpbmVzIGFib3ZlIHdpdGg6Cj4+ICAg
ICAgaWYgKHJldCA8IDApCj4+ICAgICAgICAgIGRldl9lcnIoY3R4LT5kZXYsICIlcyBmYWlsZWQ6
ICVkXG4iLCBmdW5jLCByZXQpOwo+PiAgICAgIHJldHVybiByZXQ7Cj4gSSdsbCBkbyB0aGF0Lgo+
Cj4+PiArfQo+Pj4gKwo+Pj4gKyNkZWZpbmUgaHg4MzY5YV9kY3Nfd3JpdGVfc2VxKGN0eCwgc2Vx
Li4uKSBcCj4+PiArKHsgXAo+Pj4gKwljb25zdCB1OCBkW10gPSB7IHNlcSB9OyBcCj4+PiArCUJV
SUxEX0JVR19PTl9NU0coQVJSQVlfU0laRShkKSA+IDY0LCBcCj4+PiArCQkJICJEQ1Mgc2VxdWVu
Y2UgdG9vIGJpZyBmb3Igc3RhY2siKTsgXAo+Pj4gKwloeDgzNjlhX2Rjc193cml0ZShjdHgsIF9f
ZnVuY19fLCBkLCBBUlJBWV9TSVpFKGQpKTsgXAo+Pj4gK30pCj4+PiArCj4+PiArI2RlZmluZSBo
eDgzNjlhX2Rjc193cml0ZV9zZXFfc3RhdGljKGN0eCwgc2VxLi4uKSBcCj4+PiArKHsgXAo+Pj4g
KwlzdGF0aWMgY29uc3QgdTggZFtdID0geyBzZXEgfTsgXAo+Pj4gKwloeDgzNjlhX2Rjc193cml0
ZShjdHgsIF9fZnVuY19fLCBkLCBBUlJBWV9TSVpFKGQpKTsgXAo+Pj4gK30pCj4+PiArCj4+PiAr
c3RhdGljIGludCBoeDgzNjlhX2RzaV9zZXRfZGlzcGxheV9yZWxhdGVkX3JlZ2lzdGVyKHN0cnVj
dCBoeDgzNjlhICpjdHgpCj4+PiArewo+Pj4gKwl1OCBzZWNfcCA9IChjdHgtPnJlc19zZWwgPDwg
NCkgfCAweDAzOwo+Pj4gKwo+Pj4gKwlyZXR1cm4gaHg4MzY5YV9kY3Nfd3JpdGVfc2VxKGN0eCwg
U0VURElTUCwgMHgwMCwgc2VjX3AsIDB4MDMsCj4+PiArCQkJICAgMHgwMywgMHg3MCwgMHgwMCwg
MHhmZiwgMHgwMCwgMHgwMCwgMHgwMCwKPj4+ICsJCQkgICAweDAwLCAweDAzLCAweDAzLCAweDAw
LCAweDAxKTsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIGludCBoeDgzNjlhX2RzaV9zZXRfZGlz
cGxheV93YXZlZm9ybV9jeWNsZShzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+Pj4gK3sKPj4+ICsJcmV0
dXJuIGh4ODM2OWFfZGNzX3dyaXRlX3NlcV9zdGF0aWMoY3R4LCBTRVRDWUMsIDB4MDAsIDB4MWQs
Cj4+PiArCQkJCQkweDVmLCAweDBlLCAweDA2KTsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIGlu
dCBoeDgzNjlhX2RzaV9zZXRfZ2lwKHN0cnVjdCBoeDgzNjlhICpjdHgpCj4+PiArewo+Pj4gKwly
ZXR1cm4gaHg4MzY5YV9kY3Nfd3JpdGVfc2VxX3N0YXRpYyhjdHgsIFNFVEdJUCwgMHgwMCwgMHgw
NCwKPj4+ICsJCQkJIDB4MDMsIDB4MDAsIDB4MDEsIDB4MDUsIDB4MWMsIDB4NzAsCj4+PiArCQkJ
CSAweDAxLCAweDAzLCAweDAwLCAweDAwLCAweDQwLCAweDA2LAo+Pj4gKwkJCQkgMHg1MSwgMHgw
NywgMHgwMCwgMHgwMCwgMHg0MSwgMHgwNiwKPj4+ICsJCQkJIDB4NTAsIDB4MDcsIDB4MDcsIDB4
MGYsIDB4MDQpOwo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgaW50IGh4ODM2OWFfZHNpX3NldF9w
b3dlcihzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+Pj4gK3sKPj4+ICsJcmV0dXJuIGh4ODM2OWFfZGNz
X3dyaXRlX3NlcV9zdGF0aWMoY3R4LCBTRVRQT1dFUiwgMHgwMSwgMHgwMCwKPj4+ICsJCQkJICAg
MHgzNCwgMHgwNiwgMHgwMCwgMHgwZiwgMHgwZiwgMHgyYSwKPj4+ICsJCQkJICAgMHgzMiwgMHgz
ZiwgMHgzZiwgMHgwNywgMHgzYSwgMHgwMSwKPj4+ICsJCQkJICAgMHhlNiwgMHhlNiwgMHhlNiwg
MHhlNiwgMHhlNik7Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyBpbnQgaHg4MzY5YV9kc2lfc2V0
X3Zjb21fdm9sdGFnZShzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+Pj4gK3sKPj4+ICsJcmV0dXJuIGh4
ODM2OWFfZGNzX3dyaXRlX3NlcV9zdGF0aWMoY3R4LCBTRVRWQ09NLCAweDU2LCAweDU2KTsKPj4+
ICt9Cj4+PiArCj4+PiArc3RhdGljIGludCBoeDgzNjlhX2RzaV9zZXRfcGFuZWwoc3RydWN0IGh4
ODM2OWEgKmN0eCkKPj4+ICt7Cj4+PiArCXJldHVybiBoeDgzNjlhX2Rjc193cml0ZV9zZXFfc3Rh
dGljKGN0eCwgU0VUUEFORUwsIDB4MDIpOwo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgaW50IGh4
ODM2OWFfZHNpX3NldF9nYW1tYV9jdXJ2ZShzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+Pj4gK3sKPj4+
ICsJcmV0dXJuIGh4ODM2OWFfZGNzX3dyaXRlX3NlcV9zdGF0aWMoY3R4LCBTRVRHQU1NQSwgMHgw
MCwgMHgxZCwKPj4+ICsJCQkJICAgMHgyMiwgMHgzOCwgMHgzZCwgMHgzZiwgMHgyZSwgMHg0YSwK
Pj4+ICsJCQkJICAgMHgwNiwgMHgwZCwgMHgwZiwgMHgxMywgMHgxNSwgMHgxMywKPj4+ICsJCQkJ
ICAgMHgxNiwgMHgxMCwgMHgxOSwgMHgwMCwgMHgxZCwgMHgyMiwKPj4+ICsJCQkJICAgMHgzOCwg
MHgzZCwgMHgzZiwgMHgyZSwgMHg0YSwgMHgwNiwKPj4+ICsJCQkJICAgMHgwZCwgMHgwZiwgMHgx
MywgMHgxNSwgMHgxMywgMHgxNiwKPj4+ICsJCQkJICAgMHgxMCwgMHgxOSk7Cj4+PiArfQo+Pj4g
Kwo+Pj4gK3N0YXRpYyBpbnQgaHg4MzY5YV9kc2lfc2V0X21pcGkoc3RydWN0IGh4ODM2OWEgKmN0
eCkKPj4+ICt7Cj4+PiArCXU4IGVsZXZlbnRoX3AgPSBjdHgtPnBkLT5kc2lfbGFuZXMgPT0gMiA/
IDB4MTEgOiAweDEwOwo+Pj4gKwo+Pj4gKwlyZXR1cm4gaHg4MzY5YV9kY3Nfd3JpdGVfc2VxKGN0
eCwgU0VUTUlQSSwgMHgwMCwgMHhhMCwgMHhjNiwKPj4+ICsJCQkJIDB4MDAsIDB4MGEsIDB4MDAs
IDB4MTAsIDB4MzAsIDB4NmYsCj4+PiArCQkJCSAweDAyLCBlbGV2ZW50aF9wLCAweDE4LCAweDQw
KTsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIGludCBoeDgzNjlhX2RzaV9zZXRfaW50ZXJmYWNl
X3BpeGVsX2ZvbWF0KHN0cnVjdCBoeDgzNjlhICpjdHgpCj4+PiArewo+Pj4gKwlzdHJ1Y3QgbWlw
aV9kc2lfZGV2aWNlICpkc2kgPSB0b19taXBpX2RzaV9kZXZpY2UoY3R4LT5kZXYpOwo+Pj4gKwl1
OCBmb3JtYXQ7Cj4+PiArCWludCByZXQ7Cj4+PiArCj4+PiArCXN3aXRjaCAoZHNpLT5mb3JtYXQp
IHsKPj4+ICsJY2FzZSBNSVBJX0RTSV9GTVRfUkdCODg4Ogo+Pj4gKwljYXNlIE1JUElfRFNJX0ZN
VF9SR0I2NjY6Cj4+PiArCQlmb3JtYXQgPSAweDc3Owo+Pj4gKwkJYnJlYWs7Cj4+PiArCWNhc2Ug
TUlQSV9EU0lfRk1UX1JHQjU2NToKPj4+ICsJCWZvcm1hdCA9IDB4NTU7Cj4+PiArCQlicmVhazsK
Pj4+ICsJY2FzZSBNSVBJX0RTSV9GTVRfUkdCNjY2X1BBQ0tFRDoKPj4+ICsJCWZvcm1hdCA9IDB4
NjY7Cj4+PiArCQlicmVhazsKPj4+ICsJZGVmYXVsdDoKPj4+ICsJCWRldl9lcnIoY3R4LT5kZXYs
ICJ1bnN1cHBvcnRlZCBEU0kgcGl4ZWwgZm9ybWF0XG4iKTsKPj4+ICsJCXJldHVybiAtRUlOVkFM
Owo+Pj4gKwl9Cj4+PiArCj4+PiArCXJldCA9IG1pcGlfZHNpX2Rjc19zZXRfcGl4ZWxfZm9ybWF0
KGRzaSwgZm9ybWF0KTsKPj4+ICsJaWYgKHJldCA8IDApCj4+PiArCQlkZXZfZXJyKGN0eC0+ZGV2
LCAiJXMgZmFpbGVkOiAlZFxuIiwgX19mdW5jX18sIHJldCk7Cj4+PiArCXJldHVybiByZXQ7Cj4+
PiArfQo+PiBUaGlzIGZ1bmN0aW9ucyBjb3VsZCBiZSBhbHNvIERTSSBoZWxwZXIsIGl0IGlzIG5v
dCBzcGVjaWZpYyB0byB0aGlzIHBhbmVsLAo+PiBidXQgaXQgaXMganVzdCBhIHN1Z2dlc3Rpb24u
Cj4gQW55IGRvY3VtZW50YXRpb24gY2FuIHJlZmxlY3QgdGhpcyBjb3VsZCBiZSBhIGNvbW1vbiBE
U0kgaGVscGVyLAo+IG1heWJlIHRoZSBNSVBJIERTSSBzcGVjPwo+IEkgd3JvdGUgdGhpcyBmdW5j
dGlvbiBieSB0YWtpbmcgdGhlIEhYODM2OUEgcGFuZWwgZGF0YSBzaGVldCBhcyBhCj4gcmVmZXJl
bmNlLgoKTUlQSSBEU0kgc3BlY2lmaWNhdGlvbiBkZXNjcmliZXMgTUlQSV9EU0lfRk1UXyogdmFs
dWVzIGFuZApNSVBJIERDUyBzcGVjaWZpY2F0aW9uIGRlc2NyaWJlcyAnZm9ybWF0JyB2YWx1ZXMg
KGllLiAweDc3LCAweDU1LCAweDY2KS4KRm9yIHJlZmVyZW5jZSBwbGVhc2UgbG9vayBmb3IgcGhy
YXNlICJUYWJsZSA2IEludGVyZmFjZSBQaXhlbCBGb3JtYXRzIiBpbgpNSVBJIERDUyBzcGVjaWZp
Y2F0aW9uIChvciBpbiBnb29nbGUgOikgKS4KCj4KPj4+ICsKPj4+ICtzdGF0aWMgaW50IGh4ODM2
OWFfZHNpX3NldF9jb2x1bW5fYWRkcmVzcyhzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+Pj4gK3sKPj4+
ICsJc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpID0gdG9fbWlwaV9kc2lfZGV2aWNlKGN0eC0+
ZGV2KTsKPj4+ICsJY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSBjdHgtPnBk
LT5tb2RlOwo+Pj4gKwlpbnQgcmV0Owo+Pj4gKwo+Pj4gKwlyZXQgPSBtaXBpX2RzaV9kY3Nfc2V0
X2NvbHVtbl9hZGRyZXNzKGRzaSwgMCwgbW9kZS0+aGRpc3BsYXkgLSAxKTsKPj4+ICsJaWYgKHJl
dCA8IDApCj4+PiArCQlkZXZfZXJyKGN0eC0+ZGV2LCAiJXMgZmFpbGVkOiAlZFxuIiwgX19mdW5j
X18sIHJldCk7Cj4+PiArCXJldHVybiByZXQ7Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyBpbnQg
aHg4MzY5YV9kc2lfc2V0X3BhZ2VfYWRkcmVzcyhzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+Pj4gK3sK
Pj4+ICsJc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpID0gdG9fbWlwaV9kc2lfZGV2aWNlKGN0
eC0+ZGV2KTsKPj4+ICsJY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSBjdHgt
PnBkLT5tb2RlOwo+Pj4gKwlpbnQgcmV0Owo+Pj4gKwo+Pj4gKwlyZXQgPSBtaXBpX2RzaV9kY3Nf
c2V0X3BhZ2VfYWRkcmVzcyhkc2ksIDAsIG1vZGUtPnZkaXNwbGF5IC0gMSk7Cj4+PiArCWlmIChy
ZXQgPCAwKQo+Pj4gKwkJZGV2X2VycihjdHgtPmRldiwgIiVzIGZhaWxlZDogJWRcbiIsIF9fZnVu
Y19fLCByZXQpOwo+Pj4gKwlyZXR1cm4gcmV0Owo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgaW50
IGh4ODM2OWFfZHNpX3dyaXRlX2Rpc3BsYXlfYnJpZ2h0bmVzcyhzdHJ1Y3QgaHg4MzY5YSAqY3R4
LAo+Pj4gKwkJCQkJCXU4IGJyaWdodG5lc3MpCj4+PiArewo+Pj4gKwlyZXR1cm4gaHg4MzY5YV9k
Y3Nfd3JpdGVfc2VxKGN0eCwgV1JESVNCViwgYnJpZ2h0bmVzcyk7Cj4+PiArfQo+Pj4gKwo+Pj4g
K3N0YXRpYyBpbnQgaHg4MzY5YV9kc2lfd3JpdGVfY2FiYyhzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+
Pj4gK3sKPj4+ICsJcmV0dXJuIGh4ODM2OWFfZGNzX3dyaXRlX3NlcV9zdGF0aWMoY3R4LCBXUkNB
QkMsIDB4MDEpOwo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgaW50IGh4ODM2OWFfZHNpX3dyaXRl
X2NvbnRyb2xfZGlzcGxheShzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+Pj4gK3sKPj4+ICsJcmV0dXJu
IGh4ODM2OWFfZGNzX3dyaXRlX3NlcV9zdGF0aWMoY3R4LCBXUkNUUkxELCAweDI0KTsKPj4+ICt9
Cj4+PiArCj4+PiArI2RlZmluZSBoeDgzNjlhX2RzaV9pbml0X2hlbHBlcihjdHgsIHJldCwgbmFt
ZSkgXAo+Pj4gKyh7IFwKPj4+ICsJcmV0ID0gaHg4MzY5YV9kc2lfIyNuYW1lKGN0eCk7IFwKPj4+
ICsJaWYgKHJldCA8IDApIFwKPj4+ICsJCXJldHVybiByZXQ7IFwKPj4+ICt9KQo+PiBZZWFoLCBh
bm90aGVyIGhhY2sgdG8gZ2V0IHJpZCBvZiByZWR1bmRhbnQgY29kZSA6KQo+PiBUd28gdWdseSB0
aGluZ3MgaGVyZTogIyMgYW5kIHJldHVybiBmcm9tIG1hY3JvLgo+Pgo+Pj4gKwo+Pj4gK3N0YXRp
YyBpbnQgaHg4MzY5YV9kc2lfcGFuZWxfaW5pdChzdHJ1Y3QgaHg4MzY5YSAqY3R4KQo+Pj4gK3sK
Pj4+ICsJaW50IHJldDsKPj4+ICsKPj4+ICsJaHg4MzY5YV9kc2lfaW5pdF9oZWxwZXIoY3R4LCBy
ZXQsIHNldF9kaXNwbGF5X3JlbGF0ZWRfcmVnaXN0ZXIpOwo+Pj4gKwloeDgzNjlhX2RzaV9pbml0
X2hlbHBlcihjdHgsIHJldCwgc2V0X2Rpc3BsYXlfd2F2ZWZvcm1fY3ljbGUpOwo+Pj4gKwloeDgz
NjlhX2RzaV9pbml0X2hlbHBlcihjdHgsIHJldCwgc2V0X2dpcCk7Cj4+PiArCWh4ODM2OWFfZHNp
X2luaXRfaGVscGVyKGN0eCwgcmV0LCBzZXRfcG93ZXIpOwo+Pj4gKwloeDgzNjlhX2RzaV9pbml0
X2hlbHBlcihjdHgsIHJldCwgc2V0X3Zjb21fdm9sdGFnZSk7Cj4+PiArCWh4ODM2OWFfZHNpX2lu
aXRfaGVscGVyKGN0eCwgcmV0LCBzZXRfcGFuZWwpOwo+Pj4gKwloeDgzNjlhX2RzaV9pbml0X2hl
bHBlcihjdHgsIHJldCwgc2V0X2dhbW1hX2N1cnZlKTsKPj4+ICsJaHg4MzY5YV9kc2lfaW5pdF9o
ZWxwZXIoY3R4LCByZXQsIHNldF9taXBpKTsKPj4+ICsJaHg4MzY5YV9kc2lfaW5pdF9oZWxwZXIo
Y3R4LCByZXQsIHNldF9pbnRlcmZhY2VfcGl4ZWxfZm9tYXQpOwo+Pj4gKwloeDgzNjlhX2RzaV9p
bml0X2hlbHBlcihjdHgsIHJldCwgc2V0X2NvbHVtbl9hZGRyZXNzKTsKPj4+ICsJaHg4MzY5YV9k
c2lfaW5pdF9oZWxwZXIoY3R4LCByZXQsIHNldF9wYWdlX2FkZHJlc3MpOwo+Pj4gKwloeDgzNjlh
X2RzaV9pbml0X2hlbHBlcihjdHgsIHJldCwgd3JpdGVfY2FiYyk7Cj4+PiArCWh4ODM2OWFfZHNp
X2luaXRfaGVscGVyKGN0eCwgcmV0LCB3cml0ZV9jb250cm9sX2Rpc3BsYXkpOwo+PiBNYXliZSBp
dCB3b3VsZCBiZSBiZXR0ZXIgdG8gcmVwbGFjZSB0aGUgaGFjayBhYm92ZSB3aXRoIHNvbWV0aGlu
ZyBsaWtlOgo+PiB7Cj4+ICAgICAgaW50ICgqKShzdHJ1Y3QgaHg4MzY5YSAqY3R4KSBmdW5jc1td
ID0gewo+PiAgICAgICAgICBoeDgzNjlhX2RzaV9zZXRfZGlzcGxheV9yZWxhdGVkX3JlZ2lzdGVy
LAo+PiAgICAgICAgICBoeDgzNjlhX2RzaV9zZXRfZGlzcGxheV93YXZlZm9ybV9jeWNsZSwKPj4g
ICAgICAgICAgLi4uCj4+ICAgICAgIH07Cj4+ICAgICAgaW50IHJldCwgaTsKPj4KPj4gICAgICBm
b3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShmdW5jcyk7ICsraSkgewo+PiAgICAgICAgICByZXQg
PSBmdW5jc1tpXShjdHgpOwo+PiAgICAgICAgICBpZiAocmV0KQo+PiAgICAgICAgICAgICAgcmV0
dXJuIHJldDsKPj4gICAgICB9Cj4gSSdsbCBjaGFuZ2UgdG8gdXNlIHRoaXMuICBUaGFua3MuCj4K
Pj4+ICsKPj4+ICsJcmV0dXJuIDA7Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyBpbnQgaHg4MzY5
YV9kc2lfc2V0X2V4dGVuc2lvbl9jb21tYW5kKHN0cnVjdCBoeDgzNjlhICpjdHgpCj4+PiArewo+
Pj4gKwlyZXR1cm4gaHg4MzY5YV9kY3Nfd3JpdGVfc2VxX3N0YXRpYyhjdHgsIFNFVEVYVEMsIDB4
ZmYsIDB4ODMsIDB4NjkpOwo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgaW50IGh4ODM2OWFfZHNp
X3NldF9tYXhpbXVtX3JldHVybl9wYWNrZXRfc2l6ZShzdHJ1Y3QgaHg4MzY5YSAqY3R4LAo+Pj4g
KwkJCQkJCSAgICAgIHUxNiBzaXplKQo+Pj4gK3sKPj4+ICsJc3RydWN0IG1pcGlfZHNpX2Rldmlj
ZSAqZHNpID0gdG9fbWlwaV9kc2lfZGV2aWNlKGN0eC0+ZGV2KTsKPj4+ICsJaW50IHJldDsKPj4+
ICsKPj4+ICsJcmV0ID0gbWlwaV9kc2lfc2V0X21heGltdW1fcmV0dXJuX3BhY2tldF9zaXplKGRz
aSwgc2l6ZSk7Cj4+PiArCWlmIChyZXQgPCAwKQo+Pj4gKwkJZGV2X2VycihjdHgtPmRldiwKPj4+
ICsJCQkiZXJyb3IgJWQgc2V0dGluZyBtYXhpbXVtIHJldHVybiBwYWNrZXQgc2l6ZSB0byAlZFxu
IiwKPj4+ICsJCQlyZXQsIHNpemUpOwo+Pj4gKwlyZXR1cm4gcmV0Owo+Pj4gK30KPj4+ICsKPj4+
ICtzdGF0aWMgaW50IGh4ODM2OWFfZHNpX3NldF9zZXF1ZW5jZShzdHJ1Y3QgaHg4MzY5YSAqY3R4
KQo+Pj4gK3sKPj4+ICsJc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpID0gdG9fbWlwaV9kc2lf
ZGV2aWNlKGN0eC0+ZGV2KTsKPj4+ICsJaW50IHJldDsKPj4+ICsKPj4+ICsJcmV0ID0gaHg4MzY5
YV9kc2lfc2V0X2V4dGVuc2lvbl9jb21tYW5kKGN0eCk7Cj4+PiArCWlmIChyZXQgPCAwKQo+Pj4g
KwkJZ290byBvdXQ7Cj4+PiArCj4+PiArCXJldCA9IGh4ODM2OWFfZHNpX3NldF9tYXhpbXVtX3Jl
dHVybl9wYWNrZXRfc2l6ZShjdHgsIDQpOwo+Pj4gKwlpZiAocmV0IDwgMCkKPj4+ICsJCWdvdG8g
b3V0Owo+Pj4gKwo+Pj4gKwlyZXQgPSBoeDgzNjlhX2RzaV9wYW5lbF9pbml0KGN0eCk7Cj4+PiAr
CWlmIChyZXQgPCAwKQo+Pj4gKwkJZ290byBvdXQ7Cj4+PiArCj4+PiArCXJldCA9IG1pcGlfZHNp
X2Rjc19leGl0X3NsZWVwX21vZGUoZHNpKTsKPj4+ICsJaWYgKHJldCA8IDApIHsKPj4+ICsJCWRl
dl9lcnIoY3R4LT5kZXYsICJmYWlsZWQgdG8gZXhpdCBzbGVlcCBtb2RlOiAlZFxuIiwgcmV0KTsK
Pj4+ICsJCWdvdG8gb3V0Owo+Pj4gKwl9Cj4+PiArCj4+PiArCXJldCA9IG1pcGlfZHNpX2Rjc19z
ZXRfZGlzcGxheV9vbihkc2kpOwo+Pj4gKwlpZiAocmV0IDwgMCkgewo+Pj4gKwkJZGV2X2Vycihj
dHgtPmRldiwgImZhaWxlZCB0byBzZXQgZGlzcGxheSBvbjogJWRcbiIsIHJldCk7Cj4+PiArCQln
b3RvIG91dDsKPj4+ICsJfQo+Pj4gKwo+Pj4gKwkvKgo+Pj4gKwkgKiBJdCdzIG5lY2Vzc2FyeSB0
byB3YWl0IDEyMG1zZWMgYWZ0ZXIgc2VuZGluZyB0aGUgU2xlZXAgT3V0Cj4+PiArCSAqIGNvbW1h
bmQgYmVmb3JlIFNsZWVwIEluIGNvbW1hbmQgY2FuIGJlIHNlbnQsIGFjY29yZGluZyB0bwo+Pj4g
KwkgKiB0aGUgSFg4MzY5QSBkYXRhIHNoZWV0Lgo+Pj4gKwkgKi8KPj4+ICsJbXNsZWVwKDEyMCk7
Cj4+PiArb3V0Ogo+Pj4gKwlyZXR1cm4gcmV0Owo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgaW50
IGh4ODM2OWFfZHNpX2Rpc2FibGUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4+PiArewo+Pj4g
KwlzdHJ1Y3QgaHg4MzY5YSAqY3R4ID0gcGFuZWxfdG9faHg4MzY5YShwYW5lbCk7Cj4+PiArCj4+
PiArCXJldHVybiBoeDgzNjlhX2RzaV93cml0ZV9kaXNwbGF5X2JyaWdodG5lc3MoY3R4LAo+Pj4g
KwkJCQkJCUhYODM2OUFfTUlOX0JSSUdIVE5FU1MpOwo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMg
aW50IGh4ODM2OWFfZHNpX3VucHJlcGFyZShzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCkKPj4+ICt7
Cj4+PiArCXN0cnVjdCBoeDgzNjlhICpjdHggPSBwYW5lbF90b19oeDgzNjlhKHBhbmVsKTsKPj4+
ICsJc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpID0gdG9fbWlwaV9kc2lfZGV2aWNlKGN0eC0+
ZGV2KTsKPj4+ICsJaW50IHJldDsKPj4+ICsKPj4+ICsJcmV0ID0gbWlwaV9kc2lfZGNzX2VudGVy
X3NsZWVwX21vZGUoZHNpKTsKPj4+ICsJaWYgKHJldCA8IDApIHsKPj4+ICsJCWRldl9lcnIoY3R4
LT5kZXYsICJmYWlsZWQgdG8gZW50ZXIgc2xlZXAgbW9kZTogJWRcbiIsIHJldCk7Cj4+PiArCQln
b3RvIG91dDsKPj4+ICsJfQo+Pj4gKwo+Pj4gKwlyZXQgPSBtaXBpX2RzaV9kY3Nfc2V0X2Rpc3Bs
YXlfb2ZmKGRzaSk7Cj4+PiArCWlmIChyZXQgPCAwKSB7Cj4+PiArCQlkZXZfZXJyKGN0eC0+ZGV2
LCAiZmFpbGVkIHRvIHNldCBkaXNwbGF5IG9mZjogJWRcbiIsIHJldCk7Cj4+PiArCQlnb3RvIG91
dDsKPj4+ICsJfQo+Pj4gKwo+Pj4gKwkvKgo+Pj4gKwkgKiBUaGlzIGlzIHRvIGFsbG93IHRpbWUg
Zm9yIHRoZSBzdXBwbHkgdm9sdGFnZXMgYW5kIGNsb2NrCj4+PiArCSAqIGNpcmN1aXRzIHRvIHN0
YWJsaXplLCBhY2NvcmRpbmcgdG8gdGhlIEhYODM2OUEgZGF0YSBzaGVldC4KPj4+ICsJICovCj4+
PiArCW1zbGVlcCg1KTsKPj4+ICtvdXQ6Cj4+PiArCXJldHVybiByZXQ7Cj4+PiArfQo+Pj4gKwo+
Pj4gK3N0YXRpYyBpbnQgaHg4MzY5YV9kc2lfcHJlcGFyZShzdHJ1Y3QgZHJtX3BhbmVsICpwYW5l
bCkKPj4+ICt7Cj4+PiArCXN0cnVjdCBoeDgzNjlhICpjdHggPSBwYW5lbF90b19oeDgzNjlhKHBh
bmVsKTsKPj4+ICsKPj4+ICsJcmV0dXJuIGh4ODM2OWFfZHNpX3NldF9zZXF1ZW5jZShjdHgpOwo+
Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgaW50IGh4ODM2OWFfZHNpX2VuYWJsZShzdHJ1Y3QgZHJt
X3BhbmVsICpwYW5lbCkKPj4+ICt7Cj4+PiArCXN0cnVjdCBoeDgzNjlhICpjdHggPSBwYW5lbF90
b19oeDgzNjlhKHBhbmVsKTsKPj4+ICsKPj4+ICsJcmV0dXJuIGh4ODM2OWFfZHNpX3dyaXRlX2Rp
c3BsYXlfYnJpZ2h0bmVzcyhjdHgsCj4+PiArCQkJCQkJSFg4MzY5QV9NQVhfQlJJR0hUTkVTUyk7
Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyBpbnQgaHg4MzY5YV9nZXRfbW9kZXMoc3RydWN0IGRy
bV9wYW5lbCAqcGFuZWwpCj4+PiArewo+Pj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVj
dG9yID0gcGFuZWwtPmNvbm5lY3RvcjsKPj4+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRybSA9IHBh
bmVsLT5kcm07Cj4+PiArCXN0cnVjdCBoeDgzNjlhICpjdHggPSBwYW5lbF90b19oeDgzNjlhKHBh
bmVsKTsKPj4+ICsJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7Cj4+PiArCWNvbnN0IHN0
cnVjdCBkcm1fZGlzcGxheV9tb2RlICptID0gY3R4LT5wZC0+bW9kZTsKPj4+ICsKPj4+ICsJbW9k
ZSA9IGRybV9tb2RlX2R1cGxpY2F0ZShkcm0sIG0pOwo+Pj4gKwlpZiAoIW1vZGUpIHsKPj4+ICsJ
CWRldl9lcnIoZHJtLT5kZXYsICJmYWlsZWQgdG8gYWRkIG1vZGUgJXV4JXVAJXVcbiIsCj4+PiAr
CQkJbS0+aGRpc3BsYXksIG0tPnZkaXNwbGF5LCBtLT52cmVmcmVzaCk7Cj4+PiArCQlyZXR1cm4g
MDsKPj4+ICsJfQo+Pj4gKwo+Pj4gKwlkcm1fbW9kZV9zZXRfbmFtZShtb2RlKTsKPj4+ICsJbW9k
ZS0+dHlwZSA9IERSTV9NT0RFX1RZUEVfRFJJVkVSIHwgRFJNX01PREVfVFlQRV9QUkVGRVJSRUQ7
Cj4+PiArCj4+PiArCWNvbm5lY3Rvci0+ZGlzcGxheV9pbmZvLmJwYyA9IDg7Cj4+PiArCWNvbm5l
Y3Rvci0+ZGlzcGxheV9pbmZvLndpZHRoX21tID0gbW9kZS0+d2lkdGhfbW07Cj4+PiArCWNvbm5l
Y3Rvci0+ZGlzcGxheV9pbmZvLmhlaWdodF9tbSA9IG1vZGUtPmhlaWdodF9tbTsKPj4+ICsKPj4+
ICsJZHJtX21vZGVfcHJvYmVkX2FkZChjb25uZWN0b3IsIG1vZGUpOwo+Pj4gKwo+Pj4gKwlyZXR1
cm4gMTsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fcGFuZWxfZnVu
Y3MgaHg4MzY5YV9kc2lfZHJtX2Z1bmNzID0gewo+Pj4gKwkuZGlzYWJsZSA9IGh4ODM2OWFfZHNp
X2Rpc2FibGUsCj4+PiArCS51bnByZXBhcmUgPSBoeDgzNjlhX2RzaV91bnByZXBhcmUsCj4+PiAr
CS5wcmVwYXJlID0gaHg4MzY5YV9kc2lfcHJlcGFyZSwKPj4+ICsJLmVuYWJsZSA9IGh4ODM2OWFf
ZHNpX2VuYWJsZSwKPj4+ICsJLmdldF9tb2RlcyA9IGh4ODM2OWFfZ2V0X21vZGVzLAo+Pj4gK307
Cj4+PiArCj4+PiArc3RhdGljIGludCBoeDgzNjlhX3Bvd2VyX29uKHN0cnVjdCBoeDgzNjlhICpj
dHgpCj4+PiArewo+Pj4gKwlpbnQgcmV0Owo+Pj4gKwo+Pj4gKwlyZXQgPSByZWd1bGF0b3JfYnVs
a19lbmFibGUoQVJSQVlfU0laRShjdHgtPnN1cHBsaWVzKSwgY3R4LT5zdXBwbGllcyk7Cj4+PiAr
CWlmIChyZXQgPCAwKQo+Pj4gKwkJcmV0dXJuIHJldDsKPj4+ICsKPj4+ICsJbXNsZWVwKGN0eC0+
cGQtPnBvd2VyX29uX2RlbGF5KTsKPj4+ICsKPj4+ICsJZ3Bpb2Rfc2V0X3ZhbHVlKGN0eC0+cmVz
ZXRfZ3BpbywgMSk7Cj4+PiArCXVzbGVlcF9yYW5nZSg1MCwgNjApOwo+Pj4gKwlncGlvZF9zZXRf
dmFsdWUoY3R4LT5yZXNldF9ncGlvLCAwKTsKPj4+ICsKPj4+ICsJbXNsZWVwKGN0eC0+cGQtPnJl
c2V0X2RlbGF5KTsKPj4+ICsKPj4+ICsJcmV0dXJuIDA7Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRp
YyBpbnQgaHg4MzY5YV9wb3dlcl9vZmYoc3RydWN0IGh4ODM2OWEgKmN0eCkKPj4+ICt7Cj4+PiAr
CXJldHVybiByZWd1bGF0b3JfYnVsa19kaXNhYmxlKEFSUkFZX1NJWkUoY3R4LT5zdXBwbGllcyks
Cj4+PiArCQkJCSAgICAgIGN0eC0+c3VwcGxpZXMpOwo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMg
dm9pZCBoeDgzNjlhX3ZtX3RvX3Jlc19zZWwoc3RydWN0IGh4ODM2OWEgKmN0eCkKPj4+ICt7Cj4+
PiArCWNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlID0gY3R4LT5wZC0+bW9kZTsK
Pj4+ICsKPj4+ICsJc3dpdGNoIChtb2RlLT5oZGlzcGxheSkgewo+Pj4gKwljYXNlIDQ4MDoKPj4+
ICsJCXN3aXRjaCAobW9kZS0+dmRpc3BsYXkpIHsKPj4+ICsJCWNhc2UgODY0Ogo+Pj4gKwkJCWN0
eC0+cmVzX3NlbCA9IEhYODM2OUFfUkVTXzQ4MF84NjQ7Cj4+PiArCQkJYnJlYWs7Cj4+PiArCQlj
YXNlIDg1NDoKPj4+ICsJCQljdHgtPnJlc19zZWwgPSBIWDgzNjlBX1JFU180ODBfODU0Owo+Pj4g
KwkJCWJyZWFrOwo+Pj4gKwkJY2FzZSA4MDA6Cj4+PiArCQkJY3R4LT5yZXNfc2VsID0gSFg4MzY5
QV9SRVNfNDgwXzgwMDsKPj4+ICsJCQlicmVhazsKPj4+ICsJCWNhc2UgNjQwOgo+Pj4gKwkJCWN0
eC0+cmVzX3NlbCA9IEhYODM2OUFfUkVTXzQ4MF82NDA7Cj4+PiArCQkJYnJlYWs7Cj4+PiArCQlj
YXNlIDcyMDoKPj4+ICsJCQljdHgtPnJlc19zZWwgPSBIWDgzNjlBX1JFU180ODBfNzIwOwo+Pj4g
KwkJCWJyZWFrOwo+Pj4gKwkJZGVmYXVsdDoKPj4+ICsJCQlicmVhazsKPj4+ICsJCX0KPj4+ICsJ
CWJyZWFrOwo+Pj4gKwljYXNlIDM2MDoKPj4+ICsJCWlmIChtb2RlLT52ZGlzcGxheSA9PSA2NDAp
Cj4+PiArCQkJY3R4LT5yZXNfc2VsID0gSFg4MzY5QV9SRVNfMzYwXzY0MDsKPj4+ICsJCWJyZWFr
Owo+Pj4gKwlkZWZhdWx0Ogo+Pj4gKwkJYnJlYWs7Cj4+PiArCX0KPj4+ICt9Cj4+PiArCj4+PiAr
c3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlIHRydWx5X3RmdDQ4MDgwMF8xNl9l
X21vZGUgPSB7Cj4+PiArCS5jbG9jayA9IDI2NDAwLAo+Pj4gKwkuaGRpc3BsYXkgPSA0ODAsCj4+
PiArCS5oc3luY19zdGFydCA9IDQ4MCArIDgsCj4+PiArCS5oc3luY19lbmQgPSA0ODAgKyA4ICsg
OCwKPj4+ICsJLmh0b3RhbCA9IDQ4MCArIDggKyA4ICsgOCwKPj4+ICsJLnZkaXNwbGF5ID0gODAw
LAo+Pj4gKwkudnN5bmNfc3RhcnQgPSA4MDAgKyA2LAo+Pj4gKwkudnN5bmNfZW5kID0gODAwICsg
NiArIDYsCj4+PiArCS52dG90YWwgPSA4MDAgKyA2ICsgNiArIDYsCj4+PiArCS52cmVmcmVzaCA9
IDYwLAo+Pj4gKwkud2lkdGhfbW0gPSA0NSwKPj4+ICsJLmhlaWdodF9tbSA9IDc2LAo+Pj4gK307
Cj4+PiArCj4+PiArc3RhdGljIGNvbnN0IHN0cnVjdCBoeDgzNjlhX3BhbmVsX2Rlc2MgdHJ1bHlf
dGZ0NDgwODAwXzE2X2VfZHNpID0gewo+Pj4gKwkubW9kZSA9ICZ0cnVseV90ZnQ0ODA4MDBfMTZf
ZV9tb2RlLAo+Pj4gKwkucG93ZXJfb25fZGVsYXkgPSAxMCwKPj4+ICsJLnJlc2V0X2RlbGF5ID0g
MTAsCj4+PiArCS5kc2lfbGFuZXMgPSAyLAo+Pj4gK307Cj4+PiArCj4+PiArc3RhdGljIGNvbnN0
IHN0cnVjdCBvZl9kZXZpY2VfaWQgaHg4MzY5YV9kc2lfb2ZfbWF0Y2hbXSA9IHsKPj4+ICsJewo+
Pj4gKwkJLmNvbXBhdGlibGUgPSAidHJ1bHksdGZ0NDgwODAwLTE2LWUtZHNpIiwKPj4+ICsJCS5k
YXRhID0gJnRydWx5X3RmdDQ4MDgwMF8xNl9lX2RzaSwKPj4+ICsJfSwgewo+Pj4gKwkJLyogc2Vu
dGluZWwgKi8KPj4+ICsJfSwKPj4+ICt9Owo+Pj4gK01PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIGh4
ODM2OWFfZHNpX29mX21hdGNoKTsKPj4+ICsKPj4+ICtzdGF0aWMgaW50IGh4ODM2OWFfZHNpX3By
b2JlKHN0cnVjdCBtaXBpX2RzaV9kZXZpY2UgKmRzaSkKPj4+ICt7Cj4+PiArCXN0cnVjdCBkZXZp
Y2UgKmRldiA9ICZkc2ktPmRldjsKPj4+ICsJY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCAqb2Zf
aWQgPQo+Pj4gKwkJCW9mX21hdGNoX2RldmljZShoeDgzNjlhX2RzaV9vZl9tYXRjaCwgZGV2KTsK
Pj4+ICsJc3RydWN0IGh4ODM2OWEgKmN0eDsKPj4+ICsJaW50IHJldCwgaTsKPj4+ICsKPj4+ICsJ
Y3R4ID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9mKCpjdHgpLCBHRlBfS0VSTkVMKTsKPj4+ICsJ
aWYgKCFjdHgpCj4+PiArCQlyZXR1cm4gLUVOT01FTTsKPj4+ICsKPj4+ICsJY3R4LT5kZXYgPSBk
ZXY7Cj4+PiArCj4+PiArCWlmIChvZl9pZCkgewo+Pj4gKwkJY3R4LT5wZCA9IG9mX2lkLT5kYXRh
Owo+Pj4gKwl9IGVsc2Ugewo+Pj4gKwkJZGV2X2VycihkZXYsICJjYW5ub3QgZmluZCBjb21wYXRp
YmxlIGRldmljZVxuIik7Cj4+PiArCQlyZXR1cm4gLUVOT0RFVjsKPj4+ICsJfQo+Pj4gKwo+Pj4g
KwloeDgzNjlhX3ZtX3RvX3Jlc19zZWwoY3R4KTsKPj4+ICsKPj4+ICsJY3R4LT5zdXBwbGllc1sw
XS5zdXBwbHkgPSAidmRkMSI7Cj4+PiArCWN0eC0+c3VwcGxpZXNbMV0uc3VwcGx5ID0gInZkZDIi
Owo+Pj4gKwljdHgtPnN1cHBsaWVzWzJdLnN1cHBseSA9ICJ2ZGQzIjsKPj4+ICsJY3R4LT5zdXBw
bGllc1szXS5zdXBwbHkgPSAiZHNpLXZjYyI7Cj4+PiArCWN0eC0+c3VwcGxpZXNbNF0uc3VwcGx5
ID0gInZwcCI7Cj4+PiArCXJldCA9IGRldm1fcmVndWxhdG9yX2J1bGtfZ2V0KGRldiwgQVJSQVlf
U0laRShjdHgtPnN1cHBsaWVzKSwKPj4+ICsJCQkJICAgICAgY3R4LT5zdXBwbGllcyk7Cj4+PiAr
CWlmIChyZXQgPCAwKSB7Cj4+PiArCQlkZXZfaW5mbyhkZXYsICJmYWlsZWQgdG8gZ2V0IHJlZ3Vs
YXRvcnM6ICVkXG4iLCByZXQpOwo+Pj4gKwkJcmV0dXJuIHJldDsKPj4+ICsJfQo+Pj4gKwo+Pj4g
KwljdHgtPnJlc2V0X2dwaW8gPSBkZXZtX2dwaW9kX2dldChkZXYsICJyZXNldCIsIEdQSU9EX09V
VF9MT1cpOwo+Pj4gKwlpZiAoSVNfRVJSKGN0eC0+cmVzZXRfZ3BpbykpIHsKPj4+ICsJCWRldl9p
bmZvKGRldiwgImNhbm5vdCBnZXQgcmVzZXQtZ3Bpb3MgJWxkXG4iLAo+Pj4gKwkJCSBQVFJfRVJS
KGN0eC0+cmVzZXRfZ3BpbykpOwo+Pj4gKwkJcmV0dXJuIFBUUl9FUlIoY3R4LT5yZXNldF9ncGlv
KTsKPj4+ICsJfQo+Pj4gKwo+Pj4gKwlmb3IgKGkgPSAwOyBpIDwgNDsgaSsrKSB7Cj4+PiArCQlj
dHgtPmJzX2dwaW9baV0gPSBkZXZtX2dwaW9kX2dldF9pbmRleChkZXYsICJicyIsIGksCj4+PiAr
CQkJCQkJCUdQSU9EX09VVF9ISUdIKTsKPj4+ICsJCWlmICghSVNfRVJSX09SX05VTEwoY3R4LT5i
c19ncGlvW2ldKSkKPj4+ICsJCQlkZXZfZGJnKGRldiwgImJzJWQtZ3BpbyBpcyBjb25maWd1cmVk
XG4iLCBpKTsKPj4gQXJlIHlvdSBzdXJlIHlvdSB3YW50IHRvIGNvbnRpbnVlIHByb2JlIG9uIGVy
cm9yIGR1cmluZyBnZXR0aW5nIGdwaW9zPwo+IFRoZXJlIGNvdWxkIGJlIGhvbGVzIGluIHRoZSBn
cGlvIGxpc3QgYXMgbWVudGlvbmVkIGluIFsxXS4KPiBGb3IgdGhpcyBwYW5lbCwgdGhlIHBvdGVu
dGlhbCBob2xlcyBtZWFuIHRoYXQgdGhlIHJlbGV2YW50Cj4gZ3Bpb3MgYXJlIG5vdCBjb250cm9s
bGVkIGJ5IHRoZSBkcml2ZXIgYnV0IG9ubHkgYnkgdGhlCj4gaGFyZHdhcmUuCj4KPiBQZXJoYXBz
LCBJIG5lZWQgdG8gaGFuZGxlIHRoZSBlcnJvciBjYXNlLgo+IEkgdHJpZWQgdG8gaW1wbGVtZW50
IGl0IGluIHRoZSBmb2xsb3dpbmcgd2F5Lgo+Cj4gY3R4LT5ic19ncGlvW2ldID0gZGV2bV9ncGlv
ZF9nZXRfaW5kZXgoZGV2LCAiYnMiLCBpLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBHUElPRF9PVVRfSElHSCk7Cj4gaWYgKCFJU19FUlJfT1JfTlVMTChjdHgtPmJz
X2dwaW9baV0pKSB7Cj4gICAgICBkZXZfZGJnKGRldiwgImJzJWQtZ3BpbyBpcyBjb25maWd1cmVk
XG4iLCBpKTsKPiB9IGVsc2UgaWYgKElTX0VSUihjdHgtPmJzX2dwaW9baV0pKSB7Cj4gICAgICBk
ZXZfaW5mbyhkZXYsICJmYWlsZWQgdG8gZ2V0IGJzJWQtZ3Bpb1xuIiwgaSk7Cj4gICAgICByZXR1
cm4gUFRSX0VSUihjdHgtPmJzX2dwaW9baV0pOwo+IH0KPgo+IEJ1dCwgSSBnZXQgdGhpcyBpbiBk
bWVzZy4gIEFueSBpZGVhPwo+IFsgICAgMS42MjU2MzRdIHBhbmVsLWh4ODM2OWEtZHNpIDIxZTAw
MDAubWlwaS4wOiBmYWlsZWQgdG8gZ2V0IGJzMC1ncGlvCj4gWyAgICAxLjYzMzA2MF0gcGFuZWwt
aHg4MzY5YS1kc2k6IHByb2JlIG9mIDIxZTAwMDAubWlwaS4wIGZhaWxlZCB3aXRoIAo+IGVycm9y
IC0yCgpJIGd1ZXNzIHlvdSBzaG91bGQgdXNlIGRldm1fZ3Bpb2RfZ2V0X2luZGV4X29wdGlvbmFs
IC4KClJlZ2FyZHMKQW5kcnplagoKPgo+IFsxXSBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu
ZGluZ3MvZ3Bpby9ncGlvLnR4dC4KPgo+IFJlZ2FyZHMsCj4KPiBMaXUgWWluZwo+Cj4+IEFmdGVy
IGFkZHJlc3NpbmcgYWJvdmUgY29tbWVudHMgeW91IGNhbiBhZGQ6Cj4+Cj4+IFJldmlld2VkLWJ5
OiBBbmRyemVqIEhhamRhIDxhLmhhamRhQHNhbXN1bmcuY29tPgo+Pgo+Pgo+Pgo+PiBSZWdhcmRz
Cj4+IEFuZHJ6ZWoKPj4KPj4KPj4+ICsJfQo+Pj4gKwo+Pj4gKwlyZXQgPSBoeDgzNjlhX3Bvd2Vy
X29uKGN0eCk7Cj4+PiArCWlmIChyZXQgPCAwKSB7Cj4+PiArCQlkZXZfZXJyKGRldiwgImNhbm5v
dCBwb3dlciBvblxuIik7Cj4+PiArCQlyZXR1cm4gcmV0Owo+Pj4gKwl9Cj4+PiArCj4+PiArCWRy
bV9wYW5lbF9pbml0KCZjdHgtPnBhbmVsKTsKPj4+ICsJY3R4LT5wYW5lbC5kZXYgPSBkZXY7Cj4+
PiArCWN0eC0+cGFuZWwuZnVuY3MgPSAmaHg4MzY5YV9kc2lfZHJtX2Z1bmNzOwo+Pj4gKwo+Pj4g
KwlyZXQgPSBkcm1fcGFuZWxfYWRkKCZjdHgtPnBhbmVsKTsKPj4+ICsJaWYgKHJldCA8IDApCj4+
PiArCQlyZXR1cm4gcmV0Owo+Pj4gKwo+Pj4gKwltaXBpX2RzaV9zZXRfZHJ2ZGF0YShkc2ksIGN0
eCk7Cj4+PiArCj4+PiArCWRzaS0+bGFuZXMgPSBjdHgtPnBkLT5kc2lfbGFuZXM7Cj4+PiArCWRz
aS0+Zm9ybWF0ID0gTUlQSV9EU0lfRk1UX1JHQjg4ODsKPj4+ICsJZHNpLT5tb2RlX2ZsYWdzID0g
TUlQSV9EU0lfTU9ERV9WSURFTyB8Cj4+PiArCQkJICBNSVBJX0RTSV9NT0RFX1ZJREVPX0JVUlNU
IHwKPj4+ICsJCQkgIE1JUElfRFNJX01PREVfVklERU9fU1lOQ19QVUxTRTsKPj4+ICsJcmV0ID0g
bWlwaV9kc2lfYXR0YWNoKGRzaSk7Cj4+PiArCWlmIChyZXQgPCAwKQo+Pj4gKwkJZHJtX3BhbmVs
X3JlbW92ZSgmY3R4LT5wYW5lbCk7Cj4+PiArCj4+PiArCXJldHVybiByZXQ7Cj4+PiArfQo+Pj4g
Kwo+Pj4gK3N0YXRpYyBpbnQgaHg4MzY5YV9kc2lfcmVtb3ZlKHN0cnVjdCBtaXBpX2RzaV9kZXZp
Y2UgKmRzaSkKPj4+ICt7Cj4+PiArCXN0cnVjdCBoeDgzNjlhICpjdHggPSBtaXBpX2RzaV9nZXRf
ZHJ2ZGF0YShkc2kpOwo+Pj4gKwo+Pj4gKwltaXBpX2RzaV9kZXRhY2goZHNpKTsKPj4+ICsJZHJt
X3BhbmVsX3JlbW92ZSgmY3R4LT5wYW5lbCk7Cj4+PiArCXJldHVybiBoeDgzNjlhX3Bvd2VyX29m
ZihjdHgpOwo+Pj4gK30KPj4+ICsKPj4+ICtzdGF0aWMgc3RydWN0IG1pcGlfZHNpX2RyaXZlciBo
eDgzNjlhX2RzaV9kcml2ZXIgPSB7Cj4+PiArCS5wcm9iZSA9IGh4ODM2OWFfZHNpX3Byb2JlLAo+
Pj4gKwkucmVtb3ZlID0gaHg4MzY5YV9kc2lfcmVtb3ZlLAo+Pj4gKwkuZHJpdmVyID0gewo+Pj4g
KwkJLm5hbWUgPSAicGFuZWwtaHg4MzY5YS1kc2kiLAo+Pj4gKwkJLm9mX21hdGNoX3RhYmxlID0g
aHg4MzY5YV9kc2lfb2ZfbWF0Y2gsCj4+PiArCX0sCj4+PiArfTsKPj4+ICttb2R1bGVfbWlwaV9k
c2lfZHJpdmVyKGh4ODM2OWFfZHNpX2RyaXZlcik7Cj4+PiArCj4+PiArTU9EVUxFX0RFU0NSSVBU
SU9OKCJIaW1heCBIWDgzNjlBIHBhbmVsIGRyaXZlciIpOwo+Pj4gK01PRFVMRV9BVVRIT1IoIkxp
dSBZaW5nIDxZaW5nLkxpdUBmcmVlc2NhbGUuY29tPiIpOwo+Pj4gK01PRFVMRV9MSUNFTlNFKCJH
UEwgdjIiKTsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo
dHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751605AbaL2KvJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Dec 2014 05:51:09 -0500
Received: from mailout2.w1.samsung.com ([210.118.77.12]:27448 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751114AbaL2KvE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Dec 2014 05:51:04 -0500
X-AuditID: cbfec7f4-b7f126d000001e9a-1b-54a132142802
Message-id: <54A131FB.8040809@samsung.com>
Date: Mon, 29 Dec 2014 11:50:35 +0100
From: Andrzej Hajda <a.hajda@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.3.0
MIME-version: 1.0
To: Liu Ying <Ying.Liu@freescale.com>, dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux@arm.linux.org.uk, kernel@pengutronix.de, p.zabel@pengutronix.de,
        thierry.reding@gmail.com, shawn.guo@linaro.org, mturquette@linaro.org,
        airlied@linux.ie, andyshrk@gmail.com, stefan.wahren@i2se.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC v6 16/21] drm: panel: Add support for Himax HX8369A
 MIPI DSI panel
References: <1419835168-9034-1-git-send-email-Ying.Liu@freescale.com>
 <1419835168-9034-17-git-send-email-Ying.Liu@freescale.com>
 <54A11A65.1040509@samsung.com> <54A127D2.7080904@freescale.com>
In-reply-to: <54A127D2.7080904@freescale.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsVy+t/xa7oiRgtDDJpeilr0njvJZHH++Bdm
	i/lHzrFaXPn6ns1i1dSdLBabHl9jtbi8aw6bxe3LvBZPJ1xks7h77wSLxdN1S5gtNq24wWbx
	c9c8FosnT0wc+DxamnvYPP4d7mfy2DnrLrvH1lumHneu7WHz2P7tAavH/e7jTB6bl9R79P81
	8Pi8SS6AK4rLJiU1J7MstUjfLoEro/nvB+aCb/sYK/5dcmxg7JrJ2MXIySEhYCKxvusdK4Qt
	JnHh3nq2LkYuDiGBpYwSG35NYIVwPjFKPD9+iaWLkYODV0BLYnZbCEgDi4CqxJIZj5lAbDYB
	TYm/m2+ygdiiAhESH1Z9BbN5BQQlfky+xwJiiwi4SZx5/4gFZCazwDYmiaazT8GKhAViJBrn
	X2WEWHaEUeLxlJ9gHZwCuhLXLn9jBFnMLKAncf+iFkiYWUBeYvOat8wTGAVmIdkxC6FqFpKq
	BYzMqxhFU0uTC4qT0nMN9YoTc4tL89L1kvNzNzFCourLDsbFx6wOMQpwMCrx8CacWBAixJpY
	VlyZe4hRgoNZSYT3DM/CECHelMTKqtSi/Pii0pzU4kOMTBycUg2M1i3+br3ZC4qsen54/Uyv
	/3vilEqahb4/u9r0J5sWnXlp+jB+gvPZhlm731h/2M9zNU5xrrtbFucUw9TDlxT/BmywZc5j
	bV1+Ufids9FF1ic3DKyWhyomnvxctUeo6eeakvnf9/+7cml/3oQlsQV+SzrfvyrODwqrfXDy
	ZxTT839JDr3insUvlFiKMxINtZiLihMBF4+mT4gCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/29/2014 11:07 AM, Liu Ying wrote:
> On 12/29/2014 05:09 PM, Andrzej Hajda wrote:
>> On 12/29/2014 07:39 AM, Liu Ying wrote:
>>> This patch adds support for Himax HX8369A MIPI DSI panel.
>>>
>>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>>> ---
>>> v5->v6:
>>>   * Make the checkpatch.pl script be happier.
>>>   * Do not set the dsi channel number to be zero in probe(), because the MIPI DSI
>>>     bus driver would set it.
>>>
>>> v4->v5:
>>>   * Address Andrzej Hajda's comments.
>>>   * Get the bs-gpios property instead of the bs[3:0]-gpios properties.
>>>   * Implement error propagation for panel register configurations.
>>>   * Other minor changes to improve the code quality.
>>>
>>> v3->v4:
>>>   * Move the relevant dt-bindings to a separate patch to address Stefan
>>>     Wahren's comment.
>>>
>>> v2->v3:
>>>   * Sort the included header files alphabetically.
>>>
>>> v1->v2:
>>>   * Address almost all comments from Thierry Reding.
>>>   * Remove several DT properties as they can be implied by the compatible string.
>>>   * Add the HIMAX/himax prefixes to the driver's Kconfig name and driver name.
>>>   * Move the driver's Makefile entry place to sort the entries alphabetically.
>>>   * Reuse several standard DCS functions instead of inventing wheels.
>>>   * Move the panel resetting and power logics to the driver probe/remove stages.
>>>     This may simplify panel prepare/unprepare hooks. The power consumption should
>>>     not change a lot at DPMS since the panel enters sleep mode at that time.
>>>   * Add the module author.
>>>   * Other minor changes, such as coding style issues.
>>>
>>>   drivers/gpu/drm/panel/Kconfig               |   5 +
>>>   drivers/gpu/drm/panel/Makefile              |   1 +
>>>   drivers/gpu/drm/panel/panel-himax-hx8369a.c | 614 ++++++++++++++++++++++++++++
>>>   3 files changed, 620 insertions(+)
>>>   create mode 100644 drivers/gpu/drm/panel/panel-himax-hx8369a.c
>>>
>>> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
>>> index 024e98e..81b0bf0 100644
>>> --- a/drivers/gpu/drm/panel/Kconfig
>>> +++ b/drivers/gpu/drm/panel/Kconfig
>>> @@ -16,6 +16,11 @@ config DRM_PANEL_SIMPLE
>>>   	  that it can be automatically turned off when the panel goes into a
>>>   	  low power state.
>>>
>>> +config DRM_PANEL_HIMAX_HX8369A
>>> +	tristate "Himax HX8369A panel"
>>> +	depends on OF
>>> +	select DRM_MIPI_DSI
>>> +
>>>   config DRM_PANEL_LD9040
>>>   	tristate "LD9040 RGB/SPI panel"
>>>   	depends on OF && SPI
>>> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
>>> index 4b2a043..d5dbe06 100644
>>> --- a/drivers/gpu/drm/panel/Makefile
>>> +++ b/drivers/gpu/drm/panel/Makefile
>>> @@ -1,4 +1,5 @@
>>>   obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
>>> +obj-$(CONFIG_DRM_PANEL_HIMAX_HX8369A) += panel-himax-hx8369a.o
>>>   obj-$(CONFIG_DRM_PANEL_LD9040) += panel-ld9040.o
>>>   obj-$(CONFIG_DRM_PANEL_S6E8AA0) += panel-s6e8aa0.o
>>>   obj-$(CONFIG_DRM_PANEL_SHARP_LQ101R1SX01) += panel-sharp-lq101r1sx01.o
>>> diff --git a/drivers/gpu/drm/panel/panel-himax-hx8369a.c b/drivers/gpu/drm/panel/panel-himax-hx8369a.c
>>> new file mode 100644
>>> index 0000000..eee36a7
>>> --- /dev/null
>>> +++ b/drivers/gpu/drm/panel/panel-himax-hx8369a.c
>>> @@ -0,0 +1,614 @@
>>> +/*
>>> + * Himax HX8369A panel driver.
>>> + *
>>> + * Copyright (C) 2011-2014 Freescale Semiconductor, Inc.
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 as
>>> + * published by the Free Software Foundation.
>>> + *
>>> + * This driver is based on Samsung s6e8aa0 panel driver.
>>> + */
>>> +
>>> +#include <drm/drmP.h>
>>> +#include <drm/drm_mipi_dsi.h>
>>> +#include <drm/drm_panel.h>
>>> +
>>> +#include <linux/gpio/consumer.h>
>>> +#include <linux/of_device.h>
>>> +#include <linux/regulator/consumer.h>
>>> +
>>> +#include <video/mipi_display.h>
>>> +#include <video/of_videomode.h>
>>> +#include <video/videomode.h>
>>> +
>>> +#define WRDISBV		0x51
>>> +#define WRCTRLD		0x53
>>> +#define WRCABC		0x55
>>> +#define SETPOWER	0xb1
>>> +#define SETDISP		0xb2
>>> +#define SETCYC		0xb4
>>> +#define SETVCOM		0xb6
>>> +#define SETEXTC		0xb9
>>> +#define SETMIPI		0xba
>>> +#define SETPANEL	0xcc
>>> +#define SETGIP		0xd5
>>> +#define SETGAMMA	0xe0
>>> +
>>> +#define HX8369A_MIN_BRIGHTNESS	0x00
>>> +#define HX8369A_MAX_BRIGHTNESS	0xff
>>> +
>>> +enum hx8369a_mpu_interface {
>>> +	HX8369A_DBI_TYPE_A_8BIT,
>>> +	HX8369A_DBI_TYPE_A_9BIT,
>>> +	HX8369A_DBI_TYPE_A_16BIT,
>>> +	HX8369A_DBI_TYPE_A_18BIT,
>>> +	HX8369A_DBI_TYPE_B_8BIT,
>>> +	HX8369A_DBI_TYPE_B_9BIT,
>>> +	HX8369A_DBI_TYPE_B_16BIT,
>>> +	HX8369A_DBI_TYPE_B_18BIT,
>>> +	HX8369A_DSI_CMD_MODE,
>>> +	HX8369A_DBI_TYPE_B_24BIT,
>>> +	HX8369A_DSI_VIDEO_MODE,
>>> +	HX8369A_MDDI,
>>> +	HX8369A_DPI_DBI_TYPE_C_OPT1,
>>> +	HX8369A_DPI_DBI_TYPE_C_OPT2,
>>> +	HX8369A_DPI_DBI_TYPE_C_OPT3
>>> +};
>>> +
>>> +enum hx8369a_resolution {
>>> +	HX8369A_RES_480_864,
>>> +	HX8369A_RES_480_854,
>>> +	HX8369A_RES_480_800,
>>> +	HX8369A_RES_480_640,
>>> +	HX8369A_RES_360_640,
>>> +	HX8369A_RES_480_720,
>>> +};
>>> +
>>> +struct hx8369a_panel_desc {
>>> +	const struct drm_display_mode *mode;
>>> +
>>> +	/* ms */
>>> +	unsigned int power_on_delay;
>>> +	unsigned int reset_delay;
>>> +
>>> +	unsigned int dsi_lanes;
>>> +};
>>> +
>>> +struct hx8369a {
>>> +	struct device *dev;
>>> +	struct drm_panel panel;
>>> +
>>> +	const struct hx8369a_panel_desc *pd;
>>> +
>>> +	struct regulator_bulk_data supplies[5];
>>> +	struct gpio_desc *reset_gpio;
>>> +	struct gpio_desc *bs_gpio[4];
>>> +	u8 res_sel;
>>> +};
>>> +
>>> +static inline struct hx8369a *panel_to_hx8369a(struct drm_panel *panel)
>>> +{
>>> +	return container_of(panel, struct hx8369a, panel);
>>> +}
>>> +
>>> +static int hx8369a_dcs_write(struct hx8369a *ctx, const char *func,
>>> +			     const void *data, size_t len)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	ssize_t ret;
>>> +
>>> +	ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "%s failed: %d\n", func, ret);
>>> +		return ret;
>>> +	}
>>> +	return 0;
>> Nitpick. You can replace 4 lines above with:
>>      if (ret < 0)
>>          dev_err(ctx->dev, "%s failed: %d\n", func, ret);
>>      return ret;
> I'll do that.
>
>>> +}
>>> +
>>> +#define hx8369a_dcs_write_seq(ctx, seq...) \
>>> +({ \
>>> +	const u8 d[] = { seq }; \
>>> +	BUILD_BUG_ON_MSG(ARRAY_SIZE(d) > 64, \
>>> +			 "DCS sequence too big for stack"); \
>>> +	hx8369a_dcs_write(ctx, __func__, d, ARRAY_SIZE(d)); \
>>> +})
>>> +
>>> +#define hx8369a_dcs_write_seq_static(ctx, seq...) \
>>> +({ \
>>> +	static const u8 d[] = { seq }; \
>>> +	hx8369a_dcs_write(ctx, __func__, d, ARRAY_SIZE(d)); \
>>> +})
>>> +
>>> +static int hx8369a_dsi_set_display_related_register(struct hx8369a *ctx)
>>> +{
>>> +	u8 sec_p = (ctx->res_sel << 4) | 0x03;
>>> +
>>> +	return hx8369a_dcs_write_seq(ctx, SETDISP, 0x00, sec_p, 0x03,
>>> +			   0x03, 0x70, 0x00, 0xff, 0x00, 0x00, 0x00,
>>> +			   0x00, 0x03, 0x03, 0x00, 0x01);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_display_waveform_cycle(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETCYC, 0x00, 0x1d,
>>> +					0x5f, 0x0e, 0x06);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_gip(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETGIP, 0x00, 0x04,
>>> +				 0x03, 0x00, 0x01, 0x05, 0x1c, 0x70,
>>> +				 0x01, 0x03, 0x00, 0x00, 0x40, 0x06,
>>> +				 0x51, 0x07, 0x00, 0x00, 0x41, 0x06,
>>> +				 0x50, 0x07, 0x07, 0x0f, 0x04);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_power(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETPOWER, 0x01, 0x00,
>>> +				   0x34, 0x06, 0x00, 0x0f, 0x0f, 0x2a,
>>> +				   0x32, 0x3f, 0x3f, 0x07, 0x3a, 0x01,
>>> +				   0xe6, 0xe6, 0xe6, 0xe6, 0xe6);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_vcom_voltage(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETVCOM, 0x56, 0x56);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_panel(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETPANEL, 0x02);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_gamma_curve(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETGAMMA, 0x00, 0x1d,
>>> +				   0x22, 0x38, 0x3d, 0x3f, 0x2e, 0x4a,
>>> +				   0x06, 0x0d, 0x0f, 0x13, 0x15, 0x13,
>>> +				   0x16, 0x10, 0x19, 0x00, 0x1d, 0x22,
>>> +				   0x38, 0x3d, 0x3f, 0x2e, 0x4a, 0x06,
>>> +				   0x0d, 0x0f, 0x13, 0x15, 0x13, 0x16,
>>> +				   0x10, 0x19);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_mipi(struct hx8369a *ctx)
>>> +{
>>> +	u8 eleventh_p = ctx->pd->dsi_lanes == 2 ? 0x11 : 0x10;
>>> +
>>> +	return hx8369a_dcs_write_seq(ctx, SETMIPI, 0x00, 0xa0, 0xc6,
>>> +				 0x00, 0x0a, 0x00, 0x10, 0x30, 0x6f,
>>> +				 0x02, eleventh_p, 0x18, 0x40);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_interface_pixel_fomat(struct hx8369a *ctx)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	u8 format;
>>> +	int ret;
>>> +
>>> +	switch (dsi->format) {
>>> +	case MIPI_DSI_FMT_RGB888:
>>> +	case MIPI_DSI_FMT_RGB666:
>>> +		format = 0x77;
>>> +		break;
>>> +	case MIPI_DSI_FMT_RGB565:
>>> +		format = 0x55;
>>> +		break;
>>> +	case MIPI_DSI_FMT_RGB666_PACKED:
>>> +		format = 0x66;
>>> +		break;
>>> +	default:
>>> +		dev_err(ctx->dev, "unsupported DSI pixel format\n");
>>> +		return -EINVAL;
>>> +	}
>>> +
>>> +	ret = mipi_dsi_dcs_set_pixel_format(dsi, format);
>>> +	if (ret < 0)
>>> +		dev_err(ctx->dev, "%s failed: %d\n", __func__, ret);
>>> +	return ret;
>>> +}
>> This functions could be also DSI helper, it is not specific to this panel,
>> but it is just a suggestion.
> Any documentation can reflect this could be a common DSI helper,
> maybe the MIPI DSI spec?
> I wrote this function by taking the HX8369A panel data sheet as a
> reference.

MIPI DSI specification describes MIPI_DSI_FMT_* values and
MIPI DCS specification describes 'format' values (ie. 0x77, 0x55, 0x66).
For reference please look for phrase "Table 6 Interface Pixel Formats" in
MIPI DCS specification (or in google :) ).

>
>>> +
>>> +static int hx8369a_dsi_set_column_address(struct hx8369a *ctx)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	const struct drm_display_mode *mode = ctx->pd->mode;
>>> +	int ret;
>>> +
>>> +	ret = mipi_dsi_dcs_set_column_address(dsi, 0, mode->hdisplay - 1);
>>> +	if (ret < 0)
>>> +		dev_err(ctx->dev, "%s failed: %d\n", __func__, ret);
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_page_address(struct hx8369a *ctx)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	const struct drm_display_mode *mode = ctx->pd->mode;
>>> +	int ret;
>>> +
>>> +	ret = mipi_dsi_dcs_set_page_address(dsi, 0, mode->vdisplay - 1);
>>> +	if (ret < 0)
>>> +		dev_err(ctx->dev, "%s failed: %d\n", __func__, ret);
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_write_display_brightness(struct hx8369a *ctx,
>>> +						u8 brightness)
>>> +{
>>> +	return hx8369a_dcs_write_seq(ctx, WRDISBV, brightness);
>>> +}
>>> +
>>> +static int hx8369a_dsi_write_cabc(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, WRCABC, 0x01);
>>> +}
>>> +
>>> +static int hx8369a_dsi_write_control_display(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, WRCTRLD, 0x24);
>>> +}
>>> +
>>> +#define hx8369a_dsi_init_helper(ctx, ret, name) \
>>> +({ \
>>> +	ret = hx8369a_dsi_##name(ctx); \
>>> +	if (ret < 0) \
>>> +		return ret; \
>>> +})
>> Yeah, another hack to get rid of redundant code :)
>> Two ugly things here: ## and return from macro.
>>
>>> +
>>> +static int hx8369a_dsi_panel_init(struct hx8369a *ctx)
>>> +{
>>> +	int ret;
>>> +
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_display_related_register);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_display_waveform_cycle);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_gip);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_power);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_vcom_voltage);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_panel);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_gamma_curve);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_mipi);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_interface_pixel_fomat);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_column_address);
>>> +	hx8369a_dsi_init_helper(ctx, ret, set_page_address);
>>> +	hx8369a_dsi_init_helper(ctx, ret, write_cabc);
>>> +	hx8369a_dsi_init_helper(ctx, ret, write_control_display);
>> Maybe it would be better to replace the hack above with something like:
>> {
>>      int (*)(struct hx8369a *ctx) funcs[] = {
>>          hx8369a_dsi_set_display_related_register,
>>          hx8369a_dsi_set_display_waveform_cycle,
>>          ...
>>       };
>>      int ret, i;
>>
>>      for (i = 0; i < ARRAY_SIZE(funcs); ++i) {
>>          ret = funcs[i](ctx);
>>          if (ret)
>>              return ret;
>>      }
> I'll change to use this.  Thanks.
>
>>> +
>>> +	return 0;
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_extension_command(struct hx8369a *ctx)
>>> +{
>>> +	return hx8369a_dcs_write_seq_static(ctx, SETEXTC, 0xff, 0x83, 0x69);
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_maximum_return_packet_size(struct hx8369a *ctx,
>>> +						      u16 size)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	int ret;
>>> +
>>> +	ret = mipi_dsi_set_maximum_return_packet_size(dsi, size);
>>> +	if (ret < 0)
>>> +		dev_err(ctx->dev,
>>> +			"error %d setting maximum return packet size to %d\n",
>>> +			ret, size);
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_set_sequence(struct hx8369a *ctx)
>>> +{
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	int ret;
>>> +
>>> +	ret = hx8369a_dsi_set_extension_command(ctx);
>>> +	if (ret < 0)
>>> +		goto out;
>>> +
>>> +	ret = hx8369a_dsi_set_maximum_return_packet_size(ctx, 4);
>>> +	if (ret < 0)
>>> +		goto out;
>>> +
>>> +	ret = hx8369a_dsi_panel_init(ctx);
>>> +	if (ret < 0)
>>> +		goto out;
>>> +
>>> +	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "failed to exit sleep mode: %d\n", ret);
>>> +		goto out;
>>> +	}
>>> +
>>> +	ret = mipi_dsi_dcs_set_display_on(dsi);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "failed to set display on: %d\n", ret);
>>> +		goto out;
>>> +	}
>>> +
>>> +	/*
>>> +	 * It's necessary to wait 120msec after sending the Sleep Out
>>> +	 * command before Sleep In command can be sent, according to
>>> +	 * the HX8369A data sheet.
>>> +	 */
>>> +	msleep(120);
>>> +out:
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_disable(struct drm_panel *panel)
>>> +{
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +
>>> +	return hx8369a_dsi_write_display_brightness(ctx,
>>> +						HX8369A_MIN_BRIGHTNESS);
>>> +}
>>> +
>>> +static int hx8369a_dsi_unprepare(struct drm_panel *panel)
>>> +{
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +	struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>>> +	int ret;
>>> +
>>> +	ret = mipi_dsi_dcs_enter_sleep_mode(dsi);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret);
>>> +		goto out;
>>> +	}
>>> +
>>> +	ret = mipi_dsi_dcs_set_display_off(dsi);
>>> +	if (ret < 0) {
>>> +		dev_err(ctx->dev, "failed to set display off: %d\n", ret);
>>> +		goto out;
>>> +	}
>>> +
>>> +	/*
>>> +	 * This is to allow time for the supply voltages and clock
>>> +	 * circuits to stablize, according to the HX8369A data sheet.
>>> +	 */
>>> +	msleep(5);
>>> +out:
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_prepare(struct drm_panel *panel)
>>> +{
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +
>>> +	return hx8369a_dsi_set_sequence(ctx);
>>> +}
>>> +
>>> +static int hx8369a_dsi_enable(struct drm_panel *panel)
>>> +{
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +
>>> +	return hx8369a_dsi_write_display_brightness(ctx,
>>> +						HX8369A_MAX_BRIGHTNESS);
>>> +}
>>> +
>>> +static int hx8369a_get_modes(struct drm_panel *panel)
>>> +{
>>> +	struct drm_connector *connector = panel->connector;
>>> +	struct drm_device *drm = panel->drm;
>>> +	struct hx8369a *ctx = panel_to_hx8369a(panel);
>>> +	struct drm_display_mode *mode;
>>> +	const struct drm_display_mode *m = ctx->pd->mode;
>>> +
>>> +	mode = drm_mode_duplicate(drm, m);
>>> +	if (!mode) {
>>> +		dev_err(drm->dev, "failed to add mode %ux%u@%u\n",
>>> +			m->hdisplay, m->vdisplay, m->vrefresh);
>>> +		return 0;
>>> +	}
>>> +
>>> +	drm_mode_set_name(mode);
>>> +	mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
>>> +
>>> +	connector->display_info.bpc = 8;
>>> +	connector->display_info.width_mm = mode->width_mm;
>>> +	connector->display_info.height_mm = mode->height_mm;
>>> +
>>> +	drm_mode_probed_add(connector, mode);
>>> +
>>> +	return 1;
>>> +}
>>> +
>>> +static const struct drm_panel_funcs hx8369a_dsi_drm_funcs = {
>>> +	.disable = hx8369a_dsi_disable,
>>> +	.unprepare = hx8369a_dsi_unprepare,
>>> +	.prepare = hx8369a_dsi_prepare,
>>> +	.enable = hx8369a_dsi_enable,
>>> +	.get_modes = hx8369a_get_modes,
>>> +};
>>> +
>>> +static int hx8369a_power_on(struct hx8369a *ctx)
>>> +{
>>> +	int ret;
>>> +
>>> +	ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
>>> +	if (ret < 0)
>>> +		return ret;
>>> +
>>> +	msleep(ctx->pd->power_on_delay);
>>> +
>>> +	gpiod_set_value(ctx->reset_gpio, 1);
>>> +	usleep_range(50, 60);
>>> +	gpiod_set_value(ctx->reset_gpio, 0);
>>> +
>>> +	msleep(ctx->pd->reset_delay);
>>> +
>>> +	return 0;
>>> +}
>>> +
>>> +static int hx8369a_power_off(struct hx8369a *ctx)
>>> +{
>>> +	return regulator_bulk_disable(ARRAY_SIZE(ctx->supplies),
>>> +				      ctx->supplies);
>>> +}
>>> +
>>> +static void hx8369a_vm_to_res_sel(struct hx8369a *ctx)
>>> +{
>>> +	const struct drm_display_mode *mode = ctx->pd->mode;
>>> +
>>> +	switch (mode->hdisplay) {
>>> +	case 480:
>>> +		switch (mode->vdisplay) {
>>> +		case 864:
>>> +			ctx->res_sel = HX8369A_RES_480_864;
>>> +			break;
>>> +		case 854:
>>> +			ctx->res_sel = HX8369A_RES_480_854;
>>> +			break;
>>> +		case 800:
>>> +			ctx->res_sel = HX8369A_RES_480_800;
>>> +			break;
>>> +		case 640:
>>> +			ctx->res_sel = HX8369A_RES_480_640;
>>> +			break;
>>> +		case 720:
>>> +			ctx->res_sel = HX8369A_RES_480_720;
>>> +			break;
>>> +		default:
>>> +			break;
>>> +		}
>>> +		break;
>>> +	case 360:
>>> +		if (mode->vdisplay == 640)
>>> +			ctx->res_sel = HX8369A_RES_360_640;
>>> +		break;
>>> +	default:
>>> +		break;
>>> +	}
>>> +}
>>> +
>>> +static const struct drm_display_mode truly_tft480800_16_e_mode = {
>>> +	.clock = 26400,
>>> +	.hdisplay = 480,
>>> +	.hsync_start = 480 + 8,
>>> +	.hsync_end = 480 + 8 + 8,
>>> +	.htotal = 480 + 8 + 8 + 8,
>>> +	.vdisplay = 800,
>>> +	.vsync_start = 800 + 6,
>>> +	.vsync_end = 800 + 6 + 6,
>>> +	.vtotal = 800 + 6 + 6 + 6,
>>> +	.vrefresh = 60,
>>> +	.width_mm = 45,
>>> +	.height_mm = 76,
>>> +};
>>> +
>>> +static const struct hx8369a_panel_desc truly_tft480800_16_e_dsi = {
>>> +	.mode = &truly_tft480800_16_e_mode,
>>> +	.power_on_delay = 10,
>>> +	.reset_delay = 10,
>>> +	.dsi_lanes = 2,
>>> +};
>>> +
>>> +static const struct of_device_id hx8369a_dsi_of_match[] = {
>>> +	{
>>> +		.compatible = "truly,tft480800-16-e-dsi",
>>> +		.data = &truly_tft480800_16_e_dsi,
>>> +	}, {
>>> +		/* sentinel */
>>> +	},
>>> +};
>>> +MODULE_DEVICE_TABLE(of, hx8369a_dsi_of_match);
>>> +
>>> +static int hx8369a_dsi_probe(struct mipi_dsi_device *dsi)
>>> +{
>>> +	struct device *dev = &dsi->dev;
>>> +	const struct of_device_id *of_id =
>>> +			of_match_device(hx8369a_dsi_of_match, dev);
>>> +	struct hx8369a *ctx;
>>> +	int ret, i;
>>> +
>>> +	ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
>>> +	if (!ctx)
>>> +		return -ENOMEM;
>>> +
>>> +	ctx->dev = dev;
>>> +
>>> +	if (of_id) {
>>> +		ctx->pd = of_id->data;
>>> +	} else {
>>> +		dev_err(dev, "cannot find compatible device\n");
>>> +		return -ENODEV;
>>> +	}
>>> +
>>> +	hx8369a_vm_to_res_sel(ctx);
>>> +
>>> +	ctx->supplies[0].supply = "vdd1";
>>> +	ctx->supplies[1].supply = "vdd2";
>>> +	ctx->supplies[2].supply = "vdd3";
>>> +	ctx->supplies[3].supply = "dsi-vcc";
>>> +	ctx->supplies[4].supply = "vpp";
>>> +	ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies),
>>> +				      ctx->supplies);
>>> +	if (ret < 0) {
>>> +		dev_info(dev, "failed to get regulators: %d\n", ret);
>>> +		return ret;
>>> +	}
>>> +
>>> +	ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>>> +	if (IS_ERR(ctx->reset_gpio)) {
>>> +		dev_info(dev, "cannot get reset-gpios %ld\n",
>>> +			 PTR_ERR(ctx->reset_gpio));
>>> +		return PTR_ERR(ctx->reset_gpio);
>>> +	}
>>> +
>>> +	for (i = 0; i < 4; i++) {
>>> +		ctx->bs_gpio[i] = devm_gpiod_get_index(dev, "bs", i,
>>> +							GPIOD_OUT_HIGH);
>>> +		if (!IS_ERR_OR_NULL(ctx->bs_gpio[i]))
>>> +			dev_dbg(dev, "bs%d-gpio is configured\n", i);
>> Are you sure you want to continue probe on error during getting gpios?
> There could be holes in the gpio list as mentioned in [1].
> For this panel, the potential holes mean that the relevant
> gpios are not controlled by the driver but only by the
> hardware.
>
> Perhaps, I need to handle the error case.
> I tried to implement it in the following way.
>
> ctx->bs_gpio[i] = devm_gpiod_get_index(dev, "bs", i,
>                                         GPIOD_OUT_HIGH);
> if (!IS_ERR_OR_NULL(ctx->bs_gpio[i])) {
>      dev_dbg(dev, "bs%d-gpio is configured\n", i);
> } else if (IS_ERR(ctx->bs_gpio[i])) {
>      dev_info(dev, "failed to get bs%d-gpio\n", i);
>      return PTR_ERR(ctx->bs_gpio[i]);
> }
>
> But, I get this in dmesg.  Any idea?
> [    1.625634] panel-hx8369a-dsi 21e0000.mipi.0: failed to get bs0-gpio
> [    1.633060] panel-hx8369a-dsi: probe of 21e0000.mipi.0 failed with 
> error -2

I guess you should use devm_gpiod_get_index_optional .

Regards
Andrzej

>
> [1] Documentation/devicetree/bindings/gpio/gpio.txt.
>
> Regards,
>
> Liu Ying
>
>> After addressing above comments you can add:
>>
>> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>>
>>
>>
>> Regards
>> Andrzej
>>
>>
>>> +	}
>>> +
>>> +	ret = hx8369a_power_on(ctx);
>>> +	if (ret < 0) {
>>> +		dev_err(dev, "cannot power on\n");
>>> +		return ret;
>>> +	}
>>> +
>>> +	drm_panel_init(&ctx->panel);
>>> +	ctx->panel.dev = dev;
>>> +	ctx->panel.funcs = &hx8369a_dsi_drm_funcs;
>>> +
>>> +	ret = drm_panel_add(&ctx->panel);
>>> +	if (ret < 0)
>>> +		return ret;
>>> +
>>> +	mipi_dsi_set_drvdata(dsi, ctx);
>>> +
>>> +	dsi->lanes = ctx->pd->dsi_lanes;
>>> +	dsi->format = MIPI_DSI_FMT_RGB888;
>>> +	dsi->mode_flags = MIPI_DSI_MODE_VIDEO |
>>> +			  MIPI_DSI_MODE_VIDEO_BURST |
>>> +			  MIPI_DSI_MODE_VIDEO_SYNC_PULSE;
>>> +	ret = mipi_dsi_attach(dsi);
>>> +	if (ret < 0)
>>> +		drm_panel_remove(&ctx->panel);
>>> +
>>> +	return ret;
>>> +}
>>> +
>>> +static int hx8369a_dsi_remove(struct mipi_dsi_device *dsi)
>>> +{
>>> +	struct hx8369a *ctx = mipi_dsi_get_drvdata(dsi);
>>> +
>>> +	mipi_dsi_detach(dsi);
>>> +	drm_panel_remove(&ctx->panel);
>>> +	return hx8369a_power_off(ctx);
>>> +}
>>> +
>>> +static struct mipi_dsi_driver hx8369a_dsi_driver = {
>>> +	.probe = hx8369a_dsi_probe,
>>> +	.remove = hx8369a_dsi_remove,
>>> +	.driver = {
>>> +		.name = "panel-hx8369a-dsi",
>>> +		.of_match_table = hx8369a_dsi_of_match,
>>> +	},
>>> +};
>>> +module_mipi_dsi_driver(hx8369a_dsi_driver);
>>> +
>>> +MODULE_DESCRIPTION("Himax HX8369A panel driver");
>>> +MODULE_AUTHOR("Liu Ying <Ying.Liu@freescale.com>");
>>> +MODULE_LICENSE("GPL v2");