All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Li Bin <huawei.libin@huawei.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Dave Jones <davej@redhat.com>,
	rui.xiang@huawei.com, wengmeiling.weng@huawei.com
Subject: Re: sched: spinlock recursion in sched_rr_get_interval
Date: Mon, 29 Dec 2014 09:22:02 -0500	[thread overview]
Message-ID: <54A1638A.1050800@oracle.com> (raw)
In-Reply-To: <1419797834.8667.8.camel@stgolabs.net>

On 12/28/2014 03:17 PM, Davidlohr Bueso wrote:
> On Sat, 2014-12-27 at 10:52 -0500, Sasha Levin wrote:
>> > There's a chance that lock->owner would change, but how would you explain
>> > it changing to 'current'?
> So yeah, the above only deals with the weird printk values, not the
> actual issue that triggers the BUG_ON. Lets sort this out first and at
> least get correct data.

Is there an issue with weird printk values? I haven't seen a report of
something like that, nor have seen it myself.

>> > That is, what race condition specifically creates the
>> > 'lock->owner == current' situation in the debug check?
> Why do you suspect a race as opposed to a legitimate recursion issue?
> Although after staring at the code for a while, I cannot see foul play
> in sched_rr_get_interval.
> 
> Given that all reports show bogus contending CPU and .owner_cpu, I do
> wonder if this is actually a symptom of the BUG_ON where something fishy
> is going on.. although I have no evidence to support that. I also ran
> into this https://lkml.org/lkml/2014/11/7/762 which shows the same bogus
> values yet a totally different stack.
> 
> Sasha, I ran trinity with CONFIG_DEBUG_SPINLOCK=y all night without
> triggering anything. How are you hitting this?

I don't have any reliable way of reproducing it. The only two things I
can think of are:

 - Try running as root in a disposable vm
 - Try running with really high load (I use ~800 children on 16 vcpu
guests).


Thanks,
Sasha

  reply	other threads:[~2014-12-29 14:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-06 17:27 sched: spinlock recursion in sched_rr_get_interval Sasha Levin
2014-07-07  8:30 ` Peter Zijlstra
2014-07-07 13:55   ` Sasha Levin
2014-07-07 20:05     ` Peter Zijlstra
2014-07-07 22:47       ` Sasha Levin
2014-07-28 23:08         ` Sasha Levin
2014-09-17  9:13       ` Jovi Zhangwei
2014-12-26  6:45       ` Li Bin
2014-12-26  7:01         ` Sasha Levin
2014-12-27  9:02           ` Li Bin
2014-12-27  9:52         ` Davidlohr Bueso
2014-12-27 15:52           ` Sasha Levin
2014-12-28 20:17             ` Davidlohr Bueso
2014-12-29 14:22               ` Sasha Levin [this message]
2014-12-30  1:04               ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54A1638A.1050800@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=dave@stgolabs.net \
    --cc=davej@redhat.com \
    --cc=huawei.libin@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rui.xiang@huawei.com \
    --cc=wengmeiling.weng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.