From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH 6/6] bridge: add vlan info to bridge setlink and dellink notification messages Date: Mon, 29 Dec 2014 21:41:24 -0800 Message-ID: <54A23B04.4010501@cumulusnetworks.com> References: <1419887132-7084-7-git-send-email-roopa@cumulusnetworks.com> <54A2355B.6060903@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Netdev , shemminger@vyatta.com, "vyasevic@redhat.com" , Wilson Kok To: Scott Feldman Return-path: Received: from mail-pa0-f52.google.com ([209.85.220.52]:60787 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbaL3FlZ (ORCPT ); Tue, 30 Dec 2014 00:41:25 -0500 Received: by mail-pa0-f52.google.com with SMTP id eu11so18964355pac.39 for ; Mon, 29 Dec 2014 21:41:25 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 12/29/14, 9:25 PM, Scott Feldman wrote: > On Mon, Dec 29, 2014 at 9:17 PM, roopa wrote: >> On 12/29/14, 3:42 PM, Scott Feldman wrote: >>> On Mon, Dec 29, 2014 at 1:05 PM, wrote: >>>> From: Roopa Prabhu >>>> >>>> vlan add/deletes are not notified to userspace today. This patch fixes >>>> it. >>>> Notifications will contain vlans compressed into ranges whereever >>>> applicable. >>> Why is this notification needed? On VLAN add/del, the port driver >>> will already get called if it implements ndo_vlan_rx_add_vid and >>> ndo_vlan_rx_kill_vid. >> This is strictly for userspace. >> >>> The port driver already gets the notification >>> it needs to filter vlans. User space can query for vlan port >>> membership if it needs to know. >> >> You mean request a dump ?. yes it can if it needs all the configured vlans. >> But for notifications, we must at the least notify what changed with respect >> to vlans with RTM_SETLINK/DELLINK, no ? > You'll get that notification if you implement ndo_vlan_rx_add/kill_vid > in your port driver, which is called from RTM_SETLINK/DELLINK. Your > port driver can send to user-space, I suppose, if user-space needs > notification. When the bridge is a vlan filtering bridge, I think its the bridge driver who will need to send notifications to vlan add/dels on PF_BRIDGE similar to fdb add/dels.