From: "Michael Kerrisk (man-pages)" <mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Laurent Georget
<laurent.georget-vbcOdlJ0SulGWvitb5QawA@public.gmane.org>,
linux-man <linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2 v3] adjtimex.2: add fields in struct timex description
Date: Tue, 30 Dec 2014 13:54:04 +0100 [thread overview]
Message-ID: <54A2A06C.203@gmail.com> (raw)
In-Reply-To: <547AEE16.20603-vbcOdlJ0SulGWvitb5QawA@public.gmane.org>
Hello Laurent,
Sorry for the delayed follow up...
On 11/30/2014 11:14 AM, Laurent Georget wrote:
> Hello,
>
> this is a refactored series of patches for adjtimex(2) man page. Please
> ignore all previous patches I sent for adjtimex.2.
Thanks for the clear note about disregarding previous versions. That
makes things much simpler for me.
> The first patch updates the man page with the new fields added in struct
> timex since last edition of the man page.
>
> Thank you for your time. These are my first patches so you may have to
> bear with me being a little inexpert and clumsy for some time. I
> apologize for that.
I've applied the patch. Note one point/question below.
> diff --git a/man2/adjtimex.2 b/man2/adjtimex.2
> index eb3fda1..0b919c5 100644
> --- a/man2/adjtimex.2
> +++ b/man2/adjtimex.2
> @@ -73,6 +73,15 @@ struct timex {
> (read-only) */
> struct timeval time; /* current time (read-only) */
> long tick; /* usecs between clock ticks */
> + long ppsfreq; /* pps frequency (scaled ppm) (read-only) */
> + long jitter; /* pps jitter (usec) (read-only) */
> + int shift; /* interval duration (sec) (read-only) */
> + long stabil; /* pps stability (scaled ppm) (read-only) */
> + long jitcnt; /* jitter limit exceeded (read-only) */
> + long calcnt; /* calibration intervals (read-only) */
> + long errcnt; /* calibration errors (read-only) */
> + long stbcnt; /* stability limit exceeded (read-only) */
> + int tai; /* TAI offset (s) (read-only) */
> };
Presumably, '(s)' means seconds, right?
I changed this to to '(sec)' for consistency with the other
comments above.
Thanks,
Michael`
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Laurent Georget <laurent.georget@supelec.fr>,
linux-man <linux-man@vger.kernel.org>
Cc: mtk.manpages@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2 v3] adjtimex.2: add fields in struct timex description
Date: Tue, 30 Dec 2014 13:54:04 +0100 [thread overview]
Message-ID: <54A2A06C.203@gmail.com> (raw)
In-Reply-To: <547AEE16.20603@supelec.fr>
Hello Laurent,
Sorry for the delayed follow up...
On 11/30/2014 11:14 AM, Laurent Georget wrote:
> Hello,
>
> this is a refactored series of patches for adjtimex(2) man page. Please
> ignore all previous patches I sent for adjtimex.2.
Thanks for the clear note about disregarding previous versions. That
makes things much simpler for me.
> The first patch updates the man page with the new fields added in struct
> timex since last edition of the man page.
>
> Thank you for your time. These are my first patches so you may have to
> bear with me being a little inexpert and clumsy for some time. I
> apologize for that.
I've applied the patch. Note one point/question below.
> diff --git a/man2/adjtimex.2 b/man2/adjtimex.2
> index eb3fda1..0b919c5 100644
> --- a/man2/adjtimex.2
> +++ b/man2/adjtimex.2
> @@ -73,6 +73,15 @@ struct timex {
> (read-only) */
> struct timeval time; /* current time (read-only) */
> long tick; /* usecs between clock ticks */
> + long ppsfreq; /* pps frequency (scaled ppm) (read-only) */
> + long jitter; /* pps jitter (usec) (read-only) */
> + int shift; /* interval duration (sec) (read-only) */
> + long stabil; /* pps stability (scaled ppm) (read-only) */
> + long jitcnt; /* jitter limit exceeded (read-only) */
> + long calcnt; /* calibration intervals (read-only) */
> + long errcnt; /* calibration errors (read-only) */
> + long stbcnt; /* stability limit exceeded (read-only) */
> + int tai; /* TAI offset (s) (read-only) */
> };
Presumably, '(s)' means seconds, right?
I changed this to to '(sec)' for consistency with the other
comments above.
Thanks,
Michael`
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
next prev parent reply other threads:[~2014-12-30 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 10:14 [PATCH 1/2 v3] adjtimex.2: add fields in struct timex description Laurent Georget
2014-11-30 10:14 ` Laurent Georget
[not found] ` <547AEE16.20603-vbcOdlJ0SulGWvitb5QawA@public.gmane.org>
2014-12-30 12:54 ` Michael Kerrisk (man-pages) [this message]
2014-12-30 12:54 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A2A06C.203@gmail.com \
--to=mtk.manpages-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=laurent.georget-vbcOdlJ0SulGWvitb5QawA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.