From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lb0-f170.google.com ([209.85.217.170]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y60Rx-0007T1-SH for ath10k@lists.infradead.org; Tue, 30 Dec 2014 17:19:18 +0000 Received: by mail-lb0-f170.google.com with SMTP id 10so12597492lbg.29 for ; Tue, 30 Dec 2014 09:18:55 -0800 (PST) Message-ID: <54A2DE7C.1050602@cogentembedded.com> Date: Tue, 30 Dec 2014 20:18:52 +0300 From: Sergei Shtylyov MIME-Version: 1.0 Subject: Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up References: <1419942046-17985-1-git-send-email-der.herr@hofr.at> In-Reply-To: <1419942046-17985-1-git-send-email-der.herr@hofr.at> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Nicholas Mc Guire , Kalle Valo Cc: Chun-Yeow Yeoh , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Michal Kazior , Yanbo Li , Ben Greear Hello. On 12/30/2014 03:20 PM, Nicholas Mc Guire wrote: > wait_for_completion_timeout does not return negative values so the tests > for <= 0 are not needed and the case differentiation in the error handling > path unnecessary. I decided to verify your statement and I saw that it seems wrong. do_wait_for_common() can return -ERESTARTSYS and the return value gets returned by its callers unchanged. > patch was only compile tested x86_64_defconfig + CONFIG_ATH_CARDS=m > CONFIG_ATH10K=m > patch is against linux-next 3.19.0-rc1 -next-20141226 Rather patches. It would have been better to send one patch instead of 4 patches with the same name. WBR, Sergei _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-f41.google.com ([209.85.215.41]:65122 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbaL3RS4 (ORCPT ); Tue, 30 Dec 2014 12:18:56 -0500 Received: by mail-la0-f41.google.com with SMTP id hv19so12840754lab.0 for ; Tue, 30 Dec 2014 09:18:55 -0800 (PST) Message-ID: <54A2DE7C.1050602@cogentembedded.com> (sfid-20141230_181922_603172_DE47A975) Date: Tue, 30 Dec 2014 20:18:52 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: Nicholas Mc Guire , Kalle Valo CC: Michal Kazior , Ben Greear , Chun-Yeow Yeoh , Yanbo Li , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up References: <1419942046-17985-1-git-send-email-der.herr@hofr.at> In-Reply-To: <1419942046-17985-1-git-send-email-der.herr@hofr.at> Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 12/30/2014 03:20 PM, Nicholas Mc Guire wrote: > wait_for_completion_timeout does not return negative values so the tests > for <= 0 are not needed and the case differentiation in the error handling > path unnecessary. I decided to verify your statement and I saw that it seems wrong. do_wait_for_common() can return -ERESTARTSYS and the return value gets returned by its callers unchanged. > patch was only compile tested x86_64_defconfig + CONFIG_ATH_CARDS=m > CONFIG_ATH10K=m > patch is against linux-next 3.19.0-rc1 -next-20141226 Rather patches. It would have been better to send one patch instead of 4 patches with the same name. WBR, Sergei