From: Ian Abbott <abbotti@mev.co.uk>
To: David Decotigny <ddecotig@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Jeremiah Mahler <jmmahler@gmail.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>
Subject: Re: [PATCH v2] staging: comedi: dmm32at: fix style issues
Date: Tue, 30 Dec 2014 22:15:16 +0000 [thread overview]
Message-ID: <54A323F4.8010108@mev.co.uk> (raw)
In-Reply-To: <1419539308-19059-1-git-send-email-ddecotig@gmail.com>
On 25/12/14 20:28, David Decotigny wrote:
> Before:
> 1 ERROR: code indent should use tabs where possible
> 1 WARNING: please, no spaces at the start of a line
>
> After:
> (none)
>
> Signed-off-by: David Decotigny <ddecotig@gmail.com>
> ---
> drivers/staging/comedi/drivers/dmm32at.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 6df298a..31919b8 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
> @@ -365,7 +365,7 @@ static void dmm32at_setaitimer(struct comedi_device *dev, unsigned int nansec)
> /* enable the ai conversion interrupt and the clock to start scans */
> outb(DMM32AT_INTCLK_ADINT |
> DMM32AT_INTCLK_CLKEN | DMM32AT_INTCLK_CLKSEL,
> - dev->iobase + DMM32AT_INTCLK_REG);
> + dev->iobase + DMM32AT_INTCLK_REG);
> }
>
> static int dmm32at_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2014-12-30 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 20:28 [PATCH v2] staging: comedi: dmm32at: fix style issues David Decotigny
2014-12-27 7:00 ` Sudip Mukherjee
2014-12-29 23:18 ` David Decotigny
[not found] ` <CAG88wWZjqr8U=TtSaTGHnn=05d2QFQ3en7ndeK2sPq+-PFT=0w@mail.gmail.com>
2014-12-30 6:25 ` Sudip Mukherjee
2014-12-30 22:15 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A323F4.8010108@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=ddecotig@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jmmahler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.